[Bug 288463] New: hyphen-used-as-minus-sign cleanup_digikamdb.1 digitaglinktree.1

classic Classic list List threaded Threaded
14 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 288463] New: hyphen-used-as-minus-sign cleanup_digikamdb.1 digitaglinktree.1

Mark Purcell
https://bugs.kde.org/show_bug.cgi?id=288463

           Summary: hyphen-used-as-minus-sign  cleanup_digikamdb.1
                    digitaglinktree.1
           Product: digikam
           Version: 2.3.0
          Platform: Debian unstable
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: NOR
         Component: Documentation
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           2.3.0 (using KDE 4.7.3)
OS:                Linux

These manual page seems to contain a hyphen where a minus sign was intended. By
default, "-" chars are interpreted as hyphens (U+2010) by groff, not as minus
signs (U+002D). Since options to programs use minus signs (U+002D), this means
for example in UTF-8 locales that you cannot cut and paste options, nor search
for them easily.

"-" must be escaped ("\-") to be interpreted as minus. If you really intend a
hyphen (normally you don't), write it as "\(hy" to emphasise that fact.

If you use some tool that converts your documentation to groff format, this tag
may indicate a bug in the tool. Some tools convert dashes of any kind to
hyphens. The safe way of converting dashes is to convert them to "\-".

Severity: wishlist, Certainty: possible

Reproducible: Always

Steps to Reproduce:
source code inspection

Actual Results:  
hyphen-used-as-minus-sign
usr/share/man/man1/cleanup_digikamdb.1.gz:18
usr/share/man/man1/digitaglinktree.1.gz 14 more occurrences not shown
usr/share/man/man1/digitaglinktree.1.gz:30
usr/share/man/man1/digitaglinktree.1.gz:33
usr/share/man/man1/digitaglinktree.1.gz:46
usr/share/man/man1/digitaglinktree.1.gz:52
usr/share/man/man1/digitaglinktree.1.gz:75
usr/share/man/man1/digitaglinktree.1.gz:76
usr/share/man/man1/digitaglinktree.1.gz:81
usr/share/man/man1/digitaglinktree.1.gz:83
usr/share/man/man1/digitaglinktree.1.gz:88
usr/share/man/man1/digitaglinktree.1.gz:97

Expected Results:  
"-" must be escaped ("\-") to be interpreted as minus

OS: Linux (x86_64) release 3.1.0-1-amd64
Compiler: gcc

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 288463] hyphen-used-as-minus-sign cleanup_digikamdb.1 digitaglinktree.1

Gilles Caulier-4
https://bugs.kde.org/show_bug.cgi?id=288463


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2011-12-08 10:12:38 ---
Patch will be appreciate...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 288463] hyphen-used-as-minus-sign cleanup_digikamdb.1 digitaglinktree.1

Saurabh Patel
In reply to this post by Mark Purcell
https://bugs.kde.org/show_bug.cgi?id=288463

saurabh <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from saurabh <[hidden email]> ---
Gilles,
   I am interested in working on this bug.I wanted to ask whether "-" is to be
escaped as "\-" only in the 2 files digikaminktree1 and
cleanup_digikamdb.1.Also is there any command which shows occurence of all such
"-" symbols so that none of the symbol is left in escaping as Mark has shown in
his comment which shows occurences of "-"

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 288463] hyphen-used-as-minus-sign cleanup_digikamdb.1 digitaglinktree.1

Gilles Caulier-4
In reply to this post by Mark Purcell
https://bugs.kde.org/show_bug.cgi?id=288463

--- Comment #3 from Gilles Caulier <[hidden email]> ---
Saurabh,

I don't know about man page syntax.  Try to google the problem.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 288463] hyphen-used-as-minus-sign cleanup_digikamdb.1 digitaglinktree.1

Saurabh Patel
In reply to this post by Mark Purcell
https://bugs.kde.org/show_bug.cgi?id=288463

--- Comment #4 from saurabh <[hidden email]> ---
Gilles and Mark,
I am adding attachment of the files after correcting the required files.
So,please review it Mark since Gilles didn't have much idea about manpage
syntax
It's sort of patch for the bug but I couldn't make a diff file since it is not
in my build directory

Thanks

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 288463] hyphen-used-as-minus-sign cleanup_digikamdb.1 digitaglinktree.1

Saurabh Patel
In reply to this post by Mark Purcell
https://bugs.kde.org/show_bug.cgi?id=288463

--- Comment #5 from saurabh <[hidden email]> ---
Created attachment 78750
  --> https://bugs.kde.org/attachment.cgi?id=78750&action=edit
escaped "-" as required by groff

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 288463] hyphen-used-as-minus-sign cleanup_digikamdb.1 digitaglinktree.1

Saurabh Patel
In reply to this post by Mark Purcell
https://bugs.kde.org/show_bug.cgi?id=288463

--- Comment #6 from saurabh <[hidden email]> ---
Created attachment 78751
  --> https://bugs.kde.org/attachment.cgi?id=78751&action=edit
escaped "-" as required by groff in digitaglinktree.1

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 288463] hyphen-used-as-minus-sign cleanup_digikamdb.1 digitaglinktree.1

Saurabh Patel
In reply to this post by Mark Purcell
https://bugs.kde.org/show_bug.cgi?id=288463

saurabh <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78750|0                           |1
        is obsolete|                            |
  Attachment #78751|0                           |1
        is obsolete|                            |

--- Comment #7 from saurabh <[hidden email]> ---
Created attachment 78781
  --> https://bugs.kde.org/attachment.cgi?id=78781&action=edit
proper diff file for patch

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 288463] hyphen-used-as-minus-sign cleanup_digikamdb.1 digitaglinktree.1

Smit Mehta
In reply to this post by Mark Purcell
https://bugs.kde.org/show_bug.cgi?id=288463

Smit Mehta <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #8 from Smit Mehta <[hidden email]> ---
Hi saurabh

The patch is giving HUNK errors while applying. Can you please update your
patch for the current git repo?

Smit

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 288463] hyphen-used-as-minus-sign cleanup_digikamdb.1 digitaglinktree.1

Saurabh Patel
In reply to this post by Mark Purcell
https://bugs.kde.org/show_bug.cgi?id=288463

--- Comment #9 from saurabh <[hidden email]> ---
Hi Smit,
   Can you give me information about the errors which you are getting while
applying so that I could update my patch accordingly

Saurabh

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 288463] hyphen-used-as-minus-sign cleanup_digikamdb.1 digitaglinktree.1

Smit Mehta
In reply to this post by Mark Purcell
https://bugs.kde.org/show_bug.cgi?id=288463

--- Comment #10 from Smit Mehta <[hidden email]> ---
patching file utilities/scripts/cleanup_digikamdb/cleanup_digikamdb.1
patching file utilities/scripts/digitaglinktree/digitaglinktree.1
Hunk #4 FAILED at 72.
Hunk #8 FAILED at 173.
2 out of 8 hunks FAILED -- saving rejects to file
utilities/scripts/digitaglinktree/digitaglinktree.1.rej
patching file utilities/kipiiface/kipiinterface.cpp
Hunk #1 FAILED at 173.
1 out of 1 hunk FAILED -- saving rejects to file
utilities/kipiiface/kipiinterface.cpp.rej

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 288463] hyphen-used-as-minus-sign cleanup_digikamdb.1 digitaglinktree.1

Saurabh Patel
In reply to this post by Mark Purcell
https://bugs.kde.org/show_bug.cgi?id=288463

saurabh <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78781|0                           |1
        is obsolete|                            |

--- Comment #11 from saurabh <[hidden email]> ---
Created attachment 78926
  --> https://bugs.kde.org/attachment.cgi?id=78926&action=edit
updated patch

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 288463] hyphen-used-as-minus-sign cleanup_digikamdb.1 digitaglinktree.1

Smit Mehta
In reply to this post by Mark Purcell
https://bugs.kde.org/show_bug.cgi?id=288463

--- Comment #12 from Smit Mehta <[hidden email]> ---
Still not working.

patching file utilities/scripts/cleanup_digikamdb/cleanup_digikamdb.1
patching file utilities/scripts/digitaglinktree/digitaglinktree.1
Hunk #4 FAILED at 72.
patch: **** malformed patch at line 181:  

Kindly test it against the latest git and then post it. For testing it,
(a) Create the patch and save it somewhere
(b) Checkout all the changes in the local repo, update your repo
(c) Reapply the patch and see if it works.

Smit

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 288463] hyphen-used-as-minus-sign cleanup_digikamdb.1 digitaglinktree.1

bugzilla_noreply
In reply to this post by Mark Purcell
https://bugs.kde.org/show_bug.cgi?id=288463

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|minor                       |normal

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel