[Bug 287772] New: build failed against boost-1.48

[Geoff King-4]

https://bugs.kde.org/show_bug.cgi?id=287772





--- Comment #19 from Geoff King <gsking1 gmail com>  2011-12-27 17:22:56 ---
Created an attachment (id=67164)
 --> (http://bugs.kde.org/attachment.cgi?id=67164)
Also in Macports version.

Hello. This also appears in macports. I just ran into this issue and here is a
link to a bug report by someone else.  https://trac.macports.org/ticket/32524
Macports uses:
boost @1.48.0, Revision 3 (devel)
digikam @2.1.1, Revision 1 (kde, kde4)

Only the end of the log file is attached.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=287772





--- Comment #20 from Chris Tanner <christopher tanner sympatico ca>  2011-12-30 00:44:52 ---
(In reply to comment #18)
> (In reply to comment #17)
> > I don't have the tools to build Digikam, so I could write a patch but not
> > easily test it.  The calls being removed and changed are those inside your
> > Digikam code, not anything in Boost (or that calls Boost directly).
>
> I can test any patch you can provide, I'm having this build fail right now and
> I have all the environment ready.

I can also test any patch. I have an X86_64 environment.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=287772


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |267777




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=287772


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #21 from Gilles Caulier <caulier gilles gmail com>  2012-01-04 08:56:40 ---
Marcel,

Please, see my comment #8.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=287772





--- Comment #22 from Alex Merry <kde randomguy3 me uk>  2012-01-04 21:57:19 ---
Created an attachment (id=67460)
 --> (http://bugs.kde.org/attachment.cgi?id=67460)
Build fix for boost 1.48

This patch fixes the build under boost 1.48.

I believe it should still work under older versions of boost.  Can someone
check, please?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=287772


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|build failed against        |build failed against
                   |boost-1.48                  |boost-1.48 [patch]




--- Comment #23 from Gilles Caulier <caulier gilles gmail com>  2012-01-04 22:03:20 ---
Alex,

Thanks a lots for your patch. Tomorow, i will take a look if all compile fine
with previous version of boost (1.46)

Some other people can check if patch compile AND work fine. Typically code
relevant is used to manage image versioning in image editor. Look bug 267777
for details.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[nucleo]

https://bugs.kde.org/show_bug.cgi?id=287772





--- Comment #24 from nucleo <nucleo fedoraproject org>  2012-01-04 23:11:32 ---
digikam-2.5.0 build failed against boost-1.47 after I applied patch
digikam-boost-1.48.diff.
See build log here http://nucleo.fedorapeople.org/digikam-boost-1.47.log

Unfortunately I am not able to test build against boost-1.48 because of
recently added gcc-4.7.0 to Fedora Rawhide (See bug 290642 )

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=287772


Angelo Naselli <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[hidden email]
     Ever Confirmed|0                           |1




--- Comment #25 from Angelo Naselli <anaselli linux it>  2012-01-04 23:55:27 ---
I confirm patch in Comment #22 builds, but Marcel should tell if it's also
right imo :)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=287772





--- Comment #26 from Chris Tanner <christopher tanner sympatico ca>  2012-01-05 00:17:25 ---
Compiles and runs here also. How does one check that the patch is working?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[nucleo]

https://bugs.kde.org/show_bug.cgi?id=287772





--- Comment #27 from nucleo <nucleo fedoraproject org>  2012-01-05 01:58:13 ---
After fixing gcc-4.7.0 related issues digikam-2.5.0 build completed against
boost-1.48.
But this patch broke build against boost-1.47.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=287772





--- Comment #28 from Gilles Caulier <caulier gilles gmail com>  2012-01-05 08:13:11 ---
To Nucleo, #27

I just tested under Mageia 1 with Boost 1.46, and all compile fine. I cannot
test with boost 1.47.

To Chris, #26,

To check if versioning work fine, we have test unit program in digiKam core.
Compile it with whole application to check if it work. To enable tests, add
"-DKDE4_BUILD_TESTS=on" option to cmake command line to configure compilation.
Results are something like this :


[gilles@localhost core (master)]$ patch -p1 < digikam-boost-1.48.diff
patching file libs/database/imagehistory/imagehistorygraph_boost.h

[gilles@localhost core (master)]$
[gilles@localhost core (master)]$ pwd
/mnt/data/Devel/GIT/2.x/build/core
[gilles@localhost core (master)]$ make
[  0%] Built target digikam-gitversion
[  0%] Built target digikamcore_automoc
[  0%] Built target kexiv2_automoc                                              
[  1%] Built target kexiv2                                                      
[  1%] Built target kipi_automoc                                                
[  3%] Built target kipi                                                        
[  3%] Built target kdcraw_automoc                                              
[  3%] Built target libraw_automoc                                              
[  5%] Built target libraw                                                      
[  5%] Built target kdcraw
[  5%] Built target kface_automoc
[  7%] Built target kface
[  7%] Built target kgeomap_automoc
[  9%] Built target kgeomap
[ 45%] Built target digikamcore
[ 45%] Built target testlensfuniface_automoc
[ 45%] Built target testlensfuniface
[ 45%] Built target digikamdatabase_automoc
Scanning dependencies of target digikamdatabase
[ 45%] Building CXX object
core/digikam/CMakeFiles/digikamdatabase.dir/__/libs/database/imagehistory/imagehistorygraph.cpp.o
[ 45%] Building CXX object
core/digikam/CMakeFiles/digikamdatabase.dir/__/libs/database/imagehistory/imagehistorygraphmodel.cpp.o
Linking CXX shared library ../../lib/libdigikamdatabase.so                      
[ 54%] Built target digikamdatabase                                            
[ 54%] Built target advancedrename_automoc
[ 58%] Built target advancedrename
[ 58%] Built target cameragui_automoc
[ 62%] Built target cameragui
[ 62%] Built target queuemanager_automoc
[ 67%] Built target queuemanager
[ 67%] Built target digikam_automoc
Linking CXX executable digikam
[ 86%] Built target digikam                                                    
[ 86%] Built target digikamnepomukservice_automoc
Linking CXX shared module ../../lib/digikamnepomukservice.so
[ 88%] Built target digikamnepomukservice                                      
[ 88%] Built target kio_digikamalbums_automoc
Linking CXX shared module ../../lib/kio_digikamalbums.so
[ 90%] Built target kio_digikamalbums                                          
[ 90%] Built target kio_digikamdates_automoc
Linking CXX shared module ../../lib/kio_digikamdates.so
[ 90%] Built target kio_digikamdates                                            
[ 90%] Built target kio_digikammapimages_automoc
Linking CXX shared module ../../lib/kio_digikammapimages.so
[ 90%] Built target kio_digikammapimages                                        
[ 90%] Built target kio_digikamsearch_automoc
Linking CXX shared module ../../lib/kio_digikamsearch.so
[ 90%] Built target kio_digikamsearch                                          
[ 90%] Built target kio_digikamtags_automoc
Linking CXX shared module ../../lib/kio_digikamtags.so
[ 90%] Built target kio_digikamtags                                            
[ 90%] Built target showfoto_automoc
[ 90%] Built target showfoto
[ 90%] Built target digikamimageplugin_color_automoc
[ 92%] Built target digikamimageplugin_color
[ 92%] Built target digikamimageplugin_decorate_automoc
[ 92%] Built target digikamimageplugin_decorate
[ 92%] Built target digikamimageplugin_enhance_automoc
[ 94%] Built target digikamimageplugin_enhance
[ 94%] Built target digikamimageplugin_fxfilters_automoc
[ 96%] Built target digikamimageplugin_fxfilters
[ 96%] Built target digikamimageplugin_transform_automoc
[ 96%] Built target digikamimageplugin_transform
[ 96%] Built target digikamdatabaseserver_automoc
Linking CXX executable digikamdatabaseserver
[ 96%] Built target digikamdatabaseserver
[ 96%] Built target advancedrenametest_automoc
Linking CXX executable advancedrenametest
[ 96%] Built target advancedrenametest
[ 96%] Built target cameranamehelpertest_automoc
Linking CXX executable cameranamehelpertest
[ 96%] Built target cameranamehelpertest
[ 96%] Built target dimagefilteractiontest_automoc
[ 96%] Built target dimagefilteractiontest
[ 96%] Built target dimagehistorygraphtest_automoc
Scanning dependencies of target dimagehistorygraphtest
[ 96%] Building CXX object
core/tests/CMakeFiles/dimagehistorygraphtest.dir/dimagehistorygraphtest.cpp.o
Linking CXX executable dimagehistorygraphtest
[ 96%] Built target dimagehistorygraphtest
[ 96%] Built target dimagehistorytest_automoc
[ 96%] Built target dimagehistorytest
[ 96%] Built target filesaveoptionsboxtest_automoc
[ 96%] Built target filesaveoptionsboxtest
[ 96%] Built target freerotationtest_automoc
[ 96%] Built target freerotationtest
[ 96%] Built target loadpgfdata_automoc
[ 96%] Built target loadpgfdata
[ 96%] Built target pgfscaled_automoc
[ 96%] Built target pgfscaled
[ 96%] Built target qtpgftest_automoc
[ 96%] Built target qtpgftest
[ 96%] Built target searchtextbartest_automoc
[ 98%] Built target searchtextbartest
[ 98%] Built target statesavingobjecttest_automoc
[100%] Built target statesavingobjecttest
[100%] Built target uifilevalidatortest_automoc
Linking CXX executable uifilevalidatortest
[100%] Built target uifilevalidatortest

The most important part is dimagehistorygraphtest program which unit test about
versioning. It must compile fine on your computer with new boost 1.48 version.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=287772





--- Comment #29 from Angelo Naselli <anaselli linux it>  2012-01-05 11:05:51 ---
To nucleo Comment #27 since it builds with 1.46 i suspect the problem is in a
line of the patch that report boost version, did you try to remove the "="?
#if BOOST_VERSION > 104700
        Edge(const boost::detail::reverse_graph_edge_descriptor<edge_t>& e) :
e(e.underlying_desc), null(false) {}
#endif
I'm not sure but maybe boost::detail::reverse_graph_edge_descriptor is not in
1.47.

btw, i'm testing a ugly patch that add all the changes for BOOST_VERSION >
104700
maybe you can try that one also (i will upload it as soon as i tested it).

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=287772





--- Comment #30 from Angelo Naselli <anaselli linux it>  2012-01-05 11:31:25 ---
Created an attachment (id=67481)
 --> (http://bugs.kde.org/attachment.cgi?id=67481)
adapted patch to work with old boost version

this patch should work with old boost version also, even if i suspect the
solution
is just to remove the "=" in the BOOST_VERSION check

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[nucleo]

https://bugs.kde.org/show_bug.cgi?id=287772





--- Comment #31 from nucleo <nucleo fedoraproject org>  2012-01-05 13:05:43 ---
(In reply to comment #30)
> Created an attachment (id=67481)
 --> (http://bugs.kde.org/attachment.cgi?id=67481) [details]
> adapted patch to work with old boost version
>
> this patch should work with old boost version also, even if i suspect the
> solution
> is just to remove the "=" in the BOOST_VERSION check

Now builds successful with both boost 1.47 and 1.48.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=287772





--- Comment #32 from Gilles Caulier <caulier gilles gmail com>  2012-01-05 13:08:49 ---
To Nucleo,

And test program compile file with 1.47 and 1.48 as i explain in #28 ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=287772





--- Comment #33 from Jeremiah Willcock <jewillco osl iu edu>  2012-01-05 13:23:49 ---
I haven't had a chance to try this, but I think you should be able to get away
with just the last hunk from the patch if you use toList rather than toEdgeList
(and thus avoid any of the edge conversion stuff).

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=287772





--- Comment #34 from Jeremiah Willcock <jewillco osl iu edu>  2012-01-05 13:35:07 ---
Created an attachment (id=67482)
 --> (http://bugs.kde.org/attachment.cgi?id=67482)
My proposed patch (not tested)

This is my proposed patch, which I'm not able to test.  Please see if it works
(it might need some minor tweaks).

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=287772





--- Comment #35 from Jeremiah Willcock <jewillco osl iu edu>  2012-01-05 13:36:48 ---
A couple of other issues in that file -- the "stack" variable and "VertexInfo"
type do not appear to be used anywhere, and the call to "boost::target" should
be just "target" if you want the code to work on user-defined graphs.  My patch
does not fix either of these issues.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=287772


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67460|0                           |1
        is obsolete|                            |




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=287772


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #36 from Gilles Caulier <caulier gilles gmail com>  2012-01-05 13:39:08 ---
Someone can check if patch from Jeremiah #67482 compile fine and if unit tests
are passed using Boost 1.47 and 1.48 ?

Thanks in advance

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel