[Bug 287646] New: Digikam import dialog locks if main window closed. Needs to be killed.

[Cristian Tibirna]

https://bugs.kde.org/show_bug.cgi?id=287646

           Summary: Digikam import dialog locks if main window closed.
                    Needs to be killed.
           Product: digikam
           Version: 2.3.0
          Platform: openSUSE RPMs
        OS/Version: Linux
            Status: NEW
          Severity: crash
          Priority: NOR
         Component: Import
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           2.3.0 (using KDE 4.7.3)
OS:                Linux

I import files (nikon raw and paired jpeg, but I doubt it is relevant) from SD
card. If I close main window, the download stops and nothing is active on the
import dialog. I have to kill it in order to be able to start a new digikam.

Reproducible: Always

Steps to Reproduce:
Start digikam start an import. Close the main window while the download
proceeds.

Actual Results:  
Import dialog locks up.

Expected Results:  
Download should continue and digikam quit properly once the download is
finished.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=287646


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2011-11-27 10:21:47 ---
can you reproduce the problem to run digiKam through GDB, and see where in
source code import dialog continue to run when main window is closed ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Cristian Tibirna]

https://bugs.kde.org/show_bug.cgi?id=287646





--- Comment #2 from Cristian Tibirna <tibirna kde org>  2011-11-27 19:34:37 ---
It seems I'm not very good with console gdb. The sole relevant bit of trace I
get is

#0  0x00007fffef4d5e6c in pthread_cond_wait@@GLIBC_2.3.2 () from
/lib64/libpthread.so.0
#1  0x00007ffff31224bb in QWaitCondition::wait(QMutex*, unsigned long) () from
/usr/lib64/libQtCore.so.4
#2  0x00007ffff3121d6c in QThread::wait(unsigned long) () from
/usr/lib64/libQtCore.so.4

But in kdbg, I can see (and I reconstruct by hand below) that the frames just
above these are in the destructor:
Digikam::CameraController::~CameraController()
Digikam::CameraUI::~CameraUI()
QObjectPrivate::deleteChildren()
QWidget::~QWidget()
Digikam::DigikamApp::~DigikamApp()
QObject::event()

(the event having to be my quit request -- which I did by the windowmanger
close button)

Conclusion: threads lock. I would have to learn how to observe threads in a
debugger (... yes, I know...). I wasn't able to extract anything intelligent
from gdb or kdbg related to this.

Merci pour la compréhension.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=287646

--- Comment #3 from Gilles Caulier <[hidden email]> ---
Official digiKam 2.6.0 release is out since few days now :

http://www.digikam.org/drupal/node/656

Please, check if this entry still valid, or update report accordingly.

Thanks in advance.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Cristian Tibirna]

https://bugs.kde.org/show_bug.cgi?id=287646

--- Comment #4 from Cristian Tibirna <[hidden email]> ---
Unfortunately I can't compile and test 2.6 right now. But with 2.5.0 on KDE
4.8.4 release 513 (OpenSUSE 12.1 rpms) I can still reproduce the lock.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Cristian Tibirna]

https://bugs.kde.org/show_bug.cgi?id=287646

--- Comment #5 from Cristian Tibirna <[hidden email]> ---
Unfortunately I can't compile and test 2.6 right now. But with 2.5.0 on KDE
4.8.4 release 513 (OpenSUSE 12.1 rpms) I can still reproduce the lock.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Teemu Rytilahti]

https://bugs.kde.org/show_bug.cgi?id=287646

Teemu Rytilahti <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #6 from Teemu Rytilahti <[hidden email]> ---
Confirmed with current master. Relevant code:
void FileActionMngr::shutDown()
{
    d->dbWorker->deactivate();
    d->fileWorker->deactivate();
    d->dbWorker->wait();
    d->fileWorker->wait(); <-- this causes it to hang.
}

Tried passing WorkerObject::PhaseOut to deactivate(), but it didn't help.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=287646

--- Comment #7 from Gilles Caulier <[hidden email]> ---
digiKam 4.0.0 is out :

http://www.digikam.org/node/713

Please check if this entry still valid with this new version.

Thanks in advance

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=287646

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
   Version Fixed In|                            |4.1.0
         Resolution|---                         |FIXED

--- Comment #8 from Gilles Caulier <[hidden email]> ---
With last digiKam 4.0.0, closing AlbumGUI during downloading, download
processing continue until it finished. digiKam do not crash and close properly
at end...

I close this file now.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Cristian Tibirna]

https://bugs.kde.org/show_bug.cgi?id=287646

--- Comment #9 from Cristian Tibirna <[hidden email]> ---
Very sorry for the delay on this. Indeed, the problem reported is fixed with
digikam-4.0.0. Thanks a lot for taking care of this.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel