[Bug 283491] New: Caption/Tags tab: Active sub-tab not restored after restart

[Michael G. Hansen]

https://bugs.kde.org/show_bug.cgi?id=283491

           Summary: Caption/Tags tab: Active sub-tab not restored after
                    restart
           Product: digikam
           Version: 2.3.0
          Platform: Compiled Sources
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: NOR
         Component: Metadata
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           2.3.0 (using KDE 4.6.2)
OS:                Linux

When opening the Caption/Tags tab, the "Information" sub-tab is always active
after starting digikam, even though I activated the "Description" sub-tab
before closing digikam.

Reproducible: Always

Steps to Reproduce:
1. Activate "Description" sub-tab
2. Close digikam
3. Start digikam again -> "Information" sub-tab is active


Expected Results:  
"Description" sub-tab should be active.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michael G. Hansen]

https://bugs.kde.org/show_bug.cgi?id=283491


Michael G. Hansen <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |junior-jobs




--- Comment #1 from Michael G. Hansen <mike mghansen de>  2011-10-06 20:03:13 ---
Should be easy enough for a junior-job.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=283491


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|Metadata                    |Albums GUI




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Islam Wazery]

https://bugs.kde.org/show_bug.cgi?id=283491


Menopia <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #2 from Menopia <wazery ubuntu com>  2011-12-21 10:04:25 ---
For me, this bug never reproduced, I doubt that it is still exist!

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michael G. Hansen]

https://bugs.kde.org/show_bug.cgi?id=283491


Michael G. Hansen <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|2.3.0                       |2.5.0




--- Comment #3 from Michael G. Hansen <mike mghansen de>  2011-12-27 15:27:19 ---
Still there in current git master.

The behavior is still there, only the other way around: The "Description"
sub-tab is always the active tab after a restart of digikam, no matter whether
the "Tags" or "Information" sub-tab was active before.

Michael

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Islam Wazery]

https://bugs.kde.org/show_bug.cgi?id=283491





--- Comment #4 from Menopia <wazery ubuntu com>  2011-12-27 15:50:21 ---
OK, I am working on a patch for it :)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Islam Wazery]

https://bugs.kde.org/show_bug.cgi?id=283491





--- Comment #5 from Menopia <wazery ubuntu com>  2011-12-28 15:10:45 ---
Created an attachment (id=67188)
 --> (http://bugs.kde.org/attachment.cgi?id=67188)
Enable restoring of active sub-tab for Captions-Tag sidebar

Here is a patch that solve this bug, but it needs more lines of code to also
solve bug #234067

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michael G. Hansen]

https://bugs.kde.org/show_bug.cgi?id=283491





--- Comment #6 from Michael G. Hansen <mike mghansen de>  2011-12-28 16:06:03 ---
Hi Menopia,

I think it is best to only submit a patch here fixing this bug, and to later
submit a separate patch to fix another (unrelated) bug. This makes it easier to
see what was done in the git history later.

Can you re-send your patch with just the relevant code for this bug?

Thanks,

Michael

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Islam Wazery]

https://bugs.kde.org/show_bug.cgi?id=283491





--- Comment #7 from Menopia <wazery ubuntu com>  2011-12-28 19:09:57 ---
Created an attachment (id=67199)
 --> (http://bugs.kde.org/attachment.cgi?id=67199)
Enable restoring of active sub-tab for Captions\Tag

OK, here is the edited patch

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=283491


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Caption/Tags tab: Active    |Caption/Tags tab: Active
                   |sub-tab not restored after  |sub-tab not restored after
                   |restart                     |restart [patch]




--- Comment #8 from Gilles Caulier <caulier gilles gmail com>  2011-12-28 20:22:25 ---
Menopia,

Thanks for your patch.

Please if old patch #67188 fix bug #234067, attach changes in this file. Like
this, we will close 2 files before 2.5.0, planed on next sunday.

Michael,

Did you review this patch ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=283491


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67188|0                           |1
        is obsolete|                            |




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Islam Wazery]

https://bugs.kde.org/show_bug.cgi?id=283491


Menopia <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67199|0                           |1
        is obsolete|                            |




--- Comment #9 from Menopia <wazery ubuntu com>  2012-01-03 04:10:49 ---
Created an attachment (id=67367)
 --> (http://bugs.kde.org/attachment.cgi?id=67367)
Enable restoring of active sub-tab in the ImageDescEdit tab and its languages
after restart

Hi Michael, and Gilles,

This patch fixes both bug #283491 and bug #234067. Also here is a needed patch
I made for libkexiv2 http://bit.ly/rNUlcf to fix the bugs.

I am sorry Michael for sending a single patch for both bugs.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=283491





--- Comment #10 from Gilles Caulier <caulier gilles gmail com>  2012-01-03 14:55:57 ---
Islam,

Your patch from : http://bit.ly/rNUlcf

... is not for libkexiv2. There is something wrong here ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=283491





--- Comment #11 from Gilles Caulier <caulier gilles gmail com>  2012-01-03 14:57:11 ---
Islam,

Also, please, always attach patch to bugzilla for QA. Do not provide an
external link. Thanks in advance

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=283491





--- Comment #12 from Gilles Caulier <caulier gilles gmail com>  2012-01-06 10:38:24 ---
Islam,

Do you see my comments #10 and #11 ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Islam Wazery]

Hi Gilles,

I am sorry for not posting the patches, I will try to post the two patches each for its relevant bug by the end of today. I am a bit overloaded with my exams and I will finish them all in Jan 23, after that date I will be back on Digikam development which I want to be a member with its devs, and also can I ask for your mentorship in the development?

Thanks and Regards

Islam Wazery

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Islam Wazery]

https://bugs.kde.org/show_bug.cgi?id=283491





--- Comment #13 from Islam Wazery <wazery ubuntu com>  2012-01-07 14:27:54 ---
Hi Gilles,

I am sorry for not posting the patches, I will try to post the two patches
each for its relevant bug by the end of today. I am a bit overloaded with
my exams and I will finish them all in Jan 23, after that date I will be
back on Digikam development which I want to be a member with its devs, and
also can I ask for your mentorship in the development?

Thanks and Regards
Islam Wazery

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=283491





--- Comment #14 from Gilles Caulier <caulier gilles gmail com>  2012-01-07 15:53:04 ---
Islam,

Only patch from this url http://bit.ly/rNUlcf is wrong. It's not against
libkexiv2 as expected. Please attach right patch o this bugzilla enry.

For mentor-ship, yes, of course i can guide you. But please sent me a private
mail with your skill and your development preferences (gui, thread, imagery,
algorithms, database, usability, metadata, etc...). I have some tiedous topic
to do on digiKam)...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=283491


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |234067




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=283491


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67367|0                           |1
        is obsolete|                            |




--- Comment #15 from Gilles Caulier <caulier gilles gmail com>  2012-01-09 12:20:39 ---
Created an attachment (id=67613)
 --> (http://bugs.kde.org/attachment.cgi?id=67613)
reviewed patch for digiKam

reviewed patch for libkexiv2

Islam,

Look your second patch reviewed, including libkexiv2 version ID check to
prevent
broken digiKam compilation with old libkexiv2.

This patch include too :

- coding polish.
- call of ImageDescEditTab::readSettings() from
ImagePropertiesSideBarDB::doLoadState() to read properly settings from digiKam
config file.
- call of ImageDescEditTab::writeSettings() from
ImagePropertiesSideBarDB::doSaveState() to save settings to digiKam config file
- some missing call, and wrong ordering of method calls.

I place patches in bugzilla for learning purpose. Please take a look.

In all case, i will apply these patches to git /master.
Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel