[Bug 277619] New: Exclude folder/subfolder/image from database

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 277619] New: Exclude folder/subfolder/image from database

philippe.quaglia
https://bugs.kde.org/show_bug.cgi?id=277619

           Summary: Exclude folder/subfolder/image from database
           Product: digikam
           Version: 2.0.0
          Platform: Ubuntu Packages
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: Albums GUI
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           2.0.0
OS:                Linux

Currently, it is not possible to exclude a folder/subfolder/image from the
indexation. It should be usefull to be able to do it (for example, to avoid
indexing/displaying a folder with pictures used to create panoramas. Only the
panorama are relevant, the other pictures are useless).

Reproducible: Didn't try



Expected Results:  
I would expect an option "remove from database" for pictures, and "remove from
album" for folders/subfolders. All the pictures/folders/subfolders must stay on
the disk, of course...

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 277619] Exclude folder/subfolder/image from database

Gilles Caulier-4
https://bugs.kde.org/show_bug.cgi?id=277619


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|Albums GUI                  |Database




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 277619] Exclude folder/subfolder/image from database

Gilles Caulier-4
In reply to this post by philippe.quaglia
https://bugs.kde.org/show_bug.cgi?id=277619


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2011-12-15 09:48:08 ---
*** Bug 253815 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 277619] SETUP : Exclude folder/subfolder/image from database

Gilles Caulier-4
In reply to this post by philippe.quaglia
https://bugs.kde.org/show_bug.cgi?id=277619

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Exclude                     |SETUP : Exclude
                   |folder/subfolder/image from |folder/subfolder/image from
                   |database                    |database

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 277619] SETUP : Exclude folder/subfolder/image from database

Gilles Caulier-4
In reply to this post by philippe.quaglia
https://bugs.kde.org/show_bug.cgi?id=277619

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #2 from Gilles Caulier <[hidden email]> ---


*** This bug has been marked as a duplicate of bug 123097 ***

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [digikam] [Bug 277619] SETUP : Exclude folder/subfolder/image from database

Amilcar Lucas
Hi,

I got a small 3 line patch that sould fix this issue, but it does not
seam to work.
And I do not know why.

My image collection takes 30 minutes to load, and it crashes without a
stack trace on end so I can not fully test this.

Can someone see if it at least it is a step in the right direction ???


   diff --git a/libs/database/collectionscanner.cpp
b/libs/database/collectionscanner.cpp
   index ce2c923..a599756 100644
   --- a/libs/database/collectionscanner.cpp
   +++ b/libs/database/collectionscanner.cpp
   @@ -880,7 +880,7 @@ void CollectionScanner::scanForStaleAlbums(const
QList<int>& locationIdsToScan)
            {
                QFileInfo fileInfo(location.albumRootPath() +
(*it).relativePath);

   -            if (!fileInfo.exists() || !fileInfo.isDir())
   +            if (!fileInfo.exists() || !fileInfo.isDir() ||
fileInfo.fileName() == "@eaDir")
                {
                    toBeDeleted << (*it).id;
                    d->scannedAlbums << (*it).id;
   @@ -932,7 +932,7 @@ void CollectionScanner::scanForStaleAlbums(const
QList<int>& locationIdsToScan)
                    {
                        QFileInfo fileInfo(location.albumRootPath() +
it.key().relativePath);

   -                    if (fileInfo.exists() && fileInfo.isDir())
   +                    if (fileInfo.exists() && fileInfo.isDir() &&
fileInfo.fileName() != "@eaDir")
                        {
                            // Just set a new root/relativePath to the
album. Further scanning will care for all cases or error.
DatabaseAccess().db()->renameAlbum(it.value().albumId,
it.key().albumRootId, it.key().relativePath);
   @@ -1098,6 +1098,8 @@ void CollectionScanner::scanAlbum(const
CollectionLocation& location, const QStr
            }
            else if ( fi->isDir() )
            {
   +            if (fi->fileName() == "@eaDir") continue;
   +

Regards,
Amilcar

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [digikam] [Bug 277619] SETUP : Exclude folder/subfolder/image from database

Gilles Caulier-4
Lucas,

This file have been closed as duplicate of

https://bugs.kde.org/show_bug.cgi?id=123097

Please

- Attach your patch to this report.
- Explain exactly what you want to do with "@eaDir" pattern.
- run digiKam under GDB to get a suitable backtrace.

Best

Gilles Caulier

2014-09-16 23:43 GMT+02:00 Amilcar Lucas <[hidden email]>:

> Hi,
>
> I got a small 3 line patch that sould fix this issue, but it does not seam
> to work.
> And I do not know why.
>
> My image collection takes 30 minutes to load, and it crashes without a stack
> trace on end so I can not fully test this.
>
> Can someone see if it at least it is a step in the right direction ???
>
>
>   diff --git a/libs/database/collectionscanner.cpp
> b/libs/database/collectionscanner.cpp
>   index ce2c923..a599756 100644
>   --- a/libs/database/collectionscanner.cpp
>   +++ b/libs/database/collectionscanner.cpp
>   @@ -880,7 +880,7 @@ void CollectionScanner::scanForStaleAlbums(const
> QList<int>& locationIdsToScan)
>            {
>                QFileInfo fileInfo(location.albumRootPath() +
> (*it).relativePath);
>
>   -            if (!fileInfo.exists() || !fileInfo.isDir())
>   +            if (!fileInfo.exists() || !fileInfo.isDir() ||
> fileInfo.fileName() == "@eaDir")
>                {
>                    toBeDeleted << (*it).id;
>                    d->scannedAlbums << (*it).id;
>   @@ -932,7 +932,7 @@ void CollectionScanner::scanForStaleAlbums(const
> QList<int>& locationIdsToScan)
>                    {
>                        QFileInfo fileInfo(location.albumRootPath() +
> it.key().relativePath);
>
>   -                    if (fileInfo.exists() && fileInfo.isDir())
>   +                    if (fileInfo.exists() && fileInfo.isDir() &&
> fileInfo.fileName() != "@eaDir")
>                        {
>                            // Just set a new root/relativePath to the album.
> Further scanning will care for all cases or error.
> DatabaseAccess().db()->renameAlbum(it.value().albumId, it.key().albumRootId,
> it.key().relativePath);
>   @@ -1098,6 +1098,8 @@ void CollectionScanner::scanAlbum(const
> CollectionLocation& location, const QStr
>            }
>            else if ( fi->isDir() )
>            {
>   +            if (fi->fileName() == "@eaDir") continue;
>   +
>
> Regards,
> Amilcar
>
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 277619] SETUP : Exclude folder/subfolder/image from database

bugzilla_noreply
In reply to this post by philippe.quaglia
https://bugs.kde.org/show_bug.cgi?id=277619

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/dig
                   |                            |ikam/e9bc2261c28fd55cf9f128
                   |                            |5f51dbee93f4a3e3c3
   Version Fixed In|                            |5.7.0
         Resolution|DUPLICATE                   |FIXED
          Component|Database                    |Database-Setup

--- Comment #3 from [hidden email] ---
Git commit e9bc2261c28fd55cf9f1285f51dbee93f4a3e3c3 by Gilles Caulier.
Committed on 21/02/2017 at 18:53.
Pushed by cgilles into branch 'master'.

Apply patch #104043 from Jan Wolter to ignore some kind of directories at
collections
scan and to prevent to bloat database with unwanted/unecessary entries.
FIXED-IN: 5.5.0

M  +3    -1    NEWS
M  +69   -157  libs/database/collection/collectionscanner.cpp
M  +12   -8    libs/database/collection/collectionscanner.h
M  +154  -83   libs/database/coredb/coredb.cpp
M  +12   -4    libs/database/coredb/coredb.h
M  +14   -3    libs/database/coredb/coredbschemaupdater.cpp
M  +5    -3    libs/database/coredb/coredbschemaupdater.h
M  +93   -11   libs/database/utils/dbsettingswidget.cpp
M  +6    -2    libs/database/utils/dbsettingswidget.h
M  +6    -2    utilities/setup/setupdatabase.cpp
M  +2    -2    utilities/setup/setupdatabase.h

https://commits.kde.org/digikam/e9bc2261c28fd55cf9f1285f51dbee93f4a3e3c3

--
You are receiving this mail because:
You are the assignee for the bug.