[Bug 277370] New: Unclear licensing for profiles/prophoto.icm and profiles/srgb-d65.icm

https://bugs.kde.org/show_bug.cgi?id=277370

           Summary: Unclear licensing for profiles/prophoto.icm and
                    profiles/srgb-d65.icm
           Product: digikam
           Version: unspecified
          Platform: Ubuntu Packages
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: libkdcraw
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           unspecified (using Devel)
OS:                Linux

While uploading libkdcraw-4.6.90 to the kubuntu archive it was discovered that
the licensing for the ICM profiles is unclear. Grepping through the files you
find:

profiles/prophoto.icm
Copyright (C) 1999-2005 Scarse Project

profiles/srgb-d65.icm
Copyright (c) 1998 Hewlett-Packard Company

The first one seems to be from the Editor it was created with but for the
second one it's origin is unclear.

Under what license are the profiles shipped in libkdcraw?

Reproducible: Didn't try

Steps to Reproduce:
-


Expected Results:  
-

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=277370


Philip Muskovac <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email],
                   |                            |[hidden email]




--- Comment #1 from Philip Muskovac <yofel gmx net>  2011-07-08 15:42:24 ---
CC-ing Gilles Caulier since he added the files to svn.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=277370





--- Comment #2 from Gilles Caulier <caulier gilles gmail com>  2011-07-08 17:35:53 ---
File come from krita, duplicated from old svn KDE repository.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=277370





--- Comment #3 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-07-11 16:21:40 ---
Scarse project is a free software project, inactive since 2005. A library with
profiles is offered. There is no license explicitly mentioned:
http://www.scarse.org/

Regarding the second, the sRGB was originally suggested by HP and MS in 1996,
so it may be an original profile. You can still download sRGB profiles today
for free redistribution from color.org, but they are not identical.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=277370


Jonathan Riddell <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #4 from Jonathan Riddell <jr jriddell org>  2011-07-12 15:32:14 ---
srgb-d65.icm comes from Windows, there's nothing to suggest it's under a free
licence so it needs to be removed.

I recommend added the README file from Krita to clarify the rest

"The icm profile files have been downloaded from the littlecms
(http://www.littlecms.com) and from the Scarse website
(http://www.scarse.org). The Scarse profiles have been available under
the GPL; the littlecms profiles appear to be public domain.
"

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=277370





--- Comment #5 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-07-12 18:38:59 ---
Are the color.org Terms of Use acceptable?

To anyone who acknowledges that the files
"sRGB_IEC61966-2-1_no_black_scaling.icc" and "sRGB_IEC61966-2-1_black
scaled.icc" are provided "AS IS" WITH NO EXPRESS OR IMPLIED WARRANTY,
permission to use, copy and distribute these file for any purpose is hereby
granted without fee, provided that the files are not changed including the ICC
copyright notice tag, and that the name of ICC shall not be used in advertising
or publicity pertaining to distribution of the software without specific,
written prior permission. ICC makes no representations about the suitability of
this software for any purpose.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=277370





--- Comment #6 from Gilles Caulier <caulier gilles gmail com>  2011-12-15 12:32:48 ---
Jonathan,

Do you see comment #5 from Marcel ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=277370





--- Comment #7 from Jonathan Riddell <jr jriddell org>  2011-12-15 16:08:06 ---
"provided that the files are not changed" this isn't acceptable within free
software and will cause problems for many of our downstream distributions.  So
I'm afraid the file needs to be removed.  Maybe adding an internet fetch method
as an alternative.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=277370

Kai-Uwe Behrmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #8 from Kai-Uwe Behrmann <[hidden email]> ---
I had to remove many of the Scarse profiles from Krita due to colorimetry bugs.

OpenICC has a set of profiles for many purposes. A wide gamut profiles in this
collection
are LStar-RGB, which is similar to  ECIv2-RGB but licensed like all others
under libpng/zlib.
compatibleWithAdobeRGB1998.icc is a replacement for AdobeRGB. AdobeRGB is not
freely distributable.

More infos on the OpenICC wiki:
http://www.freedesktop.org/wiki/OpenIcc#Profiles_for_standard_print_condition_and_their_licenses
http://www.freedesktop.org/wiki/OpenIcc/ProfilePackages
Source Package:
http://sourceforge.net/projects/openicc/files/

As these ICC profiles are required by Oyranos, they are already packaged by
many distributions. Debian has them as well in the icc-profiles package.

A real replacement for ProPhotoRGB is not easy. ProPhotoRGB uses a gamma of
1.8, which is not so good for gamma 2.2 and sRGB systems. A replacement needs
some discussion on OpenICC.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=277370

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #9 from Gilles Caulier <[hidden email]> ---
Thanks Kai for your feedback.

Francesco, perhaps you can take a look this recommendation from comment #8 to
replace files with redistributable version, as you use CM on your computer ?

Thanks in advance

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Francesco Riosa-2]

https://bugs.kde.org/show_bug.cgi?id=277370

--- Comment #10 from Francesco Riosa <[hidden email]> ---
Created attachment 69786
  --> https://bugs.kde.org/attachment.cgi?id=69786&action=edit
elenco_icc.txt

tl;dr My suggestion is keep out of that mess, keep a short list of know good
profiles for sRGB, AdobeRGB, Wide Gamut and ProPhoto, possibly one CMYK coated
to simulate printer.
The profiles can be absent from the system and digikam should survive.

More random toughts below:
boh ... IANAL, licensing in the color managment world is a so harsh matter I'm
glad others are taking care of.
Namely others are OpenIcc, colord and argyll members/mantainers.
Attached there is a list of all profiles installed on my system (generated with
#1) which include the two bigger provider of free profiles at the moment:
media-gfx/shared-color-profiles =>
https://github.com/hughsie/shared-color-profiles
media-libs/icc-profiles-openicc  =>
http://www.freedesktop.org/wiki/OpenIcc/ProfilePackages
We can be pretty confident those packages will be present on every distro I
hope.

#1  to use on your system replace `qfile` with a command that link file->pkg

PKGNAME='UnPackaged (added manually)'
find /usr/share/color/ ~/.local/share/color/icc/ -type f -iname "*.icc" -or
-iname '*.icm' \
| while IFS= read -r icc
do
  PKGNAME2=$(qfile -C "${icc}")
  PKGNAME2=${PKGNAME2%% *}
  if [[ ${PKGNAME} != ${PKGNAME2} ]]
  then
    PKGNAME="${PKGNAME2}"
    [[ -z $PKGNAME ]] && PKGNAME='UnPackaged (added manually)'
    echo ; echo " ====== ${PKGNAME} ====== " ; echo
  fi
  echo " -- ${icc##*/} -- "
  argyll-iccdump "${icc}" | grep -i -e Creator -e Device\ Class -e Copyright
done > ~/elenco_icc.txt

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Francesco Riosa-2]

https://bugs.kde.org/show_bug.cgi?id=277370

--- Comment #11 from Francesco Riosa <[hidden email]> ---
Also, rawstudio decided to a different route, and blogged about it ;)
http://rawstudio.org/blog/?p=236
it's an interesting read.

ls /usr/share/rawstudio/profiles/*.dcp  | wc -l
303
^- this is the number of camera profiles it has, plus it keep a bunch of basic
icc profiles and notably generic_camera_profile.icc

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=277370

--- Comment #12 from Kai-Uwe Behrmann <[hidden email]> ---
shared-color-profiles is a collection of fakes and uncertain sources. Better
avoid them altogether.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Francesco Riosa-2]

https://bugs.kde.org/show_bug.cgi?id=277370

--- Comment #13 from Francesco Riosa <[hidden email]> ---
(In reply to comment #12)
> shared-color-profiles is a collection of fakes and uncertain sources. Better
> avoid them altogether.

wonderful, it's a pity because there is also a proPhoto profile in there.

by the way how do we check the quality of a profile? How can we
visualize/quantify the differences in curves, clut, gamut, gamma, whatever?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=277370

--- Comment #14 from Kai-Uwe Behrmann <[hidden email]> ---
(In reply to comment #13)
> by the way how do we check the quality of a profile? How can we
> visualize/quantify the differences in curves, clut, gamut, gamma, whatever?

My graphical comparison attempt is elaborated here:
http://www.oyranos.org/2011/11/quality-of-default-icc-profiles/
One can as well compare numerically. Argyll and lcms have some tools to
convert single values or CGATS files, which helps with that.

ICC profile insights can be examined on the command line with Argyll's iccdump
and
SampleICC's iccDumpProfile. Look visually at profiles with ICC Examin:
http://www.oyranos.org/icc-examin/

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=277370

--- Comment #15 from Gilles Caulier <[hidden email]> ---
Francesco,

ICC file included and distributed by libkdcraw are hardcoded in digiKam and co
source code :

[gilles@localhost 2.x]$ pwd
/mnt/data/Devel/GIT/2.x
[gilles@localhost 2.x]$ ls
bootstrap.macports*  bootstrap.msvc.bat  CMakeLists.txt         COPYING.LIB    
 extra/    README
bootstrap.mageia*    bootstrap.ubuntu    COPYING                core/          
 gits*
bootstrap.mandriva*  build/              COPYING-CMAKE-SCRIPTS  doc/          
 NEWS
bootstrap.mingw.bat  cmake/              COPYING.DOC            download-repos*
 project/
[gilles@localhost 2.x]$ grep -r "adobergb" * | grep cpp
core/libs/dimg/filters/icc/iccprofile.cpp:        path =
KStandardDirs::locate("data", "libkdcraw/profiles/adobergb.icm");
extra/kipi-plugins/common/libkipiplugins/tools/imageio/kpwriteimage.cpp:      
    filePath.append("adobergb.icm");

If you change these files, you need to patch source code accordingly.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Francesco Riosa-2]

https://bugs.kde.org/show_bug.cgi?id=277370

--- Comment #16 from Francesco Riosa <[hidden email]> ---
ok, so we are shipping exactly the proPhoto profile which is shipped in
shared-color-profiles, only the comments are changed (i.e. same output of
argyll-iccgamut).
There are also more than few differences to Kodak ProPhoto RGB.

I've found an archive of profiles here:
http://sites.google.com/site/chromasoft/icmprofiles
they are good quality IMHO (better than current ones) and the whole site is
under the "Creative Commons Attribution-Share Alike 3.0 United States License".

the profiles have the the following "Copyright (c) 2008, Sandy McGuffog. Some
rights reserved.", maybe we can ask to  Mr Sandy McGuffog rights to distribute
his profiles.

I've not yet found an sRGB D65 but that should be the easy part right?

toughts?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=277370

--- Comment #17 from Kai-Uwe Behrmann <[hidden email]> ---
(In reply to comment #16)
> I've not yet found an sRGB D65 but that should be the easy part right?
>
> toughts?

sRGB.icc is included inside icc-profiles-openicc. sRGB is per definition D65.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=277370

--- Comment #18 from Kai-Uwe Behrmann <[hidden email]> ---
(In reply to comment #16)
> I've found an archive of profiles here:
> http://sites.google.com/site/chromasoft/icmprofiles
> they are good quality IMHO (better than current ones) and the whole site is
> under the "Creative Commons Attribution-Share Alike 3.0 United States
> License".
>
> the profiles have the the following "Copyright (c) 2008, Sandy McGuffog.
> Some rights reserved.", maybe we can ask to  Mr Sandy McGuffog rights to
> distribute his profiles.

If you ask him, please point to the new ICC license v2:
http://www.color.org/registry/profileregistration.xalter
It was changed to become freely distributable.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=277370

--- Comment #19 from Kai-Uwe Behrmann <[hidden email]> ---
The icc-profiles-openicc-1.3.1.tar.bz2 package contains a ProPhoto-RGB.icc
profile, which was created and checked by OpenICC.

Here are the links:
http://www.oyranos.org/openicc-profiles/

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel