[Bug 274947] New: Auto-rotate/flip image does not work at import

classic Classic list List threaded Threaded
34 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[Bug 274947] Auto-rotate/flip image does not work at import

Gilles Caulier-4
https://bugs.kde.org/show_bug.cgi?id=274947





--- Comment #19 from Gilles Caulier <caulier gilles gmail com>  2011-06-20 10:31:38 ---
The last line with "KEXIV2 KExiv2Iface::KExiv2::getImageOrientation:
Orientation => Exif.Image.Orientation =>"
gentoo: 8
kubuntu: 1

This information is provided by Exiv2 library through libkexiv2, by this method
:

https://projects.kde.org/projects/kde/kdegraphics/libs/libkexiv2/repository/revisions/master/entry/libkexiv2/kexiv2image.cpp#L220

Check libkexiv2 and exiv2 library version used for each digiKam. Go to
"Help/Components Info" for details

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 274947] Auto-rotate/flip image does not work at import

Peter Albrecht-2
In reply to this post by Peter Albrecht-2
https://bugs.kde.org/show_bug.cgi?id=274947





--- Comment #20 from Peter Albrecht <px79 crazymonkeys de>  2011-06-20 18:41:57 ---
(In reply to comment #19)
> Check libkexiv2 and exiv2 library version used for each digiKam. Go to
> "Help/Components Info" for details

Those are attachment 61148 (comment #16) and attachment 61149 (comment #17).
There is no difference: Both are "LibExiv2: 0.21.1"

I have a different theory:
Somehow "Digikam::exifTransform: ExifRotate" fails (maybe, because of LibJPEG:
80)
And since rotation could not finish, "Exif.Image.Orientation" stays "8" at the
gentoo system.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 274947] Auto-rotate/flip image does not work at import

Peter Albrecht-2
In reply to this post by Peter Albrecht-2
https://bugs.kde.org/show_bug.cgi?id=274947





--- Comment #21 from Peter Albrecht <px79 crazymonkeys de>  2011-06-20 23:58:44 ---
Debugging finished!

Result: I guess there is some wrong header-file mixup with libjpeg-80 at
gentoo:

Autorotation terminates premature with error (but does not print an error
message, see bug #276154):


The error is recognized and autorotation is terminated:
>  info->crop_yoffset >= info->output_height
>   (= 3067336080)         (= 2352)

at Thread [3] 24951 (Suspended : Step)    
> Digikam::jtransform_request_workspace() at /var/tmp/portage/media-gfx/digikam-2.0.0_beta6/work/digikam-2.0.0-beta6/core/libs/jpegutils/libjpeg-80/transupp.cpp:974  
> Digikam::exifTransform() at /var/tmp/portage/media-gfx/digikam-2.0.0_beta6/work/digikam-2.0.0-beta6/core/libs/jpegutils/jpegutils.cpp:500  
> Digikam::CameraController::executeCommand() at /var/tmp/portage/media-gfx/digikam-2.0.0_beta6/work/digikam-2.0.0-beta6/core/utilities/cameragui/controller/cameracontroller.cpp:595  
> Digikam::CameraController::run() at /var/tmp/portage/media-gfx/digikam-2.0.0_beta6/work/digikam-2.0.0-beta6/core/utilities/cameragui/controller/cameracontroller.cpp:392  
> 0xb4e05bf3
> start_thread() at 0xb42d4d23
> clone() at 0xb4876c3e


the reason for this:
 "info->crop_yoffset_set" should be "JCROP_UNSET", but is set to:
>   crop_yoffset_set Digikam::<anonymous enum> 134814873

at
> Digikam::jtransform_request_workspace() at /var/tmp/portage/media-gfx/digikam-2.0.0_beta6/work/digikam-2.0.0-beta6/core/libs/jpegutils/libjpeg-80/transupp.cpp:972


the reason for this:
 the second parameter to "jtransform_request_workspace(...)" at line 500 is
already "defect"


the reason for this:
 "jpeg_transform_info transformoption" initializes wrong with:

> transformoption struct {...} {...}
> transform Digikam::<anonymous enum> 3060823808
> perfect boolean -1342727432
> trim boolean -2122803149
> force_grayscale boolean 173864816
> crop boolean 120
> crop_width JDIMENSION 3077679352
> crop_width_set Digikam::<anonymous enum> Digikam::JCROP_UNSET
> crop_height JDIMENSION 0
> crop_height_set Digikam::<anonymous enum> 5
> crop_xoffset JDIMENSION 6501
> crop_xoffset_set Digikam::<anonymous enum> Digikam::JCROP_UNSET
> crop_yoffset JDIMENSION 3067352464
> crop_yoffset_set Digikam::<anonymous enum> 134814873 # << defekt!
> num_components int -1234082352
> workspace_coef_arrays jvirt_barray_ptr * 0x805df14
> output_width JDIMENSION 1
> output_height JDIMENSION 3077676996
> x_crop_offset JDIMENSION 2822188688
> y_crop_offset JDIMENSION 3077679792
> iMCU_sample_width int -1472778648
> iMCU_sample_height int -1217373654

at Thread [3] 25175 (Suspended : Step)    
> Digikam::exifTransform() at /var/tmp/portage/media-gfx/digikam-2.0.0_beta6/work/digikam-2.0.0-beta6/core/libs/jpegutils/jpegutils.cpp:343  
> Digikam::CameraController::executeCommand() at /var/tmp/portage/media-gfx/digikam-2.0.0_beta6/work/digikam-2.0.0-beta6/core/utilities/cameragui/controller/cameracontroller.cpp:595  
> Digikam::CameraController::run() at /var/tmp/portage/media-gfx/digikam-2.0.0_beta6/work/digikam-2.0.0-beta6/core/utilities/cameragui/controller/cameracontroller.cpp:392  
> 0xb4e0fbf3
> start_thread() at 0xb42ded23
> clone() at 0xb4880c3e

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 274947] Auto-rotate/flip image does not work at import

Peter Albrecht-2
In reply to this post by Peter Albrecht-2
https://bugs.kde.org/show_bug.cgi?id=274947





--- Comment #22 from Peter Albrecht <px79 crazymonkeys de>  2011-06-21 20:17:05 ---
I filed a bug at the gentoo bug tracker:
http://bugs.gentoo.org/show_bug.cgi?id=372429

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 274947] Auto-rotate/flip image does not work at import

Marcel Wiesweg
In reply to this post by Peter Albrecht-2
https://bugs.kde.org/show_bug.cgi?id=274947





--- Comment #23 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-06-21 21:56:56 ---
Thanks for your work Peter. As you filed a Gentoo bug, is this a Gentoo-only
problem that needs to be fixed in Gentoo, or can we do anything?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 274947] Auto-rotate/flip image does not work at import

Peter Albrecht-2
In reply to this post by Peter Albrecht-2
https://bugs.kde.org/show_bug.cgi?id=274947





--- Comment #24 from Peter Albrecht <px79 crazymonkeys de>  2011-06-22 21:46:49 ---
I would say the "gentoo-only" nature is based on the fact, that gentoo seems
one of few linux distros using libjpeg-80 in favour to libjpeg-62 at the
moment. (Or gentoo is one of few distros using 80 _and_ has users posting at
bugs.kde.org.)

I believe it's closely related to Bug #228483. So I think, you could help, too.

According to bug 228483 comment 24
(https://bugs.kde.org/show_bug.cgi?id=228483#c24) the following files have been
removed and replaced version-62 / version-80:
 - libs/jpegutils/transupp.cpp  
 - libs/jpegutils/transupp.h  

"transupp.h" contains the troublemaking structure: jpeg_transform_info
And its very different in version 62 and version 80.

The failed structure initialization (see comment 21) takes place at
"core/libs/jpegutils/jpegutils.cpp" (line 343). And jpegutils.cpp is _not_
splitted into version 62 and version 80. Maybe this is the problem.

I'm no expert at gentoo's unpack, prepare, configure, compile, ... process.
I'm also no C(++) pro. So all I can do further is guessing or learning. ;)
But the latter would take some time...

The file header of "core/libs/jpegutils/jpegutils.cpp" says:
> ...
> Copyright (C) 2006-2011 by Gilles Caulier
> ...

Maybe that's hint to get help. ;)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 274947] Auto-rotate/flip image does not work at import

Andreas K. Huettel
In reply to this post by Peter Albrecht-2
https://bugs.kde.org/show_bug.cgi?id=274947


Andreas K. Huettel <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #25 from Andreas K. Huettel <dilfridge gentoo org>  2011-06-22 23:12:37 ---
I'd love to help, but I'll go on a four-week trip in a few days and still have
lots of stuff to do before... :| Bugfixing for Gentoo may slow down a bit
during that time.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 274947] Auto-rotate/flip image does not work at import

Peter Albrecht-2
In reply to this post by Peter Albrecht-2
https://bugs.kde.org/show_bug.cgi?id=274947





--- Comment #26 from Peter Albrecht <px79 crazymonkeys de>  2011-06-22 23:33:48 ---
@Andreas:
I thought of you, secretly. ;)
But I guess it would not be polite to add someone else to the CC-List.

But don't worry. It's not a urgent bug.
> jhead -autorot *.jpg
is a workaround I can live with. But we should not forget this bug.

I wish you a nice trip!

---
Of course everybody else, feeling like to "kick some bugs ass", is welcome to
look at this bug. I believe there are plenty of bugs left for Andreas, when he
comes back. ;)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 274947] Auto-rotate/flip image does not work at import

Marcel Wiesweg
In reply to this post by Peter Albrecht-2
https://bugs.kde.org/show_bug.cgi?id=274947





--- Comment #27 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-07-11 17:03:05 ---
Git commit 129c057de2258196396413895bd329b534598644 by Marcel Wiesweg.
Committed on 01/07/2011 at 14:44.
Pushed by mwiesweg into branch 'master'.

Initialize additional parameters that were added to the structure.

CCBUG: 274947

M  +5    -0    libs/jpegutils/jpegutils.cpp    

http://commits.kde.org/digikam/129c057de2258196396413895bd329b534598644

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 274947] Auto-rotate/flip image does not work at import

Marcel Wiesweg
In reply to this post by Peter Albrecht-2
https://bugs.kde.org/show_bug.cgi?id=274947





--- Comment #28 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-07-11 17:03:40 ---
I assume we need to initialize the two additional parameters as well that were
added to transform_info, in particulat, setting crop to false so that all the
crop parameters are ignored. So far, crop was unitialized.
Please test my commit, as I have libjpeg-62 and cannot test.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 274947] Auto-rotate/flip image does not work at import

Peter Albrecht-2
In reply to this post by Peter Albrecht-2
https://bugs.kde.org/show_bug.cgi?id=274947





--- Comment #29 from Peter Albrecht <px79 crazymonkeys de>  2011-07-13 20:45:27 ---
(In reply to comment #28)
> I assume we need to initialize the two additional parameters as well that were
> added to transform_info, in particulat, setting crop to false so that all the
> crop parameters are ignored. So far, crop was unitialized.
> Please test my commit, as I have libjpeg-62 and cannot test.

Yes, your patch in comment #27 did fix the bug! (*hurray*)

How I compiled:

 - I "started to install" digikam-2.0.0_rc
    # ebuild digikam-2.0.0_rc.ebuild configure
 - applied your patch in comment #27 (although the line numbers differed a
little bit, I could find the correct place to insert those 5 lines)
 - and finally compiled and installed digikam
    # ebuild digikam-2.0.0_rc.ebuil merge

How I tested:
 - I took a new photo in portrait layout
 - imported this photo from sd card with "auto-rotate/flip image" enabled

The test results:
 - the missing four log lines of comment #18 are now printed to stdout
 - the photos in digikam are rotated correctly
 => everything fine! :)

Further steps todo:
 - this bugfix should find it's way to digikam-2.0.0_rc or
digikam-2.0.0[_final]
 - this bug can be closed (FIXED!)

Thanks to everyone!

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 274947] Auto-rotate/flip image does not work at import

Gilles Caulier-4
In reply to this post by Peter Albrecht-2
https://bugs.kde.org/show_bug.cgi?id=274947


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 274947] Auto-rotate/flip image does not work at import

Gilles Caulier-4
In reply to this post by Peter Albrecht-2
https://bugs.kde.org/show_bug.cgi?id=274947


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Camera GUI                  |Import




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 274947] Auto-rotate/flip image does not work at import

Gilles Caulier-4
In reply to this post by Peter Albrecht-2
https://bugs.kde.org/show_bug.cgi?id=274947

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
12