[Bug 274660] New: Face regognition crashes DK

[Philip Johnsson]

https://bugs.kde.org/show_bug.cgi?id=274660





--- Comment #18 from Philip Johnsson <philip johnsson gmail com>  2011-06-08 15:15:26 ---
No I didn't but I use my own opencv packages that have libdc1394
disabled (otherwise the same as ubuntu stock) to make it work with
libgphoto2 and camera import. The packages on my PPA also use opencv
2.2 without libdc1394 support and therefor no crashes since beta4 when
I did that workaround. With the libdc1394 cmake flag now availible I
can try to use that instead with the packages.

/Philip



On Wed, Jun 8, 2011 at 2:55 PM, Gilles Caulier <[hidden email]>
wrote:

> https://bugs.kde.org/show_bug.cgi?id=274660
>
>
>
>
>
> --- Comment #17 from Gilles Caulier <caulier gilles gmail com>  2011-06-08 14:55:21 ---
> See this report for info :
>
> https://bugs.kde.org/show_bug.cgi?id=268267
>
> Gilles Caulier
>
> --
> Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are on the CC list for the bug.
>

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Philip Johnsson]

https://bugs.kde.org/show_bug.cgi?id=274660





--- Comment #19 from Philip Johnsson <philip johnsson gmail com>  2011-06-08 15:32:29 ---
Aha, I misunderstood. Thought I could turn of libdc1394 in opencv
linking in digikam with digikam cmake configuration. You meant that I
could do it with opencv? That is what I have done since beta3-4 as a
workaround for libgphoto2 and import from camera. So this crash with
face recognition shouldn't have anything to do with that. Face
recognition worked as it should until beta6 when it started to crash
like this so the bug must have been introduced in the code somehow in
the code after beta5.

/Philip

On Wed, Jun 8, 2011 at 3:15 PM, Philip Johnsson
<[hidden email]> wrote:
> No I didn't but I use my own opencv packages that have libdc1394
> disabled (otherwise the same as ubuntu stock) to make it work with
> libgphoto2 and camera import. The packages on my PPA also use opencv
> 2.2 without libdc1394 support and therefor no crashes since beta4 when
> I did that workaround. With the libdc1394 cmake flag now availible I
> can try to use that instead with the packages.
>
> /Philip

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=274660


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #20 from Gilles Caulier <caulier gilles gmail com>  2011-06-11 12:41:46 ---
*** Bug 275387 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=274660


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #21 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-06-11 16:43:21 ---
Git commit 40865d086618839bebd4a70730590f8324195536 by Marcel Wiesweg.
Committed on 11/06/2011 at 16:07.
Pushed by mwiesweg into branch 'master'.

d can be null. Add missing checks to avoid crash.

BUG: 274660

M  +2    -2    libkface/image.cpp    

http://commits.kde.org/libkface/40865d086618839bebd4a70730590f8324195536

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=274660


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gareth.glaccum@btopenworld.
                   |                            |com




--- Comment #22 from Gilles Caulier <caulier gilles gmail com>  2011-06-14 16:14:49 ---
*** Bug 275637 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Philip Johnsson]

https://bugs.kde.org/show_bug.cgi?id=274660





--- Comment #23 from Philip Johnsson <philip johnsson gmail com>  2011-06-14 18:28:32 ---
FYI, pulled code from git master today and built Digikam 2.0 and now it doesn't
crash on face recognition anymore like I have reported in this thread.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=274660


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=274660





--- Comment #24 from Frederic Grelot <fredericg_99 yahoo fr>  2011-06-19 12:42:22 ---
Created an attachment (id=61139)
 --> (http://bugs.kde.org/attachment.cgi?id=61139)
New crash information added by DrKonqi

digikam (2.0.0-beta6) on KDE Platform 4.6.3 (4.6.3) using Qt 4.7.2

- What I was doing when the application crashed:
Tried to rescan previously scanned faces to identify them

- Custom settings of the application:

-My database is on a mysql distant server
-The pictures are stored over NFS
-When I launch DK 2.0.0b6, I get a message telling that my database can not be
updated to version 6
-Digikam built by myself

-- Backtrace (Reduced):
#6  KFaceIface::Image::toQImage (this=<optimized out>) at
/raid/home/goulou/digikam/digikam-2.0.0-beta6/extra/libkface/libkface/image.cpp:135
#7  0x000000000050b4bf in Digikam::BatchFaceDetector::slotShowOneDetected
(this=0x3ac3850, package=...) at
/raid/home/goulou/digikam/digikam-2.0.0-beta6/core/utilities/batch/batchfacedetector.cpp:370
#8  0x000000000050c381 in Digikam::BatchFaceDetector::qt_metacall
(this=0x3ac3850, _c=QMetaObject::InvokeMetaMethod, _id=<optimized out>,
_a=0x7fff728378b0) at
/raid/home/goulou/digikam/digikam-2.0.0-beta6/build/core/digikam/batchfacedetector.moc:91
[...]
#10 0x000000000067ed00 in Digikam::FacePipeline::processed (this=<optimized
out>, _t1=<optimized out>) at
/raid/home/goulou/digikam/digikam-2.0.0-beta6/build/core/digikam/facepipeline.moc:155
#11 0x000000000068672c in
Digikam::FacePipeline::FacePipelinePriv::finishProcess (this=0x32b34b0,
package=...) at
/raid/home/goulou/digikam/digikam-2.0.0-beta6/core/utilities/facedetection/facepipeline.cpp:956

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=274660





--- Comment #25 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-06-19 15:49:57 ---
Frederic, this crash should be fixed in libkface with the commit from comment
#21

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=274660





--- Comment #26 from Frederic Grelot <fredericg_99 yahoo fr>  2011-06-19 16:24:17 ---
Thanks Marcel for the hint... I didn't read the full bugreport (I'm not sure if
I had it entirely in KDE's reporting tool... that's why...).
I managed to go around it by adding a check in the caller's function (in
/core/utilities/batch/batchfacedetector.cpp:slotShowOneDetected), not in the
function itself...
I thought it was more appropriate, since KFace provides a "isNull" function :
it should thus be the the caller's responsibility to ask if the image is null
or not, and then call (or not call...) toQImage. By the way, toQImage should
then return NULL, not an empty QImage, but that's just my opinion (and I'm not
a c++, but a java developper, so my methods/conventions may be different than
yours!)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=274660





--- Comment #27 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-06-19 19:16:06 ---
I see the Java developer shining through ;-)
The returned image is not just empty, but null (isNull()) which is a the return
value according to Qt conventions. If you call methods on a "null" object
(where "null" is a Qt convention, not pure C++) you will get invalid data, but
never crashes.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=274660

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel