[Bug 272175] New: picture orientation is "forgotten" in viewer and light table when using xmp sidecar

https://bugs.kde.org/show_bug.cgi?id=272175

           Summary: picture orientation is "forgotten" in viewer and light
                    table when using xmp sidecar
           Product: digikam
           Version: 2.0.0
          Platform: Ubuntu Packages
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Created an attachment (id=59510)
 --> (http://bugs.kde.org/attachment.cgi?id=59510)
screenshot of digikam settings->meta data

Version:           2.0.0 (using KDE 4.6.2)
OS:                Linux

I'm using digikam 2.0 beta4 from philip5 PPA for Kubuntu 10.10.
Digikam is set to use sidecar XMP files (read and "write to XMP sidecar only"),
"Embedded preview loads full-sized images" is option unset.

When I add raw image (NEF) in portrait orientation to an album it's displayed
correctly as long as metadata isn't edited (XMP sidecar doesn't exist). When I
do any action which creates XMP sidecar I get:
- album view and image editor display file in correct orientation (portrait)
- embedded viewer displays portrait orientation in thumb bar, but (incorrect)
landscape orientation in the main window
- light table displays file incorrectly

If I subsequently quit digikam, remove sidecar and start digikam it displays
image correctly everywhere again.

Reproducible: Didn't try

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=272175


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|general                     |Metadata




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2011-05-01 20:09:16 ---
Can you give me the image + the sidecar file to test in local ?

Thanks in advance

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=272175





--- Comment #2 from Ilia K. <mail4ilia gmail com>  2011-05-04 03:39:32 ---
Ok, here is a link to tarball which contains raw (NEF) and XMP sidecar:
https://rapidshare.com/files/460492304/orientation_test.tar.gz

Another news, after removing a database and restoring all the metadata from
images & XMP sidecars, album view displays now incorrect orientation too, so
image editor is the only one displaying image correctly.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=272175


Leif Huhn <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #3 from Leif Huhn <leif dkstat com>  2011-07-09 21:41:04 ---
I'm having the same problem.  This code from
extra/libkexiv2/libkexiv2/kexiv2.cpp
 is related:

        // If XMP sidecar exist and if we want manage it, parse it instead the
image.
        if (d->useXMPSidecar4Reading)
        {
            QString xmpSidecarPath = sidecarFilePathForFile(filePath);
            QFileInfo xmpSidecarFileInfo(xmpSidecarPath);

            if (xmpSidecarFileInfo.exists() && xmpSidecarFileInfo.isReadable())
            {
                // TODO: We should rather read both image and sidecar metadata
                // and merge the two, with sidecar taking precedence
                image = Exiv2::ImageFactory::open((const char*)
                        (QFile::encodeName(xmpSidecarPath)));
            }
        }

We're not storing the orientation in XMP at all, so unless we merge the data,
we will have no orientation data.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=272175





--- Comment #4 from Leif Huhn <leif dkstat com>  2011-07-09 22:36:26 ---
Created an attachment (id=61736)
 --> (http://bugs.kde.org/attachment.cgi?id=61736)
If sidecar exists, still read size, mimetype, comments, exif, and iptc from
original image

This patch causes DigiKam to read most of the metadata from the original file
even if there is a sidecar.  It ignores the XMP data from the image itself when
there is a sidecar.

This fixes the rotation problem.

This patch is meant to be applied on top of kde-bug-275311-rev2.diff from the
other bug.  This patch rearranges lines that were edited from that patch, so if
I generated a diff against 2.0.0-rc, then you could not cleanly apply both.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=272175


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|picture orientation is      |picture orientation is
                   |"forgotten" in viewer and   |"forgotten" in viewer and
                   |light table when using xmp  |light table when using xmp
                   |sidecar                     |sidecar [patch]




--- Comment #5 from Gilles Caulier <caulier gilles gmail com>  2011-07-10 06:51:45 ---
Leif,

Thanks again to review XMP handling code. I will review it Monday morning. I
don't have my computer to test here, i'm not at home/office.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=272175





--- Comment #6 from Gilles Caulier <caulier gilles gmail com>  2011-07-11 09:03:16 ---
Git commit 895fa43e61034daae00e70525d72482beeff1ca2 by Gilles Caulier.
Committed on 11/07/2011 at 10:58.
Pushed by cgilles into branch 'master'.

apply patch #61734 and #61736 from Leif Huhn to manage XMP sidecar and symbolic
links properlly
- If sidecar exists, still read size, mimetype, comments, exif, and iptc from
original image.
- Only follow the symlink when writing to the image file.
CCBUGS: 275311
CCBUGS: 272175

M  +83   -49   libkexiv2/kexiv2.cpp    

http://commits.kde.org/libkexiv2/895fa43e61034daae00e70525d72482beeff1ca2

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=272175


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #7 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-07-11 16:33:52 ---
Is there any support in exiv2 to "merge" metadata from sidecar and from
original image?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=272175





--- Comment #8 from Andreas Huggel <ahuggel gmx net>  2011-07-12 06:10:35 ---
(In reply to comment #7)
> Is there any support in exiv2 to "merge" metadata from sidecar and from
> original image?

Exiv2 has conversions to copy or move metadata of one kind to another:
http://www.exiv2.org/doc/convert_8hpp.html
There is no support to merge two metadata containers of the same kind.

Andreas

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=272175


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=272175

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel