[Bug 272031] New: BQM wastes a lot of memory when adding over 3000 files

https://bugs.kde.org/show_bug.cgi?id=272031

           Summary: BQM wastes a lot of memory when adding over 3000 files
           Product: digikam
           Version: 2.0.0
          Platform: Compiled Sources
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: NOR
         Component: Batch Queue Manager
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           2.0.0 (using KDE 4.6.2)
OS:                Linux

When you add a lot of images to the BQM, it get stuck and wastes a lot of
memory. I guess this is due to the thumbnail generation, which takes an awful
lot of time.
Do we really need to display this little thumbnail in there anyway, it doesn't
give the user any advantage, all operations are executed on the queue itself,
so selecting individual images based on their thumbnails is no use case here.

Maybe we should add an option for turning them off in such dialogs, like in BQM
or in the progress dialogs (ThumbnailBatch, FingerprintsBatch).

Reproducible: Always




OS: Linux (i686) release 2.6.38-ARCH
Compiler: gcc

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=272031





--- Comment #1 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-04-30 18:21:48 ---
I didn't look in the implementation, but from what you tell the current process
is:
3000 files added -> 3000 thumbnails requested -> 3000 pixmaps stored.

What generally scales very well would be:

3000 files added -> added to a model -> n files displayed -> n thumbnails
requested -> n thumbnails cached -> n thumbnails drawn from cache
where n is small (depending on widget's size)

This is how it's basically done in the main icon view.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=272031





--- Comment #2 from Andi Clemens <andi clemens gmx net>  2011-04-30 19:47:23 ---
Yes, this would help I guess. Right now all thumbnails are requested, which is
not scaling very well. I needed to wait 5 minutes for digiKam being responsive
again.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=272031


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #3 from Gilles Caulier <caulier gilles gmail com>  2011-06-22 14:23:54 ---
Git commit b6f76fa0836d2798df7e1e5acdb08f417197a52c by Gilles Caulier.
Committed on 22/06/2011 at 14:21.
Pushed by cgilles into branch 'master'.

BQM : use a mechanism to only load thumb from a queue when item must be show.
Marcel, i don't use Model/View here. I re-implemented QTreeWidget::drawRow()
which query thumbnail loader when it's necessary
BUGS: 272031

M  +23   -5    utilities/queuemanager/views/queuelist.cpp    
M  +6    -2    utilities/queuemanager/views/queuelist.h    

http://commits.kde.org/digikam/b6f76fa0836d2798df7e1e5acdb08f417197a52c

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=272031


Andi Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |VERIFIED




--- Comment #4 from Andi Clemens <andi clemens gmx net>  2011-06-22 23:10:54 ---
Seems to work fine...

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=272031

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=272031

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|BatchQueueManager           |BatchQueueManager-Workflow

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel