[Bug 270168] New: ¨Select Tool¨ item in edit window all 46 icons idle

classic Classic list List threaded Threaded
33 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[Bug 270168] ¨Select Tool¨ item in edit window all 46 icons idle

Marcel Wiesweg
https://bugs.kde.org/show_bug.cgi?id=270168





--- Comment #20 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-04-09 17:31:57 ---
The motivation was to be enable quick action selection from the toolbar
offering a better overview then the menus can do. Of course, this
implementation was a "suggestion" waiting for feedback.

I though along these lines:
- imagine the menu bar is gone
- offer a lot of screen real estate to get a good overview over available tools
- selection by as few clicks as possible
- do not crowd the toolbar

If it is a sub-tab in a specific sidebar, it would be even more hidden than in
the menus.
I could imagine a dedicated sidebar tab which hosts the settings if a tool is
active, and the selection view if no tool is active.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 270168] ¨Select Tool¨ item in edit window all 46 icons idle

Rinus
In reply to this post by Rinus
https://bugs.kde.org/show_bug.cgi?id=270168





--- Comment #21 from Rinus Bakker <sleeplessregulus hetnet nl>  2011-04-10 20:30:19 ---
I ´m not sure if I am supposed to comment but anyway a few thoughts.
you say :¨this implementation was a "suggestion" waiting for feedback. ¨
As far as it concerns me it is a wondeful idea, it just has to function,
thats all it takes. The fact that anything you need is just there where
you expect it, (and if you don´t  know where to find it you can
immediatly see it in the clear overview of the ¨select tool¨) makes dk
very productive and sets dk apart from a few other well known
applications. What you state in the middle section of your remarks is a
bit too cryptic to me, I can not figure out what you ment, but where you
say: ¨imagine the menu bar is gone¨ in favour of working space, that
scares me. My recent experience with Ubuntu 11.04 and unity 2D with no
clou where to look or click is very trendy but not productive. Where the
masses took the wrong direction, we have to think twice.

This being said, the remarks from Gilles are probably more important
than mine, but it is too cryptic to me, I have not the slightest clou
what he is saying, so I can not comment on that.

Rinus
On 09-04-11 17:31, Marcel Wiesweg wrote:

> https://bugs.kde.org/show_bug.cgi?id=270168
>
>
>
>
>
> --- Comment #20 from Marcel Wiesweg<marcel wiesweg gmx de>   2011-04-09 17:31:57 ---
> The motivation was to be enable quick action selection from the toolbar
> offering a better overview then the menus can do. Of course, this
> implementation was a "suggestion" waiting for feedback.
>
> I though along these lines:
> - imagine the menu bar is gone
> - offer a lot of screen real estate to get a good overview over available tools
> - selection by as few clicks as possible
> - do not crowd the toolbar
>
> If it is a sub-tab in a specific sidebar, it would be even more hidden than in
> the menus.
> I could imagine a dedicated sidebar tab which hosts the settings if a tool is
> active, and the selection view if no tool is active.
>

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 270168] ¨Select Tool¨ item in edit window all 46 icons idle

Marcel Wiesweg
In reply to this post by Rinus
https://bugs.kde.org/show_bug.cgi?id=270168





--- Comment #22 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-04-12 22:04:36 ---

> As far as it concerns me it is a wondeful idea, it just has to function,
> thats all it takes. The fact that anything you need is just there where
> you expect it, (and if you don´t  know where to find it you can
> immediatly see it in the clear overview of the ¨select tool¨) makes dk
> very productive and sets dk apart from a few other well known
> applications.

Thanks

> but where you
> say: ¨imagine the menu bar is gone¨ in favour of working space, that
> scares me.

We really dont mean to cut the menu bar.
I just assume there are users who dont the menu bar or the context menu, unless
told and shown how to do it.

>
> This being said, the remarks from Gilles are probably more important
> than mine, but it is too cryptic to me, I have not the slightest clou
> what he is saying, so I can not comment on that.

No worries.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 270168] ¨Select Tool¨ item in edit window all 46 icons idle

Rinus
In reply to this post by Rinus
https://bugs.kde.org/show_bug.cgi?id=270168





--- Comment #23 from Rinus Bakker <sleeplessregulus hetnet nl>  2011-04-15 09:07:08 ---
New discovery concerning this issue might be helpfull to fix

If I highlight an icon in ¨select tool¨ (( which is not easely done
(because ¨arrow key¨ navigation has issues here too) first click ¨select
tool¨ second: click ¨icon of choise¨ ,  now ¨icon of choise¨ is selected
but ¨select tool¨ window disappears, than click ¨select tool¨ again))  
finaly press ¨enter¨ and there you are, so there is obvious a link
between icon and function.

regards,
Rinus


On 12-04-11 22:04, Marcel Wiesweg wrote:

> https://bugs.kde.org/show_bug.cgi?id=270168
>
>
>
>
>
> --- Comment #22 from Marcel Wiesweg<marcel wiesweg gmx de>   2011-04-12 22:04:36 ---
>
>> As far as it concerns me it is a wondeful idea, it just has to function,
>> thats all it takes. The fact that anything you need is just there where
>> you expect it, (and if you don´t  know where to find it you can
>> immediatly see it in the clear overview of the ¨select tool¨) makes dk
>> very productive and sets dk apart from a few other well known
>> applications.
> Thanks
>
>> but where you
>> say: ¨imagine the menu bar is gone¨ in favour of working space, that
>> scares me.
> We really dont mean to cut the menu bar.
> I just assume there are users who dont the menu bar or the context menu, unless
> told and shown how to do it.
>
>> This being said, the remarks from Gilles are probably more important
>> than mine, but it is too cryptic to me, I have not the slightest clou
>> what he is saying, so I can not comment on that.
> No worries.
>

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 270168] ¨Select Tool¨ item in edit window all 46 icons idle

Gilles Caulier-4
In reply to this post by Rinus
https://bugs.kde.org/show_bug.cgi?id=270168





--- Comment #24 from Gilles Caulier <caulier gilles gmail com>  2011-04-15 14:58:56 ---
Git commit 6b0c83af7e100117c9eb75e6b41a5b83da05c229 by Gilles Caulier.
Committed on 15/04/2011 at 15:04.
Pushed by cgilles into branch 'master'.

when an action is selection from menu view, close menu.
CCBUGS: 270168

M  +5    -2    utilities/imageeditor/editor/editorwindow.cpp    
M  +6    -6    utilities/imageeditor/editor/editorwindow_p.h    

http://commits.kde.org/digikam/6b0c83af7e100117c9eb75e6b41a5b83da05c229

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 270168] ¨Select Tool¨ item in edit window all 46 icons idle

Gilles Caulier-4
In reply to this post by Rinus
https://bugs.kde.org/show_bug.cgi?id=270168





--- Comment #25 from Gilles Caulier <caulier gilles gmail com>  2011-04-16 10:36:47 ---
Note :

My last commit do not fix the problem. I close the menu when a tool have been
selected.

I can reproduce the problem under Windows (KDE 4.5.4) and MacOSX (KDE 4.6.2)

Under Linux, KDE 4.4.5 now, problem is not reproducible.

This is probably due to KDELibs, and especially this different KCategoryDrawer
class :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/utilities/imageeditor/editor/editorwindow_p.h#L311

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 270168] ¨Select Tool¨ item in edit window all 46 icons idle

Marcel Wiesweg
In reply to this post by Rinus
https://bugs.kde.org/show_bug.cgi?id=270168





--- Comment #26 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-04-16 16:02:37 ---
Git commit 95a62117a9b5b9579e75d5eb51a91a26a39464c7 by Marcel Wiesweg.
Committed on 16/04/2011 at 16:08.
Pushed by mwiesweg into branch 'master'.

Simply react on clicked(), skip platform-dependent activated(). Does it work on
other OS?

CCBUG: 270168

M  +1    -4    utilities/imageeditor/editor/editorwindow.cpp    

http://commits.kde.org/digikam/95a62117a9b5b9579e75d5eb51a91a26a39464c7

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 270168] ¨Select Tool¨ item in edit window all 46 icons idle

Marcel Wiesweg
In reply to this post by Rinus
https://bugs.kde.org/show_bug.cgi?id=270168





--- Comment #27 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-04-17 11:04:48 ---
Gilles, regarding your commit: Is there an additional problem on some OS that
the menu is not closed but stays open after a click?
After any click, it should activate the clicked tool and close.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 270168] ¨Select Tool¨ item in edit window all 46 icons idle

Gilles Caulier-4
In reply to this post by Rinus
https://bugs.kde.org/show_bug.cgi?id=270168





--- Comment #28 from Gilles Caulier <caulier gilles gmail com>  2011-04-17 12:00:51 ---
Marcel,

Your last commit work perfectly now under Windows (KDE 4.5.4) and MACOSX (KDE
4.6.2)

But her under linux (KDE 4.4.5) menu is not closed after action selection. It
due probably of KCategoryDrawerV2 used instead V3 (look editorwindow_p.h)

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 270168] ¨Select Tool¨ item in edit window all 46 icons idle

Marcel Wiesweg
In reply to this post by Rinus
https://bugs.kde.org/show_bug.cgi?id=270168





--- Comment #29 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-04-17 15:27:10 ---
I have once again added the clicked->close connection to work around this
behavior. Normally, Qt makes sure that any click will close the menu.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 270168] ¨Select Tool¨ item in edit window all 46 icons idle

Gilles Caulier-4
In reply to this post by Rinus
https://bugs.kde.org/show_bug.cgi?id=270168


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #30 from Gilles Caulier <caulier gilles gmail com>  2011-04-18 10:31:38 ---
Yes, now it work too under KDE 4.4.x

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 270168] ¨Select Tool¨ item in edit window all 46 icons idle

Rinus
In reply to this post by Rinus
https://bugs.kde.org/show_bug.cgi?id=270168





--- Comment #31 from Rinus Bakker <sleeplessregulus hetnet nl>  2011-04-18 11:27:46 ---
Thanks for all the hard labor Gilles, Marcel ea. Looking forward to the next
beta.
Rinus

(In reply to comment #30)
> Yes, now it work too under KDE 4.4.x
>
> Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 270168] ¨Select Tool¨ item in edit window all 46 icons idle

Gilles Caulier-4
In reply to this post by Rinus
https://bugs.kde.org/show_bug.cgi?id=270168

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
12