[Bug 269862] New: libkmap compilation fails because of changes in MarbleWidget

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 269862] New: libkmap compilation fails because of changes in MarbleWidget

Bugzilla from trshash84@gmail.com
https://bugs.kde.org/show_bug.cgi?id=269862

           Summary: libkmap compilation fails because of changes in
                    MarbleWidget
           Product: digikam
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: libkmap
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Created an attachment (id=58489)
 --> (http://bugs.kde.org/attachment.cgi?id=58489)
Compilation fix for new marble version

Version:           unspecified (using Devel)
OS:                Linux

Looks like the interface for MarbleWidget has changed again, and you shouldn't
use "marbleWidget->map()->fooBar()" anymore. Apparently, the calls are
forwarded to the backend map() object directly.

The compiler output is attached.

I worked around this problem by changing the relevant calls in
backend_map_marble.cpp (in three places). It compiles properly, but I haven't
run it to ensure that it works. The patch for this is also attached.

In the patch, I've added a new #if condition in backend_map_marble.cpp to
handle MARBLE_VERSION>=0x000c00, which is where this change happened,
apparently.

Reproducible: Always

Steps to Reproduce:
Update to a recent version of kdeedu from SVN
Attempt to build libkmap

Actual Results:  
makeobj[0]: Entering directory
`/mnt/new2/build/extragear/graphics/libkmap/libkmap'
[  0%] Built target kmap_automoc
[  5%] Building CXX object libkmap/CMakeFiles/kmap.dir/backend_map_marble.o
/mnt/new2/code/extragear/graphics/libkmap/libkmap/backend_map_marble.cpp: In
destructor ‘virtual KMap::BackendMarble::~BackendMarble()’:                    
/mnt/new2/code/extragear/graphics/libkmap/libkmap/backend_map_marble.cpp:178:
error: ‘class Marble::MarbleWidget’ has no member named ‘map’
/mnt/new2/code/extragear/graphics/libkmap/libkmap/backend_map_marble.cpp: In
member function ‘virtual QWidget* KMap::BackendMarble::mapWidget()’:
/mnt/new2/code/extragear/graphics/libkmap/libkmap/backend_map_marble.cpp:225:
error: ‘class Marble::MarbleWidget’ has no member named ‘map’
/mnt/new2/code/extragear/graphics/libkmap/libkmap/backend_map_marble.cpp: In
member function ‘virtual QSize KMap::BackendMarble::mapSize() const’:
/mnt/new2/code/extragear/graphics/libkmap/libkmap/backend_map_marble.cpp:909:
error: ‘class Marble::MarbleWidget’ has no member named ‘map’
make[2]: *** [libkmap/CMakeFiles/kmap.dir/backend_map_marble.o] Error 1
make[1]: *** [libkmap/CMakeFiles/kmap.dir/all] Error 2
make: *** [all] Error 2
makeobj[0]: Leaving directory
`/mnt/new2/build/extragear/graphics/libkmap/libkmap'


Expected Results:  
It should compile properly.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 269862] libkmap compilation fails because of changes in MarbleWidget

Gilles Caulier-4
https://bugs.kde.org/show_bug.cgi?id=269862


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
            Version|unspecified                 |2.0.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 269862] libkmap compilation fails because of changes in MarbleWidget [patch]

Gilles Caulier-4
In reply to this post by Bugzilla from trshash84@gmail.com
https://bugs.kde.org/show_bug.cgi?id=269862


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
            Summary|libkmap compilation fails   |libkmap compilation fails
                   |because of changes in       |because of changes in
                   |MarbleWidget                |MarbleWidget [patch]




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2011-04-01 11:36:47 ---
Micheal, this patch is for you...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 269862] libkmap compilation fails because of changes in MarbleWidget [patch]

Christoph Feck
In reply to this post by Bugzilla from trshash84@gmail.com
https://bugs.kde.org/show_bug.cgi?id=269862


Christoph Feck <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #2 from Christoph Feck <christoph maxiom de>  2011-04-02 02:10:59 ---
*** Bug 269900 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 269862] libkmap compilation fails because of changes in MarbleWidget [patch]

Michael G. Hansen
In reply to this post by Bugzilla from trshash84@gmail.com
https://bugs.kde.org/show_bug.cgi?id=269862





--- Comment #3 from Michael G. Hansen <mike mghansen de>  2011-04-02 15:34:35 ---
Thanks for the patch, I will take a look.

Michael

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 269862] libkmap compilation fails because of changes in MarbleWidget [patch]

Michael G. Hansen
In reply to this post by Bugzilla from trshash84@gmail.com
https://bugs.kde.org/show_bug.cgi?id=269862


Michael G. Hansen <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #4 from Michael G. Hansen <mike mghansen de>  2011-04-02 21:29:58 ---
Git commit 26285d37a7818becb2a252461ca0e82851da6db2 by Michael Georg Hansen.
Committed on 02/04/2011 at 21:32.
Pushed by mghansen into branch 'master'.

Apply patch by T.R.Shashwath to make libkmap compile against Marble API
changes. Since the changes were made some time after KDE SC 4.6 was released,
this can break the build for older versions of trunk, but I don't know how to
make the version detection ifdefs more precise.

BUG: 269862

M  +7    -6    libkmap/backend_map_marble.cpp    

http://commits.kde.org/libkmap/26285d37a7818becb2a252461ca0e82851da6db2

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 269862] libkmap compilation fails because of changes in MarbleWidget [patch]

Gilles Caulier-4
In reply to this post by Bugzilla from trshash84@gmail.com
https://bugs.kde.org/show_bug.cgi?id=269862

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 269862] libkmap compilation fails because of changes in MarbleWidget [patch]

Gilles Caulier-4
In reply to this post by Bugzilla from trshash84@gmail.com
https://bugs.kde.org/show_bug.cgi?id=269862

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|libkgeomap                  |Geolocation

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel