[Bug 268925] New: The editor 'forgets' one step when a crop is undone and redone

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 268925] New: The editor 'forgets' one step when a crop is undone and redone

Bugzilla from rydberg@o2.pl
https://bugs.kde.org/show_bug.cgi?id=268925

           Summary: The editor 'forgets' one step when a crop is undone
                    and redone
           Product: digikam
           Version: 2.0.0
          Platform: Ubuntu Packages
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Image Editor
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           2.0.0 (using KDE 4.6.1)
OS:                Linux

Whn to consecutive croppings have been done and undone, it is not possible to
redo the second one. The editor showes the result of the first cropping instead
of the second one.

Reproducible: Always

Steps to Reproduce:
- crop an image with 'proportional cropping' tool (set it to portrait)
- revert the change
- crop one more but this time with landscape setting
- undo the change
- redo the change (as if somebody tried to compare what the image looked like
at the beginning and after the second change)

Actual Results:  
after the secong change has been undone and redone, the editor shows the result
of the first change, i.e. portrait cropping as if the landscape cropping has
never been done

Expected Results:  
The picture should look like it has after the second change (landscape
cropping) has been made

OS: Linux (i686) release 2.6.35-28-generic
Compiler: cc

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 268925] The editor 'forgets' one step when a crop is undone and redone

Marcel Wiesweg
https://bugs.kde.org/show_bug.cgi?id=268925





--- Comment #1 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-03-20 16:11:44 ---
I can confirm. The problem is (much) more general though.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 268925] The editor 'forgets' one step when a crop is undone and redone

Marcel Wiesweg
In reply to this post by Bugzilla from rydberg@o2.pl
https://bugs.kde.org/show_bug.cgi?id=268925


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #2 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-03-20 17:10:54 ---
Git commit eee48d66d8164068df75afa61b1de0f1e7569c08 by Marcel Wiesweg.
Committed on 20/03/2011 at 17:09.
Pushed by mwiesweg into branch 'master'.

Properly remove files from cache with undo/redo

- ensure that cache files are cleared for redo actions when a new action is
appended
- use only Qt code for file operations, removing C headers
- code reuse

BUG: 268925

M  +2    -7    NEWS    
M  +38   -59   utilities/imageeditor/canvas/undocache.cpp    
M  +14   -3    utilities/imageeditor/canvas/undocache.h    
M  +5    -16   utilities/imageeditor/canvas/undomanager.cpp    

http://commits.kde.org/digikam/eee48d66d8164068df75afa61b1de0f1e7569c08

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 268925] The editor 'forgets' one step when a crop is undone and redone

Gilles Caulier-4
In reply to this post by Bugzilla from rydberg@o2.pl
https://bugs.kde.org/show_bug.cgi?id=268925

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel