[Bug 268688] New: Write metadata to all images does not remove obsolete tags

https://bugs.kde.org/show_bug.cgi?id=268688

           Summary: Write metadata to all images does not remove obsolete
                    tags
           Product: digikam
           Version: 1.9.0
          Platform: Ubuntu Packages
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: libkexiv2
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           1.9.0 (using KDE 4.5.5)
OS:                Linux

I've recently changed the way I tag people in photos so that they include the
full name, but when I try to write the data back to the photos, the old tags
are still in the IPTC and XMP metadata and there doesn't seem to be any way of
removing it.

Reproducible: Always

Steps to Reproduce:
Rename/move a tag and then use Tools > write metadata to all images.

Actual Results:  
Old tags are still visible in the images.

Expected Results:  
Any tags not required anymore should be removed.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=268688


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|libkexiv2                   |Metadata
            Version|1.9.0                       |2.0.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=268688





--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2011-03-17 09:01:03 ---
Marcel,

I'm sure that we have already work on this problem in the past. At least me, if
i remember...

There is 2 situations :

1/ To have Tags recorded to item metadata exactly as digiKam database (This is
my case). It's typically the case of user only use digiKam to manage items.

2/ To preserve old tags already assigned to image with another photo-management
program. Typically, tags are created to DB when image are imported. Sometime,
people want that digiKam do not touch to old tags.

For me, the case 2/ is very dangerous. DB and item metadata are not
synchronized properly...

I resume fine the situation ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=268688


Mikkel Christensen <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #2 from Mikkel Christensen <mbc baekhoej dk>  2011-03-17 12:31:02 ---
Gilles, you summarize very well. However, I think it is very dangerous to
assume that digikam is the user's only image tool.
And I think there will always be metadata in images that digikam doesn't
necessarily understand but that metadata needs to be preserved anyway.

If I understand Mark correctly, he is actively changing/renaming/deleting a tag
and then he wants *that specific change* to be reflected in the metadata of the
image. He doesn't want other metadata to be affected.

Best regards,
Mikkel

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=268688





--- Comment #3 from Gilles Caulier <caulier gilles gmail com>  2011-03-17 12:48:07 ---
ok.

I will explain better indeep. Tags are stored in many places :

1/ IPTC keywords (name only, not path)
2/ XMP keywords (name only, not path) = IPTC keywords without ASCII char and
strings size limitations
3/ XMP digiKam namespace : full tag path.

For 1/ and 2/, they contents full history, and not reflect the exact database
contents. Typically old keywords can be still assigned to image.

For 3/, it's THE dedicated place to store digiKam tag paths from database. This
must be the exact copy of DB for backup. It's this point which is not fine
currently. It's the current problem.

NOTE : what's keywords and tag paths :

for a digiKam tag as "City/Paris/Monuments/Seine/Events" with "City",
"Monuments", and "Events" assigned to and item

=> Keywords are : "City", "Monuments", and "Events"
=> Tag Paths are : "City", "City/Paris/Monuments", and
"City/Paris/Monuments/Seine/Events"

If this item is imported to a new computer with digiKam, by priority, tags will
be created in database using :

1/ XMP digiKam namespace
2/ XMP keywords
3/ IPTC keywords

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=268688





--- Comment #4 from Mikkel Christensen <mbc baekhoej dk>  2011-03-17 15:57:54 ---
Gilles, thank you very much for the thorough explanation. I understand it much
better now. It also gives me some ideas for other feature requests, but they
don't belong in this bug.

Best regards, Mikkel

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=268688





--- Comment #5 from Mark Fraser <kde mfraz orangehome co uk>  2011-03-22 21:25:40 ---
Looks like I've managed to remove obsolete tags from Xmp.dc.subject by using
Image > Metadata > Edit XMP by manually editing every single photo in my
collection, but there doesn't seem to be a way of editing Xmp.digiKam.TagsList
without using exiv2 from the command line.

Which as I keep a copy of all images on at least 3 other computers and if
Gilles is right by saying the import order is:
1/ XMP digiKam namespace
2/ XMP keywords
3/ IPTC keywords
Then another copy of DigiKam on another computer will always show the wrong
tags.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=268688





--- Comment #6 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-04-24 19:31:46 ---
I remember a very old bug report about this situation. The problem is that we'd
need to record the change when the tag is renamed, possibly ask for
confirmation that all images should be edited, and then edit all affected
images. This is not implemented.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=268688





--- Comment #7 from Gilles Caulier <caulier gilles gmail com>  2011-04-24 19:37:30 ---
Marcel, Yes, there is an old entry for this subject.

I suspect that it have been implemented and removed because another entry ask
the oposite...

Why not to integrate an option to Metadata settings panel ?

For ex, i don't want to backup old tags in metadata. I want a pure copy of
current tags from DB.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=268688


Ilia K. <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #8 from Ilia K. <mail4ilia gmail com>  2011-05-01 23:45:48 ---
Hi,
I've tried today to rename a tag and stumbled upon this bug (using digikam
2.0-beta4). After playing a little bit I've found a workaround which should
allow me to rename tags for multiple images at once without the tedious manual
editing.

This may be interested to OP (Mark Fraser) and other users affected by the bug,
as well as to developers as an example how renaming may be easily implemented
on top of existing features.

In order to rename tag "foo" into "bar" do:
0. if tag "bar" doesn't exist, create one
   (e.g. choose in the main menu: "Tag->New...")
1. in the main menu choose "Browse->Tags".
   "My Tags" hierarchy is opened on the left
2. choose the existing "foo" tag.
   all files assigned this tag are displayed in the main view
3. select all files in the main view (Ctrl+A)
4. open "Caption/tags" right pane
5. choose (check) "bar" tag in "My Tags" tree in the right pane
6. uncheck "foo" tag in the same tree
7. press "Apply" in the right pane
8. in the main menu choose "Image->Write Metadata to Selected Images".
   I'm not sure whether this step is always required, since in my
   configuration metadata is written to files automatically.

I've tested this workflow using digikam 2.0-beta4 as the only photo management
software, using XMP sidecar.

BTW, this bug is relevant to tag *removal* and *move* as well:
- if you delete a tag which is assigned to some files, the tag is removed from
DB, but not from these files.
- if you move the tag which is assigned to some files across tag hierarchy
(e.g. foo/test_tag -> bar/test_tag), DB is updated but not the file metadata.
Actually, this is equivalent to regular tag renaming.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=268688





--- Comment #9 from Ilia K. <mail4ilia gmail com>  2011-05-01 23:49:27 ---
The workflow I've mentioned in comment #8 is far from being intuitive to the
end user, so I propose to add the following behavior to digikam:

When user performs some change (delete/move/rename/something else?) in tags for
the tag assigned to some files display a dialog like this:
-------------------------------------------------
You have requested to rename/move tag "/People/Alice" into "/People/Bob".
"/People/Alice" is currently assigned to 42 files.
Do you want to update these files metadata or just the Digikam database?

| Update database only |
| Update database and files |
| Cancel |

[ ] Remember my decision
-------------------------------------------------
(in case of tag deletion the wording in the first line is a little bit
different)

A new (drop-down 3-value list) option can be added under
"Settings->Metadata->Behavior->Common Metadata Actions", which will control the
above dialog:

When changing properties of a tag assigned to files:
- update database only
- update database and files
- ask me
With default to "ask me".

When user uncheck the option "Save image tags as "Keywords" tags in metadata
embedded in files" the new option (the proposed one) can be grayed out and the
dialog won't be displayed at all, since the user don't want to touch tags in
file's metadata at all.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=268688


[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #10 from  <terri bugs gmx com>  2011-06-02 12:12:09 ---
I would very much like to see this implemented as proposed by Ilia in Comment
#9. The ability to write changes in tag hierarchy to all the images affected,
would simplify things nicely.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=268688


Leif Huhn <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #11 from Leif Huhn <leif dkstat com>  2011-07-12 14:39:52 ---
Shouldn't DigiKam just remove the tag from the file?  If I didn't want DigiKam
removing tags, I would tell it not to write metadata to the files.

From reading the code, I think this is what DigiKam will do:

1. Add image already tagged Person/Alice
2. Close DigiKam.  Open another program and tag the image with Person/Bob
3. Close other program.  Open DigiKam.  Tag Person/Charles.  Write the
metadata.
DigiKam won't delete Person/Bob.  That's good!
4. Remove Person/Alice.  Write metadata.
DigiKam won't delete Person/Alice.  That's bad.

However, if I ever delete a tag in the DigiKam UI _and_ I have DigiKam set to
write metadata, I expect the tag to be deleted.  If I didn't want to write
metadata I would tell DigiKam not to write metadata at all.

I don't think DigiKam should prompt the user if they should write the metadata
to the file when they remove a tag (there are already many options for what
kind of metadata we should write to the file in the settings menu).

When DigiKam decides whether to write data in MetadataHub, we have in loadTags:

    // Those tags which had been set as MetadataAvailable before,
    // but are not contained in this set, have to be set to MetadataDisjoint

That means the change won't be written to the file.

What I think we need is a marker in the DigiKam DB that the tag was explicitly
removed.  So DigiKam would have a record that the tag does not exist because
the user removed it inside DigiKam.  Then we can avoid removing Person/Bob in
the example but know to remove Person/Alice.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=268688





--- Comment #12 from Gilles Caulier <caulier gilles gmail com>  2011-07-12 15:08:20 ---
Leif,

Well, this bug come back periodically in bugzilla, into 2 different forms:

- Some peoples want to add new tags in image and not to remove older one
(similar to a backup or a versioning of tags)

- Other peoples, like me, want to have a strictly synchronization between tags
from DB and tags registered to image. This must be the default value.

To solve definitively this problem, an option must be added to setup/metadata.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=268688





--- Comment #13 from Gilles Caulier <caulier gilles gmail com>  2011-12-17 09:21:07 ---
Mark,

This file still valid using digiKam 2.4 ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[harry]

https://bugs.kde.org/show_bug.cgi?id=268688


[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1




--- Comment #14 from  <harry dayfamilyweb com>  2011-12-18 03:58:43 ---
*** This bug has been confirmed by popular vote. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=268688

Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #15 from Marcel Wiesweg <[hidden email]> ---
*** Bug 288842 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-3]

https://bugs.kde.org/show_bug.cgi?id=268688

DrSlony <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #16 from DrSlony <[hidden email]> ---
*** Bug 300407 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[harry]

https://bugs.kde.org/show_bug.cgi?id=268688

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #17 from [hidden email] ---
This is a seriouse bug and the main reason that I have to use Windows (and
Windows Live Photo Gallery) every now and again, is there any updates on when
this might be fixed?
At the moment I can only use digikam to view my photos not edit the metadata
due to this issue.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-3]

https://bugs.kde.org/show_bug.cgi?id=268688

--- Comment #18 from DrSlony <[hidden email]> ---
Bump

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel