[Bug 268329] New: Labels (rating, color, pick) in slideshow not alway shown correctly/sometimes forgotten

https://bugs.kde.org/show_bug.cgi?id=268329

           Summary: Labels (rating, color, pick) in slideshow not alway
                    shown correctly/sometimes forgotten
           Product: digikam
           Version: 2.0.0
          Platform: unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: SlideShow
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           2.0.0 (using KDE 4.6.1)
OS:                Linux



Reproducible: Always

Steps to Reproduce:
-start a slideshow
-rate, pick or assign a color to an image using the optional controls in the
lower left corner
-forward or back in the slideshow
-go back to the image you changed


Actual Results:  
The the rating, color and pick is not shown anymore. The rating however is the
only thing that is actually preserved. The color and pick information is reset
as soon as you revisit the image in the slideshow.

Expected Results:  
The controls in the lower left corner show the changes made when viewing the
image the first time and these changes always get saved.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=268329


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|SlideShow                   |Labels




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2011-03-13 11:56:51 ---
Bastian,

Do you run slideshow from image editor ? If yes, i can reproduce it, else from
another part, no (as iconview or light table)

In Image Editor, i also seen than when you change color/pick labels from
Caption and tags sidebar, the information is not registered properly. Look
result in Imageproperties sidebar, on the bottom.

But if you changes color or pick label, AND rating, in this case, all work
fine.

Conclusion : with color and pick labels, a signal is not emitted to DB to
register properties, as it's done with rating.

Marcel, Andi, can you confirm this ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=268329





--- Comment #2 from Bastiaan Hovestreydt <bko hovestreydt com>  2011-03-13 15:43:03 ---
Hi Gilles,

I originally tried it from the thumbnail view but I just tried starting the
slideshow from image editor and it behaves exactly the same. The changed
rating, color and pick label is not displayed in slideshow if I go back to an
image. It always reverts back to the state the labels where whens starting the
slideshow. This all happens in the same slideshow: I start it once, change
labels on an image and the go back and forth.
When I return to the thumbnail view I find all ratings I've set, however the
color and pick labels of images I've seen twice in slideshow are unchanged.
I have no problem with rating and labeling images in the thumbnail viewer, they
are always shown correctly within the slideshow.

Bastiaan

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=268329





--- Comment #3 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-03-13 16:57:21 ---
Git commit 419727fe4cd31afb12a45e960082de49045275d8 by Marcel Wiesweg.
Committed on 13/03/2011 at 16:31.
Pushed by mwiesweg into branch 'master'.

Listen to tag changes and update the properties tab on change

CCBUG: 268329

M  +27   -0    libs/imageproperties/imagepropertiessidebardb.cpp    
M  +2    -0    libs/imageproperties/imagepropertiessidebardb.h    

http://commits.kde.org/digikam/419727fe4cd31afb12a45e960082de49045275d8

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=268329





--- Comment #4 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-03-13 22:36:12 ---
Note that my commit was not fixing the original report but a problem that
Gilles mentioned in his comment...

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=268329





--- Comment #5 from Gilles Caulier <caulier gilles gmail com>  2011-03-13 22:47:44 ---
The original problem is due a to cache mechanism dedicated to slideshow about
metadata. This cache is not updated when user change labels. I will fix it.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=268329


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #6 from Gilles Caulier <caulier gilles gmail com>  2011-03-14 09:47:06 ---
Git commit cdc2759b0ae1490b19d71fff97409010543cab23 by Gilles Caulier.
Committed on 14/03/2011 at 09:45.
Pushed by cgilles into branch 'master'.

update slideshow metadata cache if labels info are changed.
BUGS: 268329

M  +3    -0    utilities/slideshow/slideshow.cpp    

http://commits.kde.org/digikam/cdc2759b0ae1490b19d71fff97409010543cab23

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=268329

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Labels                      |Tags-Colors

--
You are receiving this mail because:
You are the assignee for the bug.