[Bug 267421] New: Tagging panel shows tags as checked which previously where partially checked (when selecting multiple images)

https://bugs.kde.org/show_bug.cgi?id=267421

           Summary: Tagging panel shows tags as checked which previously
                    where partially checked (when selecting multiple
                    images)
           Product: digikam
           Version: 1.8.0
          Platform: Ubuntu Packages
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Usability
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           1.8.0 (using KDE 4.6.0)
OS:                Linux

When selecting multiple images the right tagging panel (Caption/Tags ->
Description) shows items as checked, which in previous versions where partially
checked. There is now no observable difference anymore between tags assigned to
all and tags assigned to some selected images.
I suppose this change is not intentional because I can't see any advantages in
the new behavior.

Reproducible: Always

Steps to Reproduce:
Select multiple images which not all have the same tags.

Actual Results:  
All occurring tags are shown as checked.

Expected Results:  
The tags that are assigned to all images in the selection should be checked.
The tags that are only assigned to some of the selected images should be
partially checked.

Prior to 1.7.0 or 1.8.0 the behavior in digiKam was as expected. I found it
quite useful (in combination with the "Tags already assigned" switch) to get an
overview over the assigned tags or to copy some tags over from one image to all
in the selection.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267421


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|Usability                   |Tags




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=267421





--- Comment #1 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-04-17 15:38:05 ---
This is a regression introduced by 60f14bed01d9f3125c09f24006e5f8804ca21d4f,
bug 141753.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=267421


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #2 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-04-17 16:41:56 ---
Git commit 434fc7e9410bc4866a31d78661699fc8745af45b by Marcel Wiesweg.
Committed on 17/04/2011 at 16:45.
Pushed by mwiesweg into branch 'master'.

Fix a regression introduced by the ability-to-exclude-tags patch, and make some
stuff work (again):
- use a special "add exclude" mode only enabled in models that need it. Fixes
regression 267421
  (partial check state treated as fully checked)
- albumDecorationRole is overridden by derived classes, so there is no sense in
doing the overlay
  painting in this method in the parent class. Provide a tool method which is
called from the children,
  now the + or - is visible.

CCBUG: 141753
BUG: 267421

M  +2    -1    NEWS    
M  +1    -2    digikam/models/digikammodelcollection.cpp    
M  +42   -23   libs/models/abstractalbummodel.cpp    
M  +16   -1    libs/models/abstractalbummodel.h    
M  +6    -2    libs/models/albummodel.cpp    

http://commits.kde.org/digikam/434fc7e9410bc4866a31d78661699fc8745af45b

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267421

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel