[Bug 264830] New: Raw importer broken. Not possible to revert changes.

[Anders Stedtlund]

https://bugs.kde.org/show_bug.cgi?id=264830

           Summary: Raw importer broken. Not possible to revert changes.
           Product: digikam
           Version: 1.8.0
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: libkdcraw
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           1.8.0 (using KDE 4.5.5)
OS:                Linux

When importing raw images and e.g. increase EV and then decide the corrections
was wrong, lowering EV doens't effect the original image. Only possibility is
to revert to original and start over again.

Reproducible: Always

Steps to Reproduce:
(Taken from mail conversation in Digikam-users mailing list)
However, I hit another snag when developing RAW files (Sony ARW in my case):
it usedd to be that if I added an EV correction, and then decided it was too
much, the new (lower) correction was applied to the original RAW output (i.e.
an image update after having lowered an EV correction was less luminous);
with the 1.8.0 version, the second lower correction is applied to the already
corrected image => severe over correction and no way to get back, except
through an update in the RAW tab
(say I start with a correction of +.3, then decide +.2 would have been better:
in <=1.7.0 I ended up with a correction of +.2,
in 1.8.0 I end up with a correction of +.5...)



Expected Results:  
Have the original images as base for all corrections.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Anders Stedtlund]

https://bugs.kde.org/show_bug.cgi?id=264830





--- Comment #1 from  <falolaf gmail com>  2011-01-30 11:38:03 ---
(Taken from mail conversation in Digikam-users mailing list)

Reinstalled kipi-plugins 1.7.0, still problems. Then resinstalled
digiKam 1.7.0, all back to normal again.

Tested with a new config for a different user. Still same problem.

LibKdcraw: 1.1.0
Libraw: 0.11.3

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Anders Stedtlund]

https://bugs.kde.org/show_bug.cgi?id=264830





--- Comment #2 from  <falolaf gmail com>  2011-01-30 11:59:30 ---
Here's an image to test with(Canon CR2):
http://www.adrive.com/public/1528c14240e0794c7a8e2fbc558241e6f517cae694a017247e2717534684a1d0.html

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Anders Stedtlund]

https://bugs.kde.org/show_bug.cgi?id=264830





--- Comment #3 from  <falolaf gmail com>  2011-01-30 12:06:54 ---
Created an attachment (id=56656)
 --> (http://bugs.kde.org/attachment.cgi?id=56656)
Screenshot before EV correction.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Anders Stedtlund]

https://bugs.kde.org/show_bug.cgi?id=264830





--- Comment #4 from  <falolaf gmail com>  2011-01-30 12:07:33 ---
Created an attachment (id=56657)
 --> (http://bugs.kde.org/attachment.cgi?id=56657)
Screenshot with 0.50 EV correction.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Anders Stedtlund]

https://bugs.kde.org/show_bug.cgi?id=264830





--- Comment #5 from  <falolaf gmail com>  2011-01-30 12:08:09 ---
Created an attachment (id=56658)
 --> (http://bugs.kde.org/attachment.cgi?id=56658)
Screenshot after lowering EV correction to 0.30.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[S. Burmeister]

https://bugs.kde.org/show_bug.cgi?id=264830


S. Burmeister <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #6 from S. Burmeister <sven burmeister gmx net>  2011-01-30 12:13:22 ---
I can confirm the bug. If one uses the EV number box to increase the level to
2.x the image gets brighter. If one then decreases it to say 0.9 the image gets
even brighter.

digiKam version 1.8.0
Exiv2 kann in JP2 speichern: Ja
Exiv2 kann in JPEG speichern: Ja
Exiv2 kann in PGF speichern: Ja
Exiv2 kann in PNG speichern: Ja
Exiv2 kann in TIFF speichern: Ja
Exiv2 unterstützt XMP-Metadaten: Ja
LibCImg: 130
LibClapack: internal library
LibExiv2: 0.20
LibJPEG: 62
LibJasper: 1.900.1
LibKDE: 4.6.00 (4.6.0)
LibKExiv2: 1.2.0
LibKdcraw: 1.2.0
LibLCMS: 119
LibLensFun: external shared library
LibLqr: internal library
LibPGF: 6.09.44 - internal library
LibPNG: 1.4.4
LibQt: 4.7.1
LibRaw: 0.11.3
LibTIFF: LIBTIFF, Version 3.9.4 Copyright (c) 1988-1996 Sam Leffler Copyright
(c) 1991-1996 Silicon Graphics, Inc.
Marble-Funktion: 0.11.0 (Stable Release)
Parallelisiertes Entfernen von Mosaikmustern: Ja
Datenbanktreiber: QSQLITE
LibGphoto2: 2.4.10
LibKipi: 1.2.0

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=264830


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[hidden email]
     Ever Confirmed|0                           |1




--- Comment #7 from Gilles Caulier <caulier gilles gmail com>  2011-02-03 09:43:29 ---
Marcel, i confirm this dysfunction.

Very strange...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=264830


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=264830





--- Comment #8 from Gilles Caulier <caulier gilles gmail com>  2011-02-03 09:47:24 ---
I cannot reproduce this problem with White Balance tool which use the same
Exposure Compensation algorithm.

I suspect a problem in GUI of RAW Import post processing settings.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Anders Stedtlund]

https://bugs.kde.org/show_bug.cgi?id=264830





--- Comment #9 from  <falolaf gmail com>  2011-02-03 10:30:08 ---
It's not only the white balance correction that is affected. I had the same
behaviour with brightness.

/Anders

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=264830





--- Comment #10 from Gilles Caulier <caulier gilles gmail com>  2011-02-03 11:03:55 ---
I confirm.

I suspect that post processing is applied to post processed image previously
computed, and not the demosaiced image (both are stored in memory).

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=264830





--- Comment #11 from Gilles Caulier <caulier gilles gmail com>  2011-02-03 11:59:17 ---
Marcel,

I just tested with 2.0.0, and i cannot reproduce the problem.

So, it's only affect 1.x.

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=264830





--- Comment #12 from Gilles Caulier <caulier gilles gmail com>  2011-02-03 12:16:44 ---
Marcel,

If i save demosaiced image like this :

void RawImport::prepareEffect()
{
    DImg postImg = d->previewWidget->demosaicedImage();
    postImg.save("/home/gilles/demo.png", "PNG");
    setFilter(dynamic_cast<DImgThreadedFilter*>(new RawPostProcessing(&postImg,
this, rawDecodingSettings())));
}

before post-processing adjustements, I can confirm that
RawPreview::RawPreviewPriv::demosaicedImg is corrupted after post-processing
adjutments.

The image must still the same.

Look into the code, i cannot see how this DImg is modified by post
processing...

Note : i also check if post-processing settings is fine, and all values used by
post-processing code is fine.

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=264830


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #13 from Gilles Caulier <caulier gilles gmail com>  2011-02-03 12:44:10 ---
SVN commit 1218636 by cgilles:

use a deep copy of demosaiced image to avoid cumulative post-processed changes
BUGS: 264830


 M  +1 -1      rawpostprocessing.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1218636

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=264830

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |1.9.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel