https://bugs.kde.org/show_bug.cgi?id=264181
Summary: png-1.5 compatibility fix Product: digikam Version: 1.8.0 Platform: NetBSD pkgsrc OS/Version: All Status: UNCONFIRMED Severity: normal Priority: NOR Component: general AssignedTo: [hidden email] ReportedBy: [hidden email] Created an attachment (id=56384) --> (http://bugs.kde.org/attachment.cgi?id=56384) Patch fixing the problem. Version: 1.8.0 (using KDE 4.5.4) OS: All In png-1.5, the prototype for png_set_iCCCP changed. The fifth argument was a png_charp and is now a png_bytep. Reproducible: Always Steps to Reproduce: Compile digikam against png-1.5. Actual Results: Here's the output from digikam-1.6.0, but the code is the same in SVN: libs/dimg/loaders/pngloader.cpp: In member function 'virtual bool Digikam::PNGLoader::load(const QString&, Digikam::DImgLoaderObserver*)': libs/dimg/loaders/pngloader.cpp:501: error: invalid conversion from 'char**' to 'png_byte**' libs/dimg/loaders/pngloader.cpp:501: error: initializing argument 5 of 'png_uint_32 png_get_iCCP(const png_struct*, const png_info*, char**, int*, png_byte**, png_uint_32*)' libs/dimg/loaders/pngloader.cpp: In member function 'virtual bool Digikam::PNGLoader::save(const QString&, Digikam::DImgLoaderObserver*)': libs/dimg/loaders/pngloader.cpp:733: error: invalid conversion from 'char*' to 'const png_byte*' libs/dimg/loaders/pngloader.cpp:733: error: initializing argument 5 of 'void png_set_iCCP(png_struct*, png_info*, const char*, int, const png_byte*, png_uint_32)' Expected Results: Successful compilation :) I've attached a patch that fixes the problem with 1.5.0. It probably needs changes to still work against older versions (which I don't have installed). -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
https://bugs.kde.org/show_bug.cgi?id=264181
Andrew Coles <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56384|0 |1 is obsolete| | Status|UNCONFIRMED |ASSIGNED AssignedTo|[hidden email] |[hidden email] | |om Ever Confirmed|0 |1 --- Comment #1 from Andrew Coles <andrew i coles googlemail com> 2011-01-24 18:02:16 --- Created an attachment (id=56390) --> (http://bugs.kde.org/attachment.cgi?id=56390) Patch fixing the problem, but supporting libpng 1.4 or earlier Hi Thomas, Thanks for reporting. Attached is a new patch that should work with 1.4 and 1.5. Could you double-check it works on 1.5? Thanks, Andrew -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Bugzilla from tk@giga.or.at
https://bugs.kde.org/show_bug.cgi?id=264181
[hidden email] changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|[hidden email] |[hidden email] |om | -- You are receiving this mail because: You are the assignee for the bug. |
In reply to this post by Bugzilla from tk@giga.or.at
https://bugs.kde.org/show_bug.cgi?id=264181
[hidden email] changed: What |Removed |Added ---------------------------------------------------------------------------- Component|general |ImageEditor-FileIO -- You are receiving this mail because: You are the assignee for the bug. |
In reply to this post by Bugzilla from tk@giga.or.at
https://bugs.kde.org/show_bug.cgi?id=264181
[hidden email] changed: What |Removed |Added ---------------------------------------------------------------------------- Component|FilesIO-Engine |FilesIO-PNG -- You are receiving this mail because: You are the assignee for the bug. |
Free forum by Nabble | Edit this page |