[Bug 261140] New: FindKdcraw.cmake is installed both by kdelibs and kdegraphics

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=261140

           Summary: FindKdcraw.cmake is installed both by kdelibs and
                    kdegraphics
           Product: digikam
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: NOR
         Component: libkdcraw
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Since a recent commit, the file "FindKdcraw.cmake" is installed both by kdelibs
and kdegraphics, making it impossible to create packages.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=261140


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |[hidden email]
         Resolution|                            |FIXED




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2010-12-26 11:02:36 ---
With rev. #1209275, i removed this file from KDElibs. find libkdcraw script
will be installed with the library as well.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=261140


Christoph Feck <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #2 from Christoph Feck <christoph maxiom de>  2010-12-26 14:28:47 ---
Merci :) Not sure if we can just remove it from kdelibs, but Alexander knows.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Alexander Neundorf]

https://bugs.kde.org/show_bug.cgi?id=261140





--- Comment #3 from Alexander Neundorf <neundorf kde org>  2011-01-11 21:31:35 ---
What has happened here ?
I can see FindKdcraw.cmake in kdelibs but not in kdegraphics.
This is how it should be IMO.

I'm still interested why you reverted the initial change, there is no hint here
in this bug report ?

Alex

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=261140





--- Comment #4 from Gilles Caulier <caulier gilles gmail com>  2011-01-12 08:58:18 ---
Alex,

I receive this private mail from Christophe Giboudeaux <[hidden email]>
:

// ---------------------------------------------------------------------

> On Sunday 26 December 2010 10:59:46 Gilles Caulier wrote:
> SVN commit 1209275 by cgilles:
>
> this file is now installed with libkdcraw as well.
>
>
>  M  +0 -1      CMakeLists.txt
>  D             FindKdcraw.cmake
>
>

Sorry but you deleted the wrong file. Please revert this commit and delete the
one in libkdcraw instead.

It doesn't make much sense for libkdcraw to install a cmake module supposed to
find itself. This was discussed a few times in the kde-buildsystem mailing
list.

The correct fix is:
- Delete FindKdcraw.cmake in kdegraphics,
- replace it with a KdcrawConfig.cmake file.

You can find some examples in several KDE apps (eg, Okular, Kdevplatform,
kdebase-workspace, kdepimlibs...) and you can ask for help on the kde-
buildsystem ML.

Christophe.

// ---------------------------------------------------------------------

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=261140

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel