[Bug 258931] New: linking broken when using -Wl, --no-copy-dt-needed-entries

[Arkadiusz Miśkiewicz]

https://bugs.kde.org/show_bug.cgi?id=258931

           Summary: linking broken when using
                    -Wl,--no-copy-dt-needed-entries
           Product: digikam
           Version: 1.6.0
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           1.6.0 (using KDE 4.5.4)
OS:                Linux

Linking fails because GPHOTO2_LIBRARIES are specified before object that uses
these (libgphoto2_port library to be precise).

libcameragui.a uses gp_port_free() but there is no -lgphoto2_port AFTER
"../lib/libcameragui.a" in linking command while it should be there.

Reproducible: Always

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arkadiusz Miśkiewicz]

https://bugs.kde.org/show_bug.cgi?id=258931





--- Comment #1 from Arkadiusz Miskiewicz <arekm maven pl>  2010-12-05 18:59:44 ---
Created an attachment (id=54174)
 --> (http://bugs.kde.org/attachment.cgi?id=54174)
build log

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Martin Klapetek]

https://bugs.kde.org/show_bug.cgi?id=258931


Martin Klapetek <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #2 from Martin Klapetek <martin klapetek gmail com>  2010-12-05 19:08:31 ---
This will also be most probably an issue with Fedora 13 and higher, as they
changed the implicit DSO linking, which is pretty much what Arkadiusz did
manually, see here:
http://fedoraproject.org/wiki/Features/ChangeInImplicitDSOLinking

I believe that Fedora took a good path and we should be more careful about the
linking in digiKam now.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Martin Klapetek]

https://bugs.kde.org/show_bug.cgi?id=258931


Martin Klapetek <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #3 from Martin Klapetek <martin klapetek gmail com>  2010-12-05 21:20:36 ---
I've commited a fix, but seems like the CCBUG part wasn't recognized or
something, anyway, see rev.1203962

http://websvn.kde.org/?view=rev&revision=1203962

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=258931


ismail ( cartman ) donmez <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
                 CC|                            |[hidden email]
         Resolution|FIXED                       |




--- Comment #4 from ismail ( cartman ) donmez <ismail kde org>  2011-08-26 08:17:19 ---
This patch got removed somehow when digikam got migrated to git. Please
reapply.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=258931


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |[hidden email]
         Resolution|                            |FIXED




--- Comment #5 from Gilles Caulier <caulier gilles gmail com>  2011-08-26 09:48:45 ---
git master is properly patched...

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/digikam/CMakeLists.txt#L282

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=258931





--- Comment #6 from ismail ( cartman ) donmez <ismail kde org>  2011-08-26 09:51:28 ---
No its not properly patched, GPHOTO2_LIBRARIES should be the last argument like
this:

--- core/digikam/CMakeLists.txt 2011-07-28 01:28:25.000000000 +0200
+++ core/digikam/CMakeLists.txt 2011-08-26 10:10:07.010025844 +0200
@@ -278,13 +278,14 @@

         ${STRIGI_LIBRARIES}
         ${LCMS_LIBRARIES}
-        ${GPHOTO2_LIBRARIES}

         digikamcore
         digikamdatabase
         advancedrename
         queuemanager
         cameragui
+
+        ${GPHOTO2_LIBRARIES}
 )

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=258931





--- Comment #7 from Gilles Caulier <caulier gilles gmail com>  2011-08-26 10:00:50 ---
Git commit 772f592f639f52d0c1a991265098b46672fecb6e by Gilles Caulier.
Committed on 26/08/2011 at 11:58.
Pushed by cgilles into branch 'master'.

Fix order to link gphoto2 library with digiKam shared lib. This must be the
last on linker command line...
CCBUGS: 258931
CCBUGS: 268267

M  +3    -1    digikam/CMakeLists.txt

http://commits.kde.org/digikam/772f592f639f52d0c1a991265098b46672fecb6e

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=258931

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |1.7.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=258931

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Portability

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=258931

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Portability                 |Bundle-Tarball

--
You are receiving this mail because:
You are the assignee for the bug.