[Bug 257949] New: Build fails on XP due to line too long

[Andrew Goodbody]

https://bugs.kde.org/show_bug.cgi?id=257949

           Summary: Build fails on XP due to line too long
           Product: digikam
           Version: 1.6.0
          Platform: Compiled Sources
        OS/Version: MS Windows
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Created an attachment (id=53752)
 --> (http://bugs.kde.org/attachment.cgi?id=53752)
Possible fix

Version:           1.6.0 (using Devel)
OS:                MS Windows

I get
Scanning dependencies of target digikam-svnversion
[ 0%] Generating digikam/svnversion.h
[ 0%] Built target digikam-svnversion
Scanning dependencies of target ExternalDraw_automoc
Generating externaldraw.moc
[ 0%] Built target ExternalDraw_automoc
Scanning dependencies of target ExternalDraw
[ 0%] Building CXX object
libs/imageproperties/markerclusterholderplugin/CMakeFiles/ExternalDraw.dir/ExternalDraw_automoc.obj
The input line is too long.

The generated command line is well over 8300 characters and the limit is 8191.


Reproducible: Always

Steps to Reproduce:
Build on WinXP

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=257949


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2010-11-26 10:23:09 ---
There is a thread about this subject here :

http://www.digikam.org/drupal/node/550#comment-19641

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=257949





--- Comment #2 from Gilles Caulier <caulier gilles gmail com>  2010-11-26 10:24:18 ---
Andi,

I think it's a side-effect of your last patch about to create local static lib
to compile digiKam. Right ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=257949


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Portability




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=257949





--- Comment #3 from Andi Clemens <andi clemens gmx net>  2010-11-26 12:30:03 ---
Hm maybe, but not because of the static lib, it could be because we have one
single INCLUDE_DIRS in the root CMakeLists file.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=257949





--- Comment #4 from Gilles Caulier <caulier gilles gmail com>  2010-11-30 09:14:25 ---
Andi,

Do you have take a look on the patch attached ? It's fine for you ? It's not in
the opposite way than your last changes about local static libs used during
compilation ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=257949





--- Comment #5 from Andi Clemens <andi clemens gmx net>  2010-11-30 10:48:57 ---
Yes, it is reverting my changes, but if Windows isn't capable of handling these
compile strings, I guess we need to remove the INCLUDE_DIRS from the main
CMakeLists file again.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=257949





--- Comment #6 from Gilles Caulier <caulier gilles gmail com>  2010-11-30 11:08:22 ---
Andi,

This is Windows XP specific issue. Windows 7 do not have this problem...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=257949





--- Comment #7 from Gilles Caulier <caulier gilles gmail com>  2010-11-30 11:44:24 ---
Andi,

If the patch is fine for you, well, i will apply it on svn

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=257949





--- Comment #8 from Andi Clemens <andi clemens gmx net>  2010-11-30 20:39:03 ---
Well if it compiles, it is ok :-)
CMakeLists will get a little bit more complicated again, but if Windows is too
bad at handling longer command line args... so we can apply the patch of
course.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=257949





--- Comment #9 from Andi Clemens <andi clemens gmx net>  2010-11-30 20:41:20 ---
What I don't like about the patch is that now some include dirs are in the main
CMakelists file, the others are in the CMakelists file of the subproject
folder.
This is even more complicated as it was before.
We should put all the include dirs in the subfolders and remove them from the
main CMakelists file...

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=257949





--- Comment #10 from Gilles Caulier <caulier gilles gmail com>  2010-11-30 20:45:47 ---
Andrew,

Can you adapt your patch following comments #9 from Andi ?

Thanks in advance

Gilles Caulier

Note: I cannot check WINXP compilation. All computer there have been migrated
under Seven, and all compile fine as well.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andrew Goodbody]

https://bugs.kde.org/show_bug.cgi?id=257949





--- Comment #11 from Andrew Goodbody <ajg02 elfringham co uk>  2010-11-30 21:44:33 ---
OK, I will make an attempt but I am no CMake expert.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andrew Goodbody]

https://bugs.kde.org/show_bug.cgi?id=257949


Andrew Goodbody <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53752|0                           |1
        is obsolete|                            |




--- Comment #12 from Andrew Goodbody <ajg02 elfringham co uk>  2010-12-01 09:49:17 ---
Created an attachment (id=53931)
 --> (http://bugs.kde.org/attachment.cgi?id=53931)
2nd attempt at patch

Patch created as per Andi's comments

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andrew Goodbody]

https://bugs.kde.org/show_bug.cgi?id=257949


Andrew Goodbody <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53931|0                           |1
        is obsolete|                            |




--- Comment #13 from Andrew Goodbody <ajg02 elfringham co uk>  2010-12-22 00:32:41 ---
Created an attachment (id=55148)
 --> (http://bugs.kde.org/attachment.cgi?id=55148)
Updated patch

2nd version of patch had bit-rotted so here is an update. Any chance of getting
this committed?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=257949





--- Comment #14 from Gilles Caulier <caulier gilles gmail com>  2011-07-07 13:57:29 ---
Andi,

About Andrew patch, we must to take a choice. It's fine for you or it let's
code less readable as the current one.

Personally i prefer a good readability. Using a common place to declare
includes sound better.

An finally XP will disappear progressively.

Your viewpoint ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=257949


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |WONTFIX




--- Comment #15 from Gilles Caulier <caulier gilles gmail com>  2011-12-13 13:13:14 ---
ok, i choice...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=257949

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Platform|Compiled Sources            |MS Windows

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=257949

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Portability                 |Bundle-Tarball

--
You are receiving this mail because:
You are the assignee for the bug.