[Bug 257933] New: DigiKam zoom slider resets to minimum when returning from image preview

https://bugs.kde.org/show_bug.cgi?id=257933

           Summary: DigiKam zoom slider resets to minimum when returning
                    from image preview
           Product: digikam
           Version: 1.5.0
          Platform: openSUSE RPMs
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           1.5.0 (using KDE 4.5.3)
OS:                Linux

DigiKam's zoom slider resets to minimum when returning from image preview - the
preview size stays the same as earlier.  This makes the zoom slider harder to
use, although it usually "hops" one spot away from the correct zoom level if
clicking zoom in/out.

See attached screenshots.

Reproducible: Didn't try

Steps to Reproduce:
Change zoom level from minimum in browsing view, open image preview, return to
browsing images.

Actual Results:  
Zoom slider returns to minimum.

Expected Results:  
Zoom slider should stay at previously adjusted level.

OS: Linux (i686) release 2.6.34.7-0.5-default
Compiler: gcc

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=257933





--- Comment #1 from Vivek <vivek ap gmail com>  2010-11-26 04:00:04 ---
Created an attachment (id=53745)
 --> (http://bugs.kde.org/attachment.cgi?id=53745)
screenshot: changed zoom level with identical slider #2

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=257933





--- Comment #2 from Vivek <vivek ap gmail com>  2010-11-26 04:00:35 ---
Created an attachment (id=53746)
 --> (http://bugs.kde.org/attachment.cgi?id=53746)
screenshot: changed zoom level with identical slider #1

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=257933





--- Comment #3 from Vivek <vivek ap gmail com>  2010-11-26 04:01:29 ---
Created an attachment (id=53747)
 --> (http://bugs.kde.org/attachment.cgi?id=53747)
screenshot: changed zoom level with identical slider #3

Expected behaviour, as seen before previewing image.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=257933


Vivek <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53745|application/octet-stream    |image/png
          mime type|                            |




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=257933


Vivek <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53746|application/octet-stream    |image/png
          mime type|                            |




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=257933


Vivek <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53747|application/octet-stream    |image/png
          mime type|                            |




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=257933


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #4 from Gilles Caulier <caulier gilles gmail com>  2011-12-13 09:54:28 ---
Vivek,

This entry still valid with 2.x serie ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[nurupobugskde]

https://bugs.kde.org/show_bug.cgi?id=257933

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #5 from [hidden email] ---
It's still somewhat present in 3.x.

If you set the zoom slider to n in Thumbnail [zoom_slider_bug_01.png], then
switch to Preview Image and back to Thumbnail, the zoom slider may show values
of n+2 [zoom_slider_bug_02.png].

This happens because when switching back to Thumbnail, the slider gets reset
with value of size of thumbnails, which will return size+2 if thumbnails have a
highlight border
[`ThumbnailLoadThread::ThumbnailLoadThreadPriv::pixmapSizeForThumbnailSize(...)`].

Note that this bug not only increases zoom slider's value to +2, but also
resizes thumbnails to +2.

The following patch fixes that.
It checks is thumbnail has a border, and if it does, it returns
sizeWithBorders-2, which then used in calling
`DigikamApp::slotThumbSizeChanged(int size)`.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[nurupobugskde]

https://bugs.kde.org/show_bug.cgi?id=257933

--- Comment #6 from [hidden email] ---
Created attachment 79631
  --> https://bugs.kde.org/attachment.cgi?id=79631&action=edit
zoom_slider_bug_01.png

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[nurupobugskde]

https://bugs.kde.org/show_bug.cgi?id=257933

--- Comment #7 from [hidden email] ---
Created attachment 79632
  --> https://bugs.kde.org/attachment.cgi?id=79632&action=edit
zoom_slider_bug_02.png

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[nurupobugskde]

https://bugs.kde.org/show_bug.cgi?id=257933

--- Comment #8 from [hidden email] ---
Created attachment 79636
  --> https://bugs.kde.org/attachment.cgi?id=79636&action=edit
patch_for_bug_257933.diff

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=257933

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|DigiKam zoom slider resets  |DigiKam zoom slider resets
                   |to minimum when returning   |to minimum when returning
                   |from image preview          |from image preview [patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=257933

--- Comment #9 from Marcel Wiesweg <[hidden email]> ---
My suggestions would be: name the reverse of "thumbnailPixmapSize()"
"thumbnailImageSize" or rename both to a pair of words which better transport
the meaning.
Why not patch "ThumbnailSize ImageCategorizedView::thumbnailSize() const" to
return the actual size without border? It is
ImageCategorizedView::setThumbnailSize(const ThumbnailSize& s) which adds the 2
pixels, so the same class should subtract them.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[nurupobugskde]

https://bugs.kde.org/show_bug.cgi?id=257933

--- Comment #10 from nurupo <[hidden email]> ---
(In reply to comment #9)
> My suggestions would be: name the reverse of "thumbnailPixmapSize()"
> "thumbnailImageSize" or rename both to a pair of words which better
> transport the meaning.

I agree that names are confusing. What would you say about renaming
`ThumbnailLoadThread::thumbnailPixmapSize` to
`ThumbnailLoadThread::thumbnailToPixmapSize` and
`ThumbnailLoadThread::pixmapThumbnailSize` to
`ThumbnailLoadThread::pixmapToThumbnailSize`, because it's basically what they
are doing, converting pixmap size into thumbnail size and back.

> Why not patch "ThumbnailSize ImageCategorizedView::thumbnailSize() const" to
> return the actual size without border? It is
> ImageCategorizedView::setThumbnailSize(const ThumbnailSize& s) which adds
> the 2 pixels, so the same class should subtract them.

Yes, patching `ImageCategorizedView::thumbnailSize` looks like a better
solution, because logically it should return the value which was initially set,
not the value+2. But still, we can't just return size-2 from it, -2 should be
done only if thumbnail has highlight boarders.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[nurupobugskde]

https://bugs.kde.org/show_bug.cgi?id=257933

nurupo <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79636|0                           |1
        is obsolete|                            |

--- Comment #11 from nurupo <[hidden email]> ---
Created attachment 79680
  --> https://bugs.kde.org/attachment.cgi?id=79680&action=edit
patch_for_bug_257933_v2.diff

Here is the new patch. Please disregard patch_for_bug_257933.diff.
I didn't rename methods because we still haven't decided on names.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=257933

--- Comment #12 from Marcel Wiesweg <[hidden email]> ---
I agree with your renaming suggestion, it's symmetric and speaking after all.
Patch is welcome, or commit if you've got KDE commit rights.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[nurupobugskde]

https://bugs.kde.org/show_bug.cgi?id=257933

nurupo <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79680|0                           |1
        is obsolete|                            |

--- Comment #13 from nurupo <[hidden email]> ---
Created attachment 79720
  --> https://bugs.kde.org/attachment.cgi?id=79720&action=edit
patch_for_bug_257933_v3.diff

The same as previous + renamed methods.
(I don't have KDE commit rights.)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=257933

--- Comment #14 from Gilles Caulier <[hidden email]> ---
Marcel,

What's new about this entry ? Patch is acceptable for you ?

Nurupo,

Please update your patch against current digiKam code from git/master. It
cannot be applied :

[gilles@localhost core]$ patch -p1 < patch_for_bug_257933_v3.diff
patching file digikam/items/imagecategorizedview.cpp
Hunk #1 succeeded at 431 (offset -1 lines).
Hunk #2 succeeded at 446 (offset -1 lines).
patching file digikam/items/imagethumbnaildelegate.cpp
patching file libs/threadimageio/thumbnailloadthread.cpp
Hunk #1 succeeded at 277 (offset 3 lines).
Hunk #2 FAILED at 289.
1 out of 2 hunks FAILED -- saving rejects to file
libs/threadimageio/thumbnailloadthread.cpp.rej
patching file libs/threadimageio/thumbnailloadthread.h

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=257933

--- Comment #15 from Marcel Wiesweg <[hidden email]> ---
Yes it's fine see comment 12 ;-)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel