[Bug 257806] New: Images imported from backup card

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=257806





--- Comment #15 from Gilles Caulier <caulier gilles gmail com>  2011-08-12 13:36:35 ---
Petri,

Look report https://bugs.kde.org/show_bug.cgi?id=204006

This is not the same problem ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Petri Damstén -2]

https://bugs.kde.org/show_bug.cgi?id=257806





--- Comment #16 from Petri Damstén <petri damsten kdemail net>  2011-08-12 13:47:51 ---
No, my problem is that when using two cards and mirroring feature there are
always duplicate images in camera. I don't have time to get back to this until
late August, but I'm working on this.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Petri Damstén -2]

https://bugs.kde.org/show_bug.cgi?id=257806


Petri Damstén <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62769|0                           |1
        is obsolete|                            |




--- Comment #17 from Petri Damstén <petri damsten kdemail net>  2011-08-23 15:01:46 ---
Created an attachment (id=63075)
 --> (http://bugs.kde.org/attachment.cgi?id=63075)
Import Filters for 2.0

- Configuration moved to setup dialog
- Added mime type filter

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=257806





--- Comment #18 from Gilles Caulier <caulier gilles gmail com>  2011-08-24 12:00:26 ---
Thanks Petri,

Patch downloaded. I will review it soon...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=257806





--- Comment #19 from Gilles Caulier <caulier gilles gmail com>  2011-08-24 13:14:05 ---
Git commit fbf8bcebe28cafe83db51d73d4b6cfd8ae64921c by Gilles Caulier.
Committed on 24/08/2011 at 15:12.
Pushed by cgilles into branch 'master'.

apply path #63075 from Petri Damsten To add new filter option for camera icon
view
CCBUGS: 257806

M  +1    -0    utilities/cameragui/CMakeLists.txt
M  +5    -0    utilities/cameragui/main/cameraui_p.h
A  +79   -0    utilities/setup/importfilters.h     [License: GPL (v2+)]
A  +102  -0    utilities/cameragui/widgets/filtercombo.h     [License: GPL
(v2+)]
M  +23   -13   utilities/cameragui/main/cameraui.cpp
M  +1    -0    utilities/cameragui/main/cameraui.h
M  +1    -0    CMakeLists.txt
M  +5    -0    utilities/setup/setupcamera.h
A  +295  -0    utilities/cameragui/widgets/filtercombo.cpp     [License: GPL
(v2+)]
A  +225  -0    utilities/setup/importfilters.cpp     [License: GPL (v2+)]
M  +141  -0    utilities/setup/setupcamera.cpp

http://commits.kde.org/digikam/fbf8bcebe28cafe83db51d73d4b6cfd8ae64921c

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=257806





--- Comment #20 from Gilles Caulier <caulier gilles gmail com>  2011-08-24 13:23:33 ---
Petri,

I commit your patch reviewed (with some coding style adjustments)

Some remark to improve it and to close definitively this entry :

- In importfilter.cpp, ElidedLabel can be remplaced by KSqueezedTextLabel from
KDE API.

- In importfilter.h, please use a d private internal container to speed-up
compilation and reduce header files to includes.

- There is a suggestion about to add a filter for unwanted files in camera
icon-view. This feature is already implemented and hardcoded in
CameraUI::slotRefreshIconViewTimer(), to handle "mgr_data", "pgr_mgr", "dsp",
and "dps" as always unlisted files from camera. I think this must be
configurable somewhere in setup to be able to add new type to ignore from
camera. What do you think about ?

Best

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=257806


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63075|0                           |1
        is obsolete|                            |




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Petri Damstén -2]

https://bugs.kde.org/show_bug.cgi?id=257806





--- Comment #21 from Petri Damstén <petri damsten kdemail net>  2011-08-24 14:30:25 ---
Can those fixes be committed directly to master?

I could add 'Always Ignore' field to 'Import Filters'-page?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=257806





--- Comment #22 from Gilles Caulier <caulier gilles gmail com>  2011-08-24 15:31:02 ---
Petri,

You have a git account as developer ? If yes, sure, let's go...

And yes, 'Always Ignore' field must be add to 'Import Filters' page.

Thanks for your help

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=257806





--- Comment #23 from Petri Damstén <damu iki fi>  2011-08-24 15:34:04 ---
Git commit e58c3ab15b4b6495f993075e021d6fb557d0637a by Petri Damstén.
Committed on 24/08/2011 at 15:53.
Pushed by pdamsten into branch 'master'.

Use KSqueezedTextLabel widget.

CCBUGS: 257806

M  +2    -3    utilities/setup/importfilters.h
M  +2    -30   utilities/setup/importfilters.cpp

http://commits.kde.org/digikam/e58c3ab15b4b6495f993075e021d6fb557d0637a

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Petri Damstén -2]

https://bugs.kde.org/show_bug.cgi?id=257806





--- Comment #24 from Petri Damstén <petri damsten kdemail net>  2011-08-25 07:31:23 ---
Created an attachment (id=63132)
 --> (http://bugs.kde.org/attachment.cgi?id=63132)
Always ignore

Always ignore box to import filter page. Ok to commit?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=257806





--- Comment #25 from Gilles Caulier <caulier gilles gmail com>  2011-08-25 08:22:01 ---
Petri,

yes sure, and let's go to close this file with BUGS macro (:=)))

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Petri Damstén -2]

https://bugs.kde.org/show_bug.cgi?id=257806


Petri Damstén <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED




--- Comment #26 from Petri Damstén <petri damsten kdemail net>  2011-08-25 08:26:25 ---
Different email in git so BUGS macro did not close it. Closing it here.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=257806

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.1.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel