[Bug 254533] New: make MySQL support as optional dependency

https://bugs.kde.org/show_bug.cgi?id=254533

           Summary: make MySQL support as optional dependency
           Product: digikam
           Version: unspecified
          Platform: Gentoo Packages
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Database
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           unspecified (using KDE 4.5.1)
OS:                Linux

In Gentoo I discovered, that MySQL for digikam-1.4.0 is required (see
https://bugs.gentoo.org/show_bug.cgi?id=337932 about it). Can you make MySQL
dependency optional?


Reproducible: Didn't try

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=254533


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
            Version|unspecified                 |1.5.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Elle Stone]

https://bugs.kde.org/show_bug.cgi?id=254533


Elle Stone <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #1 from Elle Stone <l elle stone gmail com>  2011-02-05 14:21:36 ---
I also would like to see mysql made as optional rather than required. It is a
huge program to have installed with no reason, and I just discovered that it
has been whining and crying in the background every few seconds, probably for
the last week, trying unsuccessfully to start, when I'm not using mysql for
anything at all.

Unless plans are to eliminate using sqlite as an option?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=254533





--- Comment #2 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-02-05 15:49:44 ---
MySQL should be fully optional for digikam. Where does if fail without MySQL?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=254533





--- Comment #3 from Gilles Caulier <caulier gilles gmail com>  2011-02-05 16:53:12 ---
Marcel,

Because of this :

http://lxr.kde.org/source/extragear/graphics/digikam/CMakeLists.txt#192

If mysql executable are not found, digiKam won't to compile under
MacOSX/windows. It's probably the same under Linux...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=254533





--- Comment #4 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-02-05 22:17:55 ---
Well we could use some finer CMake which does not fail directly when the
program are not found. In that case, we'll need to disable the relevant option
in the setup though by #ifdef.

Regarding comment #1: You certainly dont need to have any MySQL server running
if you use normal SQLite.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=254533





--- Comment #5 from  <marflon gmail com>  2011-05-09 18:01:05 ---
Created an attachment (id=59805)
 --> (http://bugs.kde.org/attachment.cgi?id=59805)
Make MySQL dependency optional

This is the patch I use in my custom ebuild for digiKam to avoid rather lengthy
compilation of MySQL server on my old laptop. I hope it will be of use for a
couple of folks out there in the internets.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andreas K. Huettel]

https://bugs.kde.org/show_bug.cgi?id=254533


Andreas K. Huettel <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #6 from Andreas K. Huettel <dilfridge gentoo org>  2011-05-09 22:37:36 ---
Any news here? It would be nice to resolve this fairly trivial issue (also for
1.9)...

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=254533





--- Comment #7 from gray_graff <gray_graff altlinux org>  2011-05-10 04:55:28 ---
http://git.altlinux.org/people/gray_graff/packages/?p=kde4-digikam.git;a=blob;f=build-without-mysql.patch;h=23dd8ee346b93336c81e6448bfdd2ce95e968905;hb=43490c954b91078d1c49fb9eb8653cde2334417a

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=254533


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.5.0                       |2.0.0
            Summary|make MySQL support as       |make MySQL support as
                   |optional dependency         |optional dependency [patch]




--- Comment #8 from Gilles Caulier <caulier gilles gmail com>  2011-05-10 08:26:49 ---
marflon,

Thanks for your patch.
... but it's build against 1.9.0. We working now for 2.0.0 release. 1.x branch
is not maintained.

Can you build it against git master source code please ?

Thanks in advance

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=254533


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #9 from Gilles Caulier <caulier gilles gmail com>  2011-05-10 08:34:17 ---
Francesco,

This is an important patch to test about Mysql dependency. It can be a good
exercise to play with CMake.

Did you manage it ?

Thanks in advance

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=254533


[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59805|0                           |1
        is obsolete|                            |




--- Comment #10 from  <marflon gmail com>  2011-05-10 15:53:31 ---
Created an attachment (id=59863)
 --> (http://bugs.kde.org/attachment.cgi?id=59863)
Make MySQL dependency optional -- patch against latest git

This patch is the same as previous but made against the latest git.
Although I haven't tested it properly -- I hadn't actually built fully working
digiKam binary using it -- I've a strong sense that it does work.

Full testing would require me to build a couple of external shared libraries
(libkface, libkmap) that I failed to find during a 5 minutes time span. Also,
http://www.digikam.org/ contains outdated information like git url (should be
git://, not http://), external dependencies, shared libraries and so on.

And looking for mysql server binary is off by default in this patch -- I think
this is a right thing to do, but you may change it as you like.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Francesco Riosa-2]

https://bugs.kde.org/show_bug.cgi?id=254533





--- Comment #11 from Francesco Riosa <francesco+kde pnpitalia it>  2011-05-10 21:26:30 ---
(In reply to comment #9)
> Francesco,
>
> This is an important patch to test about Mysql dependency. It can be a good
> exercise to play with CMake.

always good to learn, I was near to include the FindMySQL.cmake from kdelibs
but that one check for other things.

>
> Did you manage it ?
> Thanks in advance
> Gilles Caulier

thinking a bit more about it IMHO the problem is in a different place;

Well, I've been a Gentoo developer in the past and created the
/etc/init.d/mysql used there for some year until a better one replaced it
recently.

Let me say it's not easy to manage a database server born to be a full blown
server, not even only start it.
There are a miriad of little stupid things that can go wrong and with a large
userbase GO wrong.

Magically you become the user personal sysadmin, go to debug the user problems
again and again, please give me the logs, please repair that broken table
etc.etc.
Also they require maintenaince, for mysql it's OPTIMIZE/REPAIR table for
postgres is vacuum for oracle will be something else.

To sum it up mysql, and postgres are databases that should be managed as a
system installation, managed explicitly from the user or possibly by the
distros.

SQLite is another story, it's born to be an embeddable database, and does that
work quite well.

Epilog:
I would suggest starting from digikam 2.0 to support mysql only as an external,
already running database.

and PostScriptum
this whole thing apply also to amarok, coming kdepimlibs and every other kde
part.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Francesco Riosa-2]

https://bugs.kde.org/show_bug.cgi?id=254533





--- Comment #12 from Francesco Riosa <francesco+kde pnpitalia it>  2011-05-11 16:27:17 ---
Git commit c29278c20c9cb7fc7bc2c123fd7bfafeb2e303a2 by Francesco Riosa.
Committed on 11/05/2011 at 16:05.
Pushed by riosa into branch 'master'.

optionally depend on mysqld executable

add an option ENABLE_INTERNALMYSQL (default enabled) to bypass the
search of mysqld executable, also define an entry HAVE_INTERNALMYSQL
in config-digikam.h

initial patch provided by <marflon at gmail.com>

CCBUG: 254533

M  +29   -17   CMakeLists.txt    
M  +3    -0    digikam/utils/config-digikam.h.cmake    

http://commits.kde.org/digikam/c29278c20c9cb7fc7bc2c123fd7bfafeb2e303a2

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Francesco Riosa-2]

https://bugs.kde.org/show_bug.cgi?id=254533


Francesco Riosa <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #12 from Francesco Riosa <francesco+kde pnpitalia it>  2011-05-11 16:27:17 ---
Git commit c29278c20c9cb7fc7bc2c123fd7bfafeb2e303a2 by Francesco Riosa.
Committed on 11/05/2011 at 16:05.
Pushed by riosa into branch 'master'.

optionally depend on mysqld executable

add an option ENABLE_INTERNALMYSQL (default enabled) to bypass the
search of mysqld executable, also define an entry HAVE_INTERNALMYSQL
in config-digikam.h

initial patch provided by <marflon at gmail.com>

CCBUG: 254533

M  +29   -17   CMakeLists.txt    
M  +3    -0    digikam/utils/config-digikam.h.cmake    

http://commits.kde.org/digikam/c29278c20c9cb7fc7bc2c123fd7bfafeb2e303a2

--- Comment #13 from Francesco Riosa <francesco+kde pnpitalia it>  2011-05-11 16:27:17 ---
Git commit 8907ceb5ee89b4d822fec8d20433894439be125c by Francesco Riosa.
Committed on 11/05/2011 at 16:17.
Pushed by riosa into branch 'master'.

appliction disable "internal database"

When internal database has been disabled at compile time we don't know
how to start a server and widget should not show the option to use one.

Also for how cmake machinery work mysqldPath option is not empty but
contain "SERVERCMD_MYSQL-NOTFOUND", add a check for that.

When a digikam w/o mysqld support encounter a configuration file which
point to a "internal database" it threat the database as external and
will fail to connect to.

GUI:
BUG: 254533

M  +1    -1    databaseserver/databaseserver.cpp    
M  +10   -1    libs/database/databaseparameters.cpp    
M  +9    -0    libs/widgets/common/databasewidget.cpp    

http://commits.kde.org/digikam/8907ceb5ee89b4d822fec8d20433894439be125c

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Francesco Riosa-2]

https://bugs.kde.org/show_bug.cgi?id=254533





--- Comment #14 from Francesco Riosa <francesco+kde pnpitalia it>  2011-05-11 16:33:50 ---
to be clear this patch DOES NOT disable mysql support which depend from how
qt-sql has been compiled. That's why the option has been renamed to
ENABLE_INTERNALMYSQL

At the moment until digikam developer discuss on #c11 I've left the option
enabled by default

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=254533

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=254533

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Database                    |Database-Mysql

--
You are receiving this mail because:
You are the assignee for the bug.