[Bug 253941] New: Auto lens correction not working correctly

https://bugs.kde.org/show_bug.cgi?id=253941

           Summary: Auto lens correction not working correctly
           Product: digikam
           Version: 1.5.0
          Platform: Unlisted Binaries
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Image Editor
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           1.5.0 (using KDE 4.5.2)
OS:                Linux

After upgrading to digikam 1.5 the Enhance > Lens > Auto-Correction feature is
not working correctly. Instead of fixing the distortion is makes it much
bigger. My camera is a Panasonic LX3 and it's correctly detected. In digikam
1.4 it worked as expected.

I guess that a test file is better than further explanations:
http://www.gadart.com/P1010432.RW2

Thanks.


Reproducible: Always

Steps to Reproduce:
Load the test file, open the image editor, go to Enhance > Lens >
Auto-Correction and see the results.

Actual Results:  
Image turns into a sphere

Expected Results:  
Distortion should be corrected

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=253941


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|Image Editor                |Lens Distortion
            Product|digikam                     |digikamimageplugins




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=253941





--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2010-10-12 11:50:53 ---
Which lensfun version you use ? Go to Help/Component Info dialog for details.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=253941





--- Comment #2 from Gilles Caulier <caulier gilles gmail com>  2010-10-12 11:59:55 ---
You said that your camera is detected ? It's impossible : there is no Exif
information about your camera maker and model. Also Lens string description
from Exif, Makernotes, or XMP do not exist.

Look my screenshot there :

http://www.flickr.com/photos/digikam/5074324981/

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=253941





--- Comment #3 from Alberto Gonzalez <luis6674 yahoo com>  2010-10-12 13:51:01 ---
Hi, thanks for looking into it.

Strange, I have lensfun 2.5 installed in the system, but if I go to Help >
Components Information it doesn't show up there (but it neither does in digikam
1.4 and there all works correctly).

Also strange but here it detects the lens as "standard" (and offers the other
options in the dropdown menu*) and with that it seems enough to correct the
distortion in version 1.4. In 1.5 it still shows the "standard" lens selected
by default, but the correction seems to go in the opposite direction and make
the distortion much bigger.

*note that this is a compact camera, not an interchangeable lens one, so those
options are incorrect.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=253941





--- Comment #4 from Alberto Gonzalez <luis6674 yahoo com>  2010-10-12 14:16:09 ---
By the way, in the "use metadata" I do get a "partial match found", so I might
have some newer library that already contains this info about my camera. Here
are my components:

digiKam version 1.5.0
Exiv2 can write to Jp2: Yes
Exiv2 can write to Jpeg: Yes
Exiv2 can write to Pgf: No
Exiv2 can write to Png: Yes
Exiv2 can write to Tiff: Yes
Exiv2 supports XMP metadata: Yes
LibCImg: 130
LibExiv2: 0.19
LibJPEG: 80
LibJasper: 1.900.1
LibKDE: 4.5.2 (KDE 4.5.2)
LibKExiv2: 1.1.0
LibKdcraw: 1.1.0
LibLCMS: 119
LibPGF: 6.09.44
LibPNG: 1.4.4
LibQt: 4.7.0
LibRaw: 0.10.0
LibTIFF: LIBTIFF, Version 3.9.4 Copyright (c) 1988-1996 Sam Leffler Copyright
(c) 1991-1996 Silicon Graphics, Inc.
Marble widget: 0.10.1
Parallelized demosaicing: Yes
Database backend: QSQLITE
LibGphoto2: 2.4.9
LibKipi: 1.1.0


Just a guess, but maybe digikam 1.4 didn't use lensfun for the lens
auto-correction and now digikam 1.5 does use it? And because in my system it
cannot detect lensfun being installed it fails to correct the distortion? What
I have no idea is how to "force" it to detect lensfun. (I'm using Arch Linux
binaries).

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=253941





--- Comment #5 from Gilles Caulier <caulier gilles gmail com>  2010-10-12 14:19:52 ---
no digiKam use lensfun in all case !

currently lensfun 0.2.5 is published. there is no lensfun version method
available in this library to display version information in digiKam

Since digiKam  1.5.0, we include lensfun source code in core. Lensfun source
code come from lensfun svn repository : 0.2.5.-1. This code include version
method.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=253941


Buchan Milne <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #6 from Buchan Milne <bgmilne mandriva org>  2010-11-24 16:49:20 ---
I have the same problem, with images from Canon EOS 500D with EF-S 17-85mm
F4-5.6 IS USM.

Images corrected with 1.4.0 (plus patch for
https://bugs.kde.org/show_bug.cgi?id=251920) compiled against lensfun 0.2.5
look correct, images corrected with 1.5.0 or 1.6.0 (compiled with same lensfun
installed) look worse than the uncorrected image.

I can provide some samples if necessary.

I have downgraded to 1.4.0 for now, but correct batch correction would be nice.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=253941





--- Comment #7 from Gilles Caulier <caulier gilles gmail com>  2010-11-24 16:56:22 ---
yes, i'm always interrestd by image samples...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[S. Burmeister]

https://bugs.kde.org/show_bug.cgi?id=253941


S. Burmeister <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #8 from S. Burmeister <sven burmeister gmx net>  2010-11-24 17:01:28 ---
Same here with a LX3, with the latest svn from the gsoc branch. LX3 is detected
correctly.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[S. Burmeister]

https://bugs.kde.org/show_bug.cgi?id=253941





--- Comment #9 from S. Burmeister <sven burmeister gmx net>  2011-03-05 08:55:31 ---
There are LX3 sample images in digikam's RAW images repo.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=253941





--- Comment #10 from Romano Giannetti <romano giannetti gmail com>  2011-04-14 15:23:56 ---
Created an attachment (id=58964)
 --> (http://bugs.kde.org/attachment.cgi?id=58964)
strange lens menu

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=253941


Romano Giannetti <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #11 from Romano Giannetti <romano giannetti gmail com>  2011-04-14 15:24:54 ---
There is something fishy going on here. I have in 1.8.0 and in components it
says that it's an external shared library (see at the end).

Now, the problem is that it seems that the selection of lens does not work. I
have a Panasonic LX-5, so I know there is no lens data for it, but before
trying to generate one I tried to use the LX3 setup. Well, there are two
problems:

1) in the /usr/share/kde4/apps/digikam/lensfun/compact-panasonic.xml there are
4 variants for LX3 for the various aspect ratio, but in the menu you have just
4 LX3 entry without any hints on which is which.

2) After that, reading the abovementioned file, I suspect that I should be able
to select a lens with the PanasonicLX3 mount, which is just one, the default.
Instead I see three completely unrelated lens --- see the screenshot.




digiKam version 1.8.0
Exiv2 can write to Jp2: Yes
Exiv2 can write to Jpeg: Yes
Exiv2 can write to Pgf: No
Exiv2 can write to Png: Yes
Exiv2 can write to Tiff: Yes
Exiv2 supports XMP metadata: Yes
LibCImg: 130
LibClapack: internal library
LibExiv2: 0.19
LibJPEG: 62
LibJasper: 1.900.1
LibKDE: 4.6.2 (4.6.2)
LibKExiv2: 1.2.0
LibKdcraw: 1.2.0
LibLCMS: 118
LibLensFun: external shared library
LibLqr: internal library
LibPGF: 6.09.44 - internal library
LibPNG: 1.2.44
LibQt: 4.7.0
LibRaw: 0.11.3
LibTIFF: LIBTIFF, Version 3.9.4 Copyright (c) 1988-1996 Sam Leffler Copyright
(c) 1991-1996 Silicon Graphics, Inc.
Marble widget: 0.11.0 (Stable Release)
Parallelised demosaicing: Yes
Database backend: QSQLITE
LibGphoto2: 2.4.8
LibKipi: 1.2.0

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=253941





--- Comment #12 from Romano Giannetti <romano giannetti gmail com>  2011-04-27 11:32:15 ---
I tested with UFraw, and it let me select the LX3 lens correctly. UFraw uses
the 0.2.5 standard version of liblensfun.

So I still think there is a problem in digiKam; something is going bad with the
lens selection tool.

Moreover, shouldn't lens correction be applied/appliable in the RAW import
dialog? Although probably it's not so important, if the conversion is a 16-bit
one.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=253941


[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #13 from  <souloftherobot gmail com>  2011-10-03 19:01:41 ---
Hi,

I have a Fuji s9600 and have the same problem described above, in that the Auto
Lens Correction warps photos. The warp is basically spherical and can be really
extreme, especially at wide angle.

As was also mentioned, I would need to fall back to a distro that uses Digikam
1.4 - all versions since have this problem.

I use the s9500 entry (as the 9500/9600 share the same lens) in ShowFoto's Auto
Lens Correction.

This problem is a shame as the Lens Correction tool (Digikam 1.4 or lower)
really improves photos taken with the s9600 - but I have to run a 2nd distro in
order to use the Lens Correction.

Don't know if it is important, but un-ticking the distortion option removes the
warping - but unfortunately, the distortion option is what makes the
improvement to the photos (or did, in Digikam 1.4 or lower of course).

Any ideas?

Sorry if this is not very clear - it's my first ever bug report.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=253941





--- Comment #14 from Gilles Caulier <caulier gilles gmail com>  2011-12-17 19:07:17 ---
Alberto,

This file still valid using digiKam 2.4 ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=253941





--- Comment #15 from Alberto Gonzalez <luis6674 yahoo com>  2011-12-18 00:15:06 ---
I still haven't upgraded to 2.4, but with 2.3 the issue is still there. I will
try to upgrade soon and report back.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=253941





--- Comment #16 from Alberto Gonzalez <luis6674 yahoo com>  2012-01-06 00:34:12 ---
Tested with digikam 2.5 now and the problem is still present.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=253941


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.5.0                       |2.5.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[urcindalo]

https://bugs.kde.org/show_bug.cgi?id=253941

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #17 from [hidden email] ---
I just installed digikam 2.6.0 and 2.7.0 on my Gentoo 64bit box. In both cases
the lensfun version installed is 2.6.0.

My camera is an Olympus E-PM1 with an M.Zuiko 14-42mm lens. The corresponding
exif data from my pictures, as reported by exiftool, are:

=====================================================
Image Description               : OLYMPUS DIGITAL CAMERA
Make                            : OLYMPUS IMAGING CORP.
Camera Model Name               : E-PM1
...
---- Olympus ----
Special Mode                    : Normal, Sequence: 0, Panorama: (none)
Camera ID                       : OLYMPUS DIGITAL CAMERA
Equipment Version               : 0100
Camera Type 2                   : E-PM1
Serial Number                   : BB9501686
Internal Serial Number          : 4134108006711001
Focal Plane Diagonal            : 21.6 mm
Body Firmware Version           : 1.301
Lens Type                       : Olympus M.Zuiko Digital ED 14-42mm F3.5-5.6
II R
Lens Serial Number              : ABG235236
Lens Model                      : OLYMPUS M.14-42mm F3.5-5.6 II R
Lens Firmware Version           : 1.102
=====================================================

Digikam is not able to detect my lens. My camera model can be found among the
options for "OLYMPUS CORPORATION", but the lens options appearing are only the
"Standard" plus the ones from the already-attached "strange lens menu" picture.

The gimplensfun 0.2.2 (a plug-in for GIMP) allows me to correctly select my
lens model. Why can't I do that in digikam?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel