[Bug 252671] New: [PATCH] Navigation and actions dock bar

https://bugs.kde.org/show_bug.cgi?id=252671

           Summary: [PATCH] Navigation and actions dock bar
           Product: digikam
           Version: 2.0.0
          Platform: Debian testing
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: Usability
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           2.0.0 (using KDE 4.5.1)
OS:                Linux

This patch adds a dock bar with navigation and actions buttons in the bottom of
the screen.

I made this patch to replace the status bar because I find the navigation
buttons are not enough visibles. But for the moment my patch doesn't hide it.

(screenshots availables on http://svn.reviewboard.kde.org/r/4905/)

Reproducible: Didn't try

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=252671





--- Comment #1 from Luc Vieillescazes <luc vieillescazes net>  2010-09-28 19:20:13 ---
Created an attachment (id=52053)
 --> (http://bugs.kde.org/attachment.cgi?id=52053)
Patch

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=252671


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #2 from Gilles Caulier <caulier gilles gmail com>  2010-09-29 09:20:12 ---
Luc,

You have set digiKam target as 2.0.0. Do you build this patch against svn trunk
or the GSoC 2010 branche ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=252671





--- Comment #3 from Gilles Caulier <caulier gilles gmail com>  2010-09-29 09:22:32 ---
I take a look in your current patch. Your coding style is fine for me. It's
very appreciate... (:=)))

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=252671


Luc Vieillescazes <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52053|0                           |1
        is obsolete|                            |




--- Comment #4 from Luc Vieillescazes <luc vieillescazes net>  2010-10-02 17:44:11 ---
Created an attachment (id=52169)
 --> (http://bugs.kde.org/attachment.cgi?id=52169)
New revision

Hi Gilles,

No I made a mistake, the patch must be apply on trunk, not on the GSOC
branch...

Here is a new revision, changes are :
- Put the thumbnails bar back in albumwidgetstack
- Remove filter / zoom / navigations buttons from the status bar

Luc

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=252671





--- Comment #5 from Gilles Caulier <caulier gilles gmail com>  2010-10-02 18:38:55 ---
Great. I take a look

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=252671





--- Comment #6 from Gilles Caulier <caulier gilles gmail com>  2010-10-02 20:04:01 ---
Marcel,

[gilles@localhost digikam]$ patch -p0 < digikam_navigationbar5.diff
patching file CMakeLists.txt
patching file digikam/digikamview.cpp
patching file digikam/digikamapp.h
patching file digikam/mediaplayerview.cpp
patching file digikam/albumwidgetstack.h
patching file digikam/navigationbar.cpp
patching file digikam/digikamapp_p.h
patching file digikam/digikamview.h
patching file digikam/imagepreviewview.h
patching file digikam/imagepreviewview.cpp
patching file digikam/navigationbar.h
patching file digikam/digikamapp.cpp
patching file digikam/albumwidgetstack.cpp

The patch touch some which which have changed indeep in GSoC2010 branch. patch
need to be adjusted...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=252671





--- Comment #7 from Gilles Caulier <caulier gilles gmail com>  2010-10-02 20:17:12 ---
Luc,

My remarks :

1/ Undock navigation bar : floating bar created is completly broken. Can you
reproduce it ?
2/ There is no "View" menu entry to show/hide navigation bar.
3/ when you switch from iconview to preview mode, the filter widget (text,
rating, mime type) is replaced by navigation buttons. This remove the way to
filter thumbbar content in preview mode. This is weird. Filters widget need to
still visible. move naviguation button just behing, on the left side of "back
to album" button

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=252671





--- Comment #8 from Gilles Caulier <caulier gilles gmail com>  2010-10-02 20:19:23 ---
Luc,

Another point : "View", "Edit", and "Slideshow" button from naviguate bar are
dupplicates of application button bar. Why ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=252671





--- Comment #9 from Gilles Caulier <caulier gilles gmail com>  2010-10-02 20:22:27 ---
Created an attachment (id=52173)
 --> (http://bugs.kde.org/attachment.cgi?id=52173)
nav bar undocked and broken

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=252671





--- Comment #10 from Gilles Caulier <caulier gilles gmail com>  2010-10-02 20:23:10 ---
Created an attachment (id=52174)
 --> (http://bugs.kde.org/attachment.cgi?id=52174)
nav bar in iconview

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=252671





--- Comment #11 from Gilles Caulier <caulier gilles gmail com>  2010-10-02 20:23:46 ---
Created an attachment (id=52175)
 --> (http://bugs.kde.org/attachment.cgi?id=52175)
nav bar in preview mode

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=252671





--- Comment #12 from Gilles Caulier <caulier gilles gmail com>  2010-10-03 10:29:44 ---
Luc,

Your patch introduce a lots of change in Album GUI. Also, it will require more
work to backport and maintain both code (trunk+GOsC2010 branch) at the same
time.

So, i would to see this patch only applied on GOsC2010 branch, available there
:

http://websvn.kde.org/branches/extragear/graphics/

I would to see 1.x code (trunk) with the same Album GUI interface now...

Thanks in advance

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=252671





--- Comment #13 from Gilles Caulier <caulier gilles gmail com>  2010-10-03 10:57:38 ---
Luc,

Another viewpoint about your navigation bar : look Dolphin, which has a filter
bar on the bottom of icon view. This bar can be enabled/disabled from View
menu.

The bar is small and do not reduce a lots the space for icon view.

Your bar include filter + navigation tools. I recommend to separate both
feature and create :

- One navigation bar.
- One filter bar.

The advantage is to select the bar depending of the context and use case,
without to reduce icon view text. Of course both can be enabled at the same
time.

There is also another point to include there. In Filter bar, later, we will
host a combo box with tag filters. This mean that tag filters currently hosted
in right sidebar will be removed. Look there :

https://bugs.kde.org/show_bug.cgi?id=210576

Also, new filters will be implemented later, as camera type, aspect ratio,
sizes, etc. Look these entries for details :

https://bugs.kde.org/show_bug.cgi?id=124890
https://bugs.kde.org/show_bug.cgi?id=121313
https://bugs.kde.org/show_bug.cgi?id=224549


The is another point to separate navigation and filter tools : a lots of users
want to customize filter by album. Typically, we will store in database the
filters properties for each album....

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=252671


Luc Vieillescazes <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52169|0                           |1
        is obsolete|                            |




--- Comment #14 from Luc Vieillescazes <luc vieillescazes net>  2010-10-03 11:10:32 ---
Created an attachment (id=52196)
 --> (http://bugs.kde.org/attachment.cgi?id=52196)
Patch

Hi,

1/ Undock navigation bar : floating bar created is completly broken. Can you
reproduce it ?
--> Done

2/ There is no "View" menu entry to show/hide navigation bar.
--> Done

3/ when you switch from iconview to preview mode, the filter widget (text,
rating, mime type) is replaced by navigation buttons. This remove the way to
filter thumbbar content in preview mode. This is weird. Filters widget need to
still visible. move naviguation button just behing, on the left side of "back
to album" button
--> Done. The navigation buttons are centered and always visibles (even in
iconview).

For your question :
"View", "Edit", and "Slideshow" button from naviguate bar are
dupplicates of application button bar. Why ?
I put them in the dock bar because I think that with rotate and delete buttons,
they are the most importants actions. Normal user should find quickly what they
want to do.
But I let them in the Toolbar for "old users" ;-)
Have you an idea about that ?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=252671





--- Comment #15 from Luc Vieillescazes <luc vieillescazes net>  2010-10-03 11:17:45 ---
(In reply to comment #13)

> Luc,
>
> Another viewpoint about your navigation bar : look Dolphin, which has a filter
> bar on the bottom of icon view. This bar can be enabled/disabled from View
> menu.
>
> The bar is small and do not reduce a lots the space for icon view.
>
> Your bar include filter + navigation tools. I recommend to separate both
> feature and create :
>
> - One navigation bar.
> - One filter bar.
>
> The advantage is to select the bar depending of the context and use case,
> without to reduce icon view text. Of course both can be enabled at the same
> time.
>
> There is also another point to include there. In Filter bar, later, we will
> host a combo box with tag filters. This mean that tag filters currently hosted
> in right sidebar will be removed. Look there :
>
> https://bugs.kde.org/show_bug.cgi?id=210576
>
> Also, new filters will be implemented later, as camera type, aspect ratio,
> sizes, etc. Look these entries for details :
>
> https://bugs.kde.org/show_bug.cgi?id=124890
> https://bugs.kde.org/show_bug.cgi?id=121313
> https://bugs.kde.org/show_bug.cgi?id=224549
>
>
> The is another point to separate navigation and filter tools : a lots of users
> want to customize filter by album. Typically, we will store in database the
> filters properties for each album....
>
> Gilles Caulier

I see...
But both bar need to be in the same widget, because we cannot have several
QDockWidget, one above the other. (Or I don't know how to do that).

Maybe one QDockWidget, but with buttons to enable filters bar / navigation bar
etc... like in kate with the green arrow on the right to switch to "power
search".
The thumbnails bar could merge in the same way

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=252671





--- Comment #16 from Gilles Caulier <caulier gilles gmail com>  2010-10-03 12:54:45 ---
Created an attachment (id=52197)
 --> (http://bugs.kde.org/attachment.cgi?id=52197)
dolphin filter bar

This is the dolphin filter bar set on through Tools menu entry (i think this
menu entry is wrong, and View is more appropriate)

Look like this tool bar is not dockable. It always appear at the same place. I
think it's enough.

This is the right way for digiKam i think. This solve the way to create more
than one bar at the same time : navigate bar and filter bar.

This is my proposal : create a navigate bar on the bottom of icon-view and
create the filter on the top of icon-view to be near of album title bar.

Note : i don't yet tested your new patch.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=252671





--- Comment #17 from Gilles Caulier <caulier gilles gmail com>  2010-10-03 12:57:41 ---
Another point : as cameragui, image editor and litgh-table have the zoom slider
on the right corner of statusbar, i think it must be the same for album gui to
have an homogenous interface everywhere. This must mean to extract zoom bar
from your navigate bar and to restore it to status bar.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=252671





--- Comment #18 from Gilles Caulier <caulier gilles gmail com>  2011-02-18 13:51:34 ---
Luc,

What's about this file.

Please review it against 2.x code from git repository, where is move all icon
view filters to right sidebar.

http://www.flickr.com/photos/digikam/5453984332/sizes/o/in/photostream/

Thanks in advance

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=252671


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[PATCH] Navigation and      |Navigation and actions dock
                   |actions dock bar            |bar [patch]




--- Comment #19 from Gilles Caulier <caulier gilles gmail com>  2011-12-16 11:51:42 ---
Luc,

No new patch version available ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel