[Bug 251563] New: [patch] Getting rid of the lapack dependancy using Eigen

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=251563

--- Comment #17 from Marcel Wiesweg <[hidden email]> ---
Thanks for your work.
Did you send a compressed file? It is unreadable from the browser. You could
also open a review request on KDE's review board.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gowtham Ashok]

Yes.Its compressed as text is >65535 characters.Ok, will open review request.

On Sun, Mar 24, 2013 at 11:54 PM, Marcel Wiesweg <[hidden email]> wrote:

https://bugs.kde.org/show_bug.cgi?id=251563

--- Comment #17 from Marcel Wiesweg <[hidden email]> ---
Thanks for your work.
Did you send a compressed file? It is unreadable from the browser. You could
also open a review request on KDE's review board.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gowtham Ashok]

https://bugs.kde.org/show_bug.cgi?id=251563

--- Comment #18 from Gowtham Ashok <[hidden email]> ---
Yes.Its compressed as text is >65535 characters.Ok, will open review
request.

On Sun, Mar 24, 2013 at 11:54 PM, Marcel Wiesweg <[hidden email]>wrote:

> https://bugs.kde.org/show_bug.cgi?id=251563
>
> --- Comment #17 from Marcel Wiesweg <[hidden email]> ---
> Thanks for your work.
> Did you send a compressed file? It is unreadable from the browser. You
> could
> also open a review request on KDE's review board.
>
> --
> You are receiving this mail because:
> You are the assignee for the bug.
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=251563

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78351|0                           |1
        is obsolete|                            |

--- Comment #19 from Gilles Caulier <[hidden email]> ---
Created attachment 78470
  --> https://bugs.kde.org/attachment.cgi?id=78470&action=edit
updated patch to use Eigen3 instead clapack

I used your first patch posted in RB #109692. I encored these problems :

1/ Your previous patch do not work, to process image. This problem is not fixed
in my version 3. Look my screenshot :

http://www.flickr.com/photos/digikam/8597933204/sizes/o/in/photostream/

Image Refocused is processed with a strange vibrato effect. Also i see that
effect is not reproducible if you changes some parameters. Processing image is
sometimes slow, and sometime very fast with same parameters...

Here i use Eigen3 version 3.05

2/ I review all cmake rules everywhere and patched code to use pre-processor
conditional rules if Eigen3 is present or not. Please use this patch to
investigate problem 1/

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gowtham Ashok]

https://bugs.kde.org/show_bug.cgi?id=251563

--- Comment #20 from Gowtham Ashok <[hidden email]> ---
Created attachment 78503
  --> https://bugs.kde.org/attachment.cgi?id=78503&action=edit
Remove Clapack and replace with Eigen3

Fixed error in refocus filter(verified by comparing the matrices).Time taken to
process image is similar(with reference to Clapack).
Added Eigen3 version in libsinfodlg.cpp, added one line in CMakeLists.txt to
pass version number to it.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=251563

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
   Version Fixed In|                            |3.2.0
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/84d745a59bd0f9d9697b50b
                   |                            |9f8558d368d956faf

--- Comment #21 from Gilles Caulier <[hidden email]> ---
Git commit 84d745a59bd0f9d9697b50b9f8558d368d956faf by Gilles Caulier.
Committed on 30/03/2013 at 18:19.
Pushed by cgilles into branch 'master'.

Remove clapack library from digiKam core used by Refocus tool.
Add new optional dependency to Eigen3 library to replace clapack
REVIEW: 109692
FIXED-IN: 3.2.0

M  +33   -52   CMakeLists.txt
M  +1    -0    NEWS
M  +3    -3    README
D  +0    -44   cmake/modules/FindCLAPACK.cmake
A  +81   -0    cmake/modules/FindEigen3.cmake
M  +1    -11   digikam/CMakeLists.txt
M  +3    -0    digikam/utils/config-digikam.h.cmake
M  +11   -1    imageplugins/enhance/sharpentool.cpp
D  +0    -12   libs/3rdparty/clapack/LICENCE
D  +0    -2    libs/3rdparty/clapack/README
D  +0    -16   libs/3rdparty/clapack/abort_.c
D  +0    -158  libs/3rdparty/clapack/blaswrap.h
D  +0    -5079 libs/3rdparty/clapack/clapack.h
D  +0    -94   libs/3rdparty/clapack/close.c
D  +0    -313  libs/3rdparty/clapack/dgemm.c
D  +0    -143  libs/3rdparty/clapack/dger.c
D  +0    -117  libs/3rdparty/clapack/dgesv.c
D  +0    -157  libs/3rdparty/clapack/dgetf2.c
D  +0    -197  libs/3rdparty/clapack/dgetrf.c
D  +0    -159  libs/3rdparty/clapack/dgetrs.c
D  +0    -143  libs/3rdparty/clapack/dlaswp.c
D  +0    -62   libs/3rdparty/clapack/dscal.c
D  +0    -81   libs/3rdparty/clapack/dswap.c
D  +0    -404  libs/3rdparty/clapack/dtrsm.c
D  +0    -121  libs/3rdparty/clapack/endfile.c
D  +0    -271  libs/3rdparty/clapack/err.c
D  +0    -226  libs/3rdparty/clapack/f2c.h
D  +0    -109  libs/3rdparty/clapack/fio.h
D  +0    -516  libs/3rdparty/clapack/fmt.c
D  +0    -100  libs/3rdparty/clapack/fmt.h
D  +0    -45   libs/3rdparty/clapack/fmtlib.c
D  +0    -28   libs/3rdparty/clapack/fp.h
D  +0    -61   libs/3rdparty/clapack/idamax.c
D  +0    -150  libs/3rdparty/clapack/ieeeck.c
D  +0    -610  libs/3rdparty/clapack/ilaenv.c
D  +0    -101  libs/3rdparty/clapack/lsame.c
D  +0    -291  libs/3rdparty/clapack/open.c
D  +0    -44   libs/3rdparty/clapack/s_cmp.c
D  +0    -51   libs/3rdparty/clapack/s_copy.c
D  +0    -42   libs/3rdparty/clapack/s_stop.c
D  +0    -31   libs/3rdparty/clapack/sfe.c
D  +0    -45   libs/3rdparty/clapack/sig_die.c
D  +0    -53   libs/3rdparty/clapack/util.c
D  +0    -276  libs/3rdparty/clapack/wref.c
D  +0    -365  libs/3rdparty/clapack/wrtfmt.c
D  +0    -73   libs/3rdparty/clapack/wsfe.c
D  +0    -58   libs/3rdparty/clapack/xerbla.c
M  +4    -6    libs/dialogs/libsinfodlg.cpp
M  +6    -1    libs/dimg/filters/dimgfiltermanager.cpp
M  +19   -21   libs/dimg/filters/sharp/matrix.cpp
M  +0    -2    libs/dimg/filters/sharp/matrix.h
M  +41   -10   libs/dimg/filters/sharp/sharpsettings.cpp
M  +1    -1    libs/dimg/filters/sharp/sharpsettings.h
M  +31   -19   utilities/queuemanager/basetools/enhance/sharpen.cpp

http://commits.kde.org/digikam/84d745a59bd0f9d9697b50b9f8558d368d956faf

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel