[Bug 250265] New: Black background of short summary display

https://bugs.kde.org/show_bug.cgi?id=250265

           Summary: Black background of short summary display
           Product: digikam
           Version: 1.4.0
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Thumbnails
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           1.4.0 (using KDE 4.5.0)
OS:                Linux

If i point with the mouse cursor on a thumbnail in the album view the short
summary is displayed with black background since digikam 1.4 on KDE 4.5.1. The
textcolor is also black so the summary is now unreadable.

Reproducible: Always

Steps to Reproduce:
Point on a thumbnail with mouse cursor.

Actual Results:  
Short summary is displayed but with black text on black background. Unreadable.

Expected Results:  
Short summary is displayed with black text on backgroundcolor chosen by the
selected digikam theme.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=250265





--- Comment #1 from Johannes Wienke <languitar semipol de>  2010-09-05 15:18:29 ---
Did you try to switch the digikam theme? Does it change the appearance?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=250265





--- Comment #2 from Lars-Göran Thieme <lars-goeran web de>  2010-09-05 16:56:15 ---
I tried every theme, the text color is changed according to the theme settings
but the background is still black.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=250265





--- Comment #3 from Johannes Wienke <languitar semipol de>  2010-09-05 17:07:17 ---
Ok, does the background color change if you switch to another kde theme?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=250265





--- Comment #4 from Lars-Göran Thieme <lars-goeran web de>  2010-09-05 17:32:33 ---
Ok, that is it! Currently i'm using the oxygen theme but if i switch to
plastique the background color of the short summary display is digikam is
working fine. It gets the color according to the selected theme settings. Its
readable all the time.

But with kde theme oxygen its black on all digikam themes.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=250265


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|Thumbnails                  |Themes




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=250265





--- Comment #5 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-09-05 19:08:16 ---
I can confirm this - or quite: It is transparent. (I assume you dont have full
graphics acceleration enabled or available?).
There must be some "feature" in oxygen to have transparent backgrounds for
certain types of images.
I see a pleasant slightly transparent tooltip background with KMail and Kate.
Not sure what we do wrong, need to check the code.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=250265





--- Comment #6 from Lars-Göran Thieme <lars-goeran web de>  2010-09-05 20:12:49 ---
Sorry, i have forgotten to mention it. I have disabled all the desktop effects
because of some problems with it. So i have no transparency at all.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Samuel Gilbert]

https://bugs.kde.org/show_bug.cgi?id=250265





--- Comment #7 from Samuel Gilbert <samuel gilbert usherbrooke ca>  2010-09-08 06:44:49 ---
Created an attachment (id=51409)
 --> (http://bugs.kde.org/attachment.cgi?id=51409)
Screenshot of the unreadable tooltip

Hello,

I'm not 100% sure this is the same issue, but ever since I upgraded to digiKam
1.4.0, the tooltip in the album view is completely unreadable.  I looks like
the background of the tooltip wasn't drawn.

Can you look at the file I uploaded and tell me if it looks like what you
encountered?

I will try to change my KDE theme to see if it helps.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Samuel Gilbert]

https://bugs.kde.org/show_bug.cgi?id=250265


Samuel Gilbert <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |samuel.gilbert@usherbrooke.
                   |                            |ca




--- Comment #8 from Samuel Gilbert <samuel gilbert usherbrooke ca>  2010-09-08 06:47:53 ---
I just try switching themes and it didn't help in my case.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=250265





--- Comment #9 from Gilles Caulier <caulier gilles gmail com>  2010-09-08 08:47:07 ---
Try to switch KDE theme, not digiKam theme Let's digiKam theme to default

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=250265





--- Comment #10 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-09-08 12:19:53 ---
SVN commit 1172980 by mwiesweg:

Use the current style for drawing of the tooltips:
- no need for a QLable in a QFrame, as a QLabel is a QFrame
- set mask and transparency from style (when compositing is switched off)
- let the style draw toolip panel (background)
- switch to StyledPanel frame style, gives rounded edges

Please see if this agrees with your taste.
Needs testing with KDE 4.4
Needs testing without compositing.


 M  +45 -30    ditemtooltip.cpp  
 M  +2 -2      ditemtooltip.h

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=250265





--- Comment #11 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-09-08 12:20:55 ---
Screenshot (KDE4.5, compositing enabled):
http://img704.imageshack.us/i/plasmadesktopqn1982.png/

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=250265





--- Comment #12 from Lars-Göran Thieme <lars-goeran web de>  2010-09-08 15:37:41 ---
For me it works fine with the diff from r1172980. But Tested only on KDE 4.5.1
with compositing turned on and off!

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Samuel Gilbert]

https://bugs.kde.org/show_bug.cgi?id=250265





--- Comment #13 from Samuel Gilbert <samuel gilbert usherbrooke ca>  2010-09-08 19:30:46 ---
After a bit more testing and investigating, here are my findings :

 - I was changing the KDE Desktop theme which is separate from "Application
Apperance -> Style"

 - KDE compositing setting, X11 Composite extension, and Style have an impact
on how the tooltip is rendered.

 - When composting is enabled and Oxygen is selected, the tooltip renders
correctly with transparency even though it's hard to read.

 - If X11 Composite extension is not loaded and Oxygen is selected, the tootip
renders as shown in the screenshot I uploaded to this issue.

 - When the X11 Composite extension is loaded and Oxygen is selected, but KDE
compositing is disabled, the tooltip gets rendered with a black background.

 - When another theme such as Plastique is selected, the tooltip gets rendered
correctly regardless of the compositing settings.

So is this a digiKam bug or an oxygen bug?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=250265





--- Comment #14 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-09-09 09:58:59 ---
With my fix above, the tooltip is now rendered properly from digikam's side, so
the problem should be solved.

Whose problem was it? It's ok that oxygen defaults to a transparent background.
Before, no style did that so that problem did not appear. We really have to
draw a background. The black background is also the correct fallback.
To have an uninitialized pixmap as in your (Samuel) screenshot is a bug, but
then I can accept that running without the composite extension in the year 2010
is not supported by the style. Those oxygen/kwin guys are troubled enough with
driver bugs.

Gilles:
If this fix is fine with KDE 4.4, I suggest to backport for the 1.5 release?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=250265





--- Comment #15 from Gilles Caulier <caulier gilles gmail com>  2010-09-09 10:05:07 ---
yes, it work under 4.4. It can be backported to 1.5 release.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=250265


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #16 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-09-09 22:16:11 ---
SVN commit 1173603 by mwiesweg:

Backport changes in thumbnail drawing

BUG: 250265

 M  +45 -30    ditemtooltip.cpp  
 M  +2 -2      ditemtooltip.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1173603

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=250265


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=250265





--- Comment #17 from Gilles Caulier <caulier gilles gmail com>  2010-09-13 05:04:45 ---
Created an attachment (id=51576)
 --> (http://bugs.kde.org/attachment.cgi?id=51576)
problem with KDE 4.4.x

Marcel,

i just discover a problem with KDE 4.4.x and "wonton soup" color scheme from
KDE and digiKam using default color scheme. Look my screenshot from windows.

Testing the same configuration under Linux another wrong result.

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel