[Bug 241116] New: [Themes] Cannot change text colour in menu bar

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 241116] New: [Themes] Cannot change text colour in menu bar

Bugzilla from bugzilla@affari.to
https://bugs.kde.org/show_bug.cgi?id=241116

           Summary: [Themes] Cannot change text colour in menu bar
           Product: digikam
           Version: 1.2.0
          Platform: Ubuntu Packages
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Themes
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Created an attachment (id=47816)
 --> (http://bugs.kde.org/attachment.cgi?id=47816)
Screenshot of Digikam's menu with unreadable text in Ubuntu 10.04

Version:           1.2.0 (using KDE 4.4.2)
OS:                Linux

In Ubuntu 10.04 I have the same issue reported by Dicusar (on Windows) in
ticket #240148: changing to a theme with a dark background (e.g. Dessert, DLR,
Dark), the text in the menu bar at the top becomes unreadable (dark text on
dark background), see attachment. I have tried to create a new theme with a
lighter text colour for the menu, but TextRegularColor, TextSelectedColor,
TextSpecialRegularColor and TextSpecialSelectedColor have no effect on that.
How do we change it?

Reproducible: Always

Steps to Reproduce:
1) Launch Digikam
2) Select SETTINGS ->THEMES -> DLR
3) Try to read the text next to the icons for NEW, PROPERTIES, SEARCH, VIEW,
EDIT, and any other on the same line of the menu.

Actual Results:  
The text alongside the icons is black on dark background, very hard to read (at
least for me and, I guess, for the user who created #240148).

Expected Results:  
I'd expect to be able to change the colour of the menu's text by editing the
available themes or by creating a new one. DigiKam's themes XML specifications
should include an XML tag for this, e.g. TextMenuColor.

Side note: the theme editor mentioned at http://www.digikam.org/drupal/node/26
seems to have disappeared...

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 241116] [Themes] Cannot change text colour in menu bar

Gilles Caulier-4
https://bugs.kde.org/show_bug.cgi?id=241116


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2010-06-08 17:36:21 ---
You don't need theme editor in fact. theme are simple XML files.

I recommend to change KDE color scheme to see if problem come there. I cannot
reproduce the problem on my system.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 241116] [Themes] Cannot change text colour in menu bar

Bugzilla from bugzilla@affari.to
In reply to this post by Bugzilla from bugzilla@affari.to
https://bugs.kde.org/show_bug.cgi?id=241116


[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #2 from  <bugzilla affari to>  2010-06-08 18:26:57 ---
Gilles,
Thanks for the ultra-prompt reply. Not a life-or-death issue, slow down...  ;)  

(the tagging issue - #237452 - is a lot more serious, it's a show-stopper, at
least for me).

> I recommend to change KDE color scheme to see if problem come there.

I appreciate your advice, but the only colour schemes that I appreciate have a
dark background, and they all suffer from the same issue: dark text on dark
background, which makes the text unreadable.

> I cannot reproduce the problem on my system.
But have you seen the screenshot and the other request on the same issue
(#240148)? Can you read the text?


> You don't need theme editor in fact. theme are simple XML files.

I know these are XML files, and I have already edited them, but the DigiKam
website says there's a theme editor, and instead there isn't, apparently.

However, working on the XML files does not fix the problem, since there seems
to be no selector/tag to alter the colour of the menu text. Is there a way to
change the colour of that text (indicated by the orange arrows in my
screenshot)?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 241116] [Themes] Cannot change text colour in menu bar

Sylvain ZUCCA
In reply to this post by Bugzilla from bugzilla@affari.to
https://bugs.kde.org/show_bug.cgi?id=241116


sylvainsjc <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #3 from sylvainsjc <sylvainsjc gmail com>  2010-08-28 12:33:18 ---
rather annoying problem
Expecting a solution soon
regards

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 241116] [Themes] Cannot change text colour in menu bar

Gilles Caulier-4
In reply to this post by Bugzilla from bugzilla@affari.to
https://bugs.kde.org/show_bug.cgi?id=241116


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #4 from Gilles Caulier <caulier gilles gmail com>  2011-04-07 14:11:00 ---
Git commit e55f3d748f461f2f1ac956995d644de658200a4a by Gilles Caulier.
Committed on 07/04/2011 at 14:11.
Pushed by cgilles into branch 'master'.

port digiKam theme engine to KDE color Theme engine.
Now, there is no mix between digiKam color engine and KDE theme used in
background.
Benefits : we can donload new color theme scheme from KDE control center and
apply it to digiKam as well,
independently of the rest of KDE.

To end users : I don't tested under Gnome. Please give me a feedback...

BUGS: 257803
BUGS: 250265
BUGS: 220068
BUGS: 241116
BUGS: 252700
BUGS: 168669
CCBUGS: 265554

M  +0    -1    data/CMakeLists.txt    
D  +0    -74   data/themes/Blue    
D  +0    -15   data/themes/CMakeLists.txt    
D  +0    -75   data/themes/Clean    
D  +0    -75   data/themes/DLR    
D  +0    -74   data/themes/Dark    
D  +0    -78   data/themes/DarkRoom    
D  +0    -63   data/themes/Dessert    
D  +0    -75   data/themes/Digikasa    
D  +0    -75   data/themes/Dreary    
D  +0    -63   data/themes/Gray    
D  +0    -75   data/themes/Marine    
D  +0    -75   data/themes/OrangeCrush    
D  +0    -62   data/themes/Rose    
D  +0    -75   data/themes/Sandy    
M  +13   -40   digikam/main/digikamapp.cpp    
M  +1    -3    digikam/main/digikamapp.h    
M  +0    -3    digikam/main/digikamapp_p.h    
M  +1    -5    libs/themeengine/theme.cpp    
M  +1    -4    libs/themeengine/theme.h    
M  +198  -1187 libs/themeengine/themeengine.cpp    
M  +16   -15   libs/themeengine/themeengine.h    
M  +6    -5    showfoto/main/showfoto.cpp    
M  +1    -29   utilities/cameragui/main/cameraui.cpp    
M  +0    -3    utilities/cameragui/main/cameraui.h    
M  +0    -3    utilities/cameragui/main/cameraui_p.h    
M  +1    -43   utilities/imageeditor/editor/editorwindow.cpp    
M  +0    -6    utilities/imageeditor/editor/editorwindow.h    
M  +0    -12   utilities/imageeditor/editor/imagewindow.cpp    
M  +0    -2    utilities/imageeditor/editor/imagewindow.h    
M  +1    -32   utilities/lighttable/lighttablewindow.cpp    
M  +0    -3    utilities/lighttable/lighttablewindow.h    
M  +0    -3    utilities/lighttable/lighttablewindow_p.h    
M  +1    -32   utilities/queuemanager/main/queuemgrwindow.cpp    
M  +0    -3    utilities/queuemanager/main/queuemgrwindow.h    
M  +0    -3    utilities/queuemanager/main/queuemgrwindow_p.h    

http://commits.kde.org/digikam/e55f3d748f461f2f1ac956995d644de658200a4a

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 241116] [Themes] Cannot change text colour in menu bar

Gilles Caulier-4
In reply to this post by Bugzilla from bugzilla@affari.to
https://bugs.kde.org/show_bug.cgi?id=241116

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 241116] [Themes] Cannot change text colour in menu bar

Gilles Caulier-4
In reply to this post by Bugzilla from bugzilla@affari.to
https://bugs.kde.org/show_bug.cgi?id=241116

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Themes                      |setup

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 241116] [Themes] Cannot change text colour in menu bar

bugzilla_noreply
In reply to this post by Bugzilla from bugzilla@affari.to
https://bugs.kde.org/show_bug.cgi?id=241116

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/4837b2773846c7c32e947d3
                   |                            |b1b8b706275731b95
   Version Fixed In|2.0.0                       |5.0.0

--- Comment #5 from [hidden email] ---
Git commit 4837b2773846c7c32e947d3b1b8b706275731b95 by Gilles Caulier.
Committed on 30/05/2016 at 18:54.
Pushed by cgilles into branch 'master'.

Dispatch colors theme properly to widget style manager for main windows
Related: bug 172632, bug 146938, bug 265554, bug 240148, bug 252700, bug
168669, bug 179898, bug 220068
FIXED-IN: 5.0.0

M  +2    -1    libs/widgets/mainview/thememanager.cpp

http://commits.kde.org/digikam/4837b2773846c7c32e947d3b1b8b706275731b95

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 241116] [Themes] Cannot change text colour in menu bar

bugzilla_noreply
In reply to this post by Bugzilla from bugzilla@affari.to
https://bugs.kde.org/show_bug.cgi?id=241116

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|setup                       |Usability-Menus

--
You are receiving this mail because:
You are the assignee for the bug.