[Bug 234545] New: Red eye correction tool is missing from image editor

https://bugs.kde.org/show_bug.cgi?id=234545

           Summary: Red eye correction tool is missing from image editor
           Product: digikam
           Version: 1.2.0
          Platform: Archlinux Packages
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           1.2.0 (using KDE 4.4.2)
OS:                Linux
Installed from:    Archlinux Packages

Digikam image editor should have a 'red eye correction' tool in the 'enhance'
menu according to the documentation.
This menu entry has disappeared.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=234545


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Geolocation




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2010-04-16 18:33:02 ---
Not reproducible there. Sound like a packaging issue.

please start digiKam from a console and post there all debug messages. note :
install digikam-debug package before...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=234545


Johannes Wienke <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Geolocation                 |Image Editor




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=234545





--- Comment #2 from Andreas Tiemeyer <grey271 btinternet com>  2010-04-17 02:03:41 ---
Created an attachment (id=42832)
 --> (http://bugs.kde.org/attachment.cgi?id=42832)
corrected name for redeye plugin

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=234545





--- Comment #3 from Andreas Tiemeyer <grey271 btinternet com>  2010-04-17 02:08:04 ---
(From update of attachment 42832)
The problem seems to be that the name of the redeye plugin is not the same in
the _rc.ui file and the c++ code.

However: if this is the root cause, the bug should be reproducible every time
on the released sources. So I don't understand how it counld not be reproduced.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=234545


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #4 from Gilles Caulier <caulier gilles gmail com>  2010-04-17 11:15:10 ---
This problem will must be fixed in 1.3.0 (code from svn trunk). I factored
image plugins to speed up startup.

Can you checkout code from svn trunk and confirm please ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=234545


SanskritFritz <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #5 from SanskritFritz <SanskritFritz gmail com>  2010-04-17 15:18:59 ---
I can confirm that the patch works, I recompiled digikam 1.2 with the patch
applied, and redeye correction is back. Thank you.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=234545





--- Comment #6 from Andreas Tiemeyer <grey271 btinternet com>  2010-04-17 18:03:02 ---
(In reply to comment #4)
>
> Can you checkout code from svn trunk and confirm please ?
>
> Gilles Caulier
>

That pulls in too many dependencies - I'd have to rebuild kdegraphics from svn
as well according to the package information of my distribution, which I
usually trust. I don't think it's worth it - this isn't a bug that depends on
the environment. If it works for you on the trunk sources, it will work for me.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=234545





--- Comment #7 from SanskritFritz <SanskritFritz gmail com>  2010-04-19 10:43:36 ---
The functionality is still there, the item is just missing from the Enhance
menu. Instead of recompiling and applying a patch you can try adding a custom
"Red Eye" button to the toolbar.
http://bbs.archlinux.org/viewtopic.php?pid=744981#p744981

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=234545





--- Comment #8 from sean <seandarcy hotmail com>  2010-04-24 15:52:43 ---
I'm using digikam and kipi-plugins from svn today: At revision 1118351.

There's no red eye correction tool in the Enhance menu.

sean

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=234545


sean <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #9 from sean <seandarcy hotmail com>  2010-04-24 16:03:35 ---
Just tried the steps from
http://bbs.archlinux.org/viewtopic.php?pid=744981#p744981.

That had no effect. In fact, it didn't change the Enhance drop down menu for
any item if I changed it.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=234545





--- Comment #10 from SanskritFritz <SanskritFritz gmail com>  2010-04-24 21:15:40 ---
sean, if you read it more carefully, you will see it changes the toolbar and
not the menu.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=234545





--- Comment #11 from sean <seandarcy hotmail com>  2010-04-24 21:26:15 ---
I'm in Image Editor. I see 3 toolbars:

Top:  File Edit View Color etc
Just below Top:  First Back Forward etc
Bottom: <filename>  No selection <w x h> etc

I don't see Red Eye anywhere. Am I looking in the wrong place?

sean

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=234545





--- Comment #12 from SanskritFritz <SanskritFritz gmail com>  2010-04-24 21:31:17 ---
Right click on the toolbar / Configure toolbars / Toolbar:
digikamimageplugin_enhance / highlight Red Eye in the list below / Click the
right arrow to transfer it to the right side / Ok.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=234545


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #13 from Gilles Caulier <caulier gilles gmail com>  2010-04-25 07:27:29 ---
SVN commit 1118552 by cgilles:

use right name for Red eyes tool action
BUGS: 234545


 M  +2 -2      digikamimageplugin_enhance_ui.rc  
 M  +1 -1      imageplugin_enhance.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1118552

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=234545

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |1.3.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel