[Bug 233409] New: Image watermark in batch queue manager

https://bugs.kde.org/show_bug.cgi?id=233409

           Summary: Image watermark in batch queue manager
           Product: digikam
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:            (using Devel)
OS:                Linux
Installed from:    Compiled sources

I would like an image watermark tool in the batch queue manager just like the
current text watermark tool.

I have implemented this, and I will attach patch and new files.
There is one point that I don't know how to handle best because I am new to
KDE, Qt, and Digikam development, and that is how to best make a "Select image
file" dialog and button.

So in my new tool, there is just a KLineEdit for typing in the full path of the
watermark image file. I hope you can give me advice on this point.

I hope this will be the beginning of a more active involvement in Digikam
development on my part.

Best regards,
Mikkel Bækhøj Christensen

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=233409





--- Comment #1 from asw20pilot <mbc baekhoej dk>  2010-04-05 20:12:12 ---
Created an attachment (id=42510)
 --> (http://bugs.kde.org/attachment.cgi?id=42510)
Patch for batchtoolsmanager.cpp to add new tool

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=233409


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|general                     |Batch Queue Manager
            Version|unspecified                 |1.3.0




--- Comment #2 from Gilles Caulier <caulier gilles gmail com>  2010-04-05 20:13:59 ---
Mikkel,

This tool already exist in digiKam 1.1 and 1.2. Why not to improve it instead
to create new one ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=233409





--- Comment #3 from asw20pilot <mbc baekhoej dk>  2010-04-05 20:17:03 ---
Created an attachment (id=42513)
 --> (http://bugs.kde.org/attachment.cgi?id=42513)
New tool cpp file

To be placed in:
digikam/graphics/digikam/utilities/queuemanager/basetools/decorate/imagewatermark.cpp

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=233409





--- Comment #4 from asw20pilot <mbc baekhoej dk>  2010-04-05 20:18:57 ---
Created an attachment (id=42514)
 --> (http://bugs.kde.org/attachment.cgi?id=42514)
Header file

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=233409





--- Comment #5 from Gilles Caulier <caulier gilles gmail com>  2010-04-05 20:19:29 ---
Screenshot of current Watermark tool for Batch Queue Manager :

http://farm5.static.flickr.com/4014/4494397892_f122f1c118_b.jpg

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=233409





--- Comment #6 from Gilles Caulier <caulier gilles gmail com>  2010-04-05 20:21:23 ---
Current code of watermake tool :

http://websvn.kde.org/*checkout*/trunk/extragear/graphics/digikam/utilities/queuemanager/basetools/decorate/watermark.cpp?revision=1102593

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=233409





--- Comment #7 from asw20pilot <mbc baekhoej dk>  2010-04-05 20:23:27 ---
Wow, you are quick!

I have not found a tool in Digikam to add an image watermark. I have found the
text watermark tool only. Is there another one? Based on the text watermark
tool, I have made this tool that adds an image instead of text.

I thought it would be just as flexible to have to different tools in the Batch
queue, but if you want me to integrate the two, I will probably be able to do
that. However, I would be pleased if you can take the time to look at what I
have already done.

Best regards,
Mikkel

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=233409





--- Comment #8 from asw20pilot <mbc baekhoej dk>  2010-04-05 20:26:39 ---
The tool that you are talking about is actually the tool that I have improved
upon.

Mikkel

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=233409





--- Comment #9 from Gilles Caulier <caulier gilles gmail com>  2010-04-05 20:28:35 ---
No, there is no tool to watermark a photo with a logo or a small image. Ther is
only the curent tool to watermark a photo with a text.

I'm agree to add this new feature : watermark with a logo. But this feature
must be merged with the current Watermark tool. It's not very difficult to do.

In fact, add a combobox to settings widget to give to user the way to select to
add a text or a logo as wartermark.

What do you think about ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=233409





--- Comment #10 from Gilles Caulier <caulier gilles gmail com>  2010-04-05 20:32:02 ---

Mikkel,

Your code and my code need to be merged. Just patch the current tool as well,
it's enough.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=233409





--- Comment #11 from asw20pilot <mbc baekhoej dk>  2010-04-05 20:36:33 ---
I will look at merging them. It might take some time, because the Qt gui
programming is the hardest part for me, because this is the first time I have
touched Qt.

Do you have any advice about how to do an "Open file" dialog instead of the
KLineEdit?

Mikkel

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=233409





--- Comment #12 from Gilles Caulier <caulier gilles gmail com>  2010-04-05 20:46:55 ---
Use this widget :

http://api.kde.org/4.4-api/kdelibs-apidocs/kio/html/classKUrlRequester.html

Check digiKam code, there is a lots of sample to get inspiration...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=233409





--- Comment #13 from Gilles Caulier <caulier gilles gmail com>  2010-04-06 19:08:34 ---
Mikkel,

Any progress. Do you need help ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=233409





--- Comment #14 from asw20pilot <mbc baekhoej dk>  2010-04-06 20:16:03 ---
I think I have what I need. KUrlRequester was exactly the right thing - very
easy to use.
Unfortunately, now that the easter vacation is over, I need to prioritize my
day job programming, so I probably won't finish the watermark code until the
end of this week. But I will do it, don't worry.

Mikkel

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=233409


asw20pilot <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42510|0                           |1
        is obsolete|                            |
  Attachment #42513|0                           |1
        is obsolete|                            |
  Attachment #42514|0                           |1
        is obsolete|                            |




--- Comment #15 from asw20pilot <mbc baekhoej dk>  2010-04-12 16:22:40 ---
Created an attachment (id=42716)
 --> (http://bugs.kde.org/attachment.cgi?id=42716)
Improved watermark tool that allows image overlays.

I think this patch should do the trick. I changed the text part a bit too to
make it more flexible. I hope you like it.

Mikkel

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=233409


Fri13 <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #16 from Fri13 <friiduh gmail com>  2010-04-12 17:15:48 ---
Is there going to be a option to set position from corner with pixels?

Like first you select the corner or center position (middle on vertical and
horizontal position). Then the range in pixels from them to nearest edge/corner
of watermark image.

Of course with % amount with both axis we could have a watermark where we want.
But it should be centered someway to middle so the watermark can be centered
easily without needed to find out how to get it centered properly.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=233409





--- Comment #17 from asw20pilot <mbc baekhoej dk>  2010-04-12 20:26:12 ---
I do not plan to add an offset in pixels. In the batch queue, you could be
adding watermarks to images with different sizes, and in that case, a pixel
offset will give varying results.

But if I understand you correctly, you want to center the watermark in the
image? If that is the case, you will be glad to know that I have already added
a "center" option in addition to "top left", "top right", "bottom left",
"bottom right".

Mikkel

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=233409





--- Comment #18 from Mikkel Christensen <mbc baekhoej dk>  2010-06-01 14:51:40 ---
Hi Gilles,

It is now some time since I finished this improved watermarking feature. Is
there anything else I need to do to get it considered for committing to trunk?

Regards,
Mikkel

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=233409





--- Comment #19 from Gilles Caulier <caulier gilles gmail com>  2010-06-01 15:03:18 ---
My appologies. I just forget to check again your patch. I will do it soon.

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel