[Bug 233094] New: Thumbnails blurry (when scaling) on PowerPC platform (big-endian)

[Raphael Schweizer]

https://bugs.kde.org/show_bug.cgi?id=233094





--- Comment #20 from Raphael Schweizer <rschweizer schweizer-informatik ch>  2010-04-14 22:56:19 ---
Marcel,

please excuse me for my wrong accusation.
On my work machine the thumb strip on top (when viewing thumbs and preview) can
be expanded just so far that the thumbnail is at most 254x254 (which led to the
wrong conclusion). In a VM I just used, it as at most 246px. Maybe you could
allow resizing the upper part of the UI to allow "native" sized thumbnails.

Raphael

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=233094





--- Comment #21 from Gilles Caulier <caulier gilles gmail com>  2010-04-15 08:52:50 ---
Raphael,

In comment #14, you talk about a threshold for downsampling image. Currently it
set to level 3.

It's possible to add an option to disable this feature in compression process
if quality is more than 3 ?

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Raphael Schweizer]

https://bugs.kde.org/show_bug.cgi?id=233094





--- Comment #22 from Raphael Schweizer <rschweizer schweizer-informatik ch>  2010-04-15 13:49:56 ---
Gilles,

it is possible to set a higher threshold in
http://lxr.kde.org/source/extragear/graphics/digikam/libs/3rdparty/libpgf/PGFtypes.h#53
Set it to 31 to completely disable downsampling. However, no one should be able
to distinguish visually images compressed on q4 with downsampling en- or
disabled.

I recommend using the PGFconsole to experiment with encoding settings and
observing PSNR / size changes.

Raphael

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Raphael Schweizer]

https://bugs.kde.org/show_bug.cgi?id=233094





--- Comment #23 from Raphael Schweizer <rschweizer schweizer-informatik ch>  2010-04-15 14:48:33 ---
Created an attachment (id=42801)
 --> (http://bugs.kde.org/attachment.cgi?id=42801)
Modified to write debug image files

Vlado,

though we did find some PPC / big endian issues we couldn't reproduce the
dramatic quality loss you demonstrated in comment #12

I would be pleased to investigate further. Do you mind compiling digiKam using
the attached pgfutils.cpp (and comparing it's results to the PGFconsole [SVN:
https://libpgf.svn.sourceforge.net/svnroot/libpgf]). pgfutils is modified to
write to "/tmp/":
a) writeQImage.bmp (the thumbnail image we encode)
b) writeStream.pgf (the encoded thumbnail)
c) readStream.pgf (the pgf read from the thmbnails db)
d) readQImage.bmp (the decoded bitmap, returned to digiKam)
I'm interested in all those files (+ a) encoded with the console and afterwards
decoded + the original image.)

In order to make this work you'll have to create an album with only the image
of interest, load this album (-> a,b) and resize the thumb (-> c,d)

I know this is a lot of work, please let me know if I can assist in any way.

Raphael

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Vlado Plaga]

https://bugs.kde.org/show_bug.cgi?id=233094





--- Comment #24 from Vlado Plaga <rechner vlado-do de>  2010-04-15 15:57:58 ---
Ok, Raphael, your instructions for investigating the issue further seem clear
enough to me. I should be able to produce these debug files on Sunday, but
probably not earlier.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=233094





--- Comment #25 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-04-15 21:26:53 ---
SVN commit 1115266 by mwiesweg:

Adjust the ImageThumbnailBar so that showing thumbnails up to full 256 is
possible.
For this we need to find out pixel-exactly which viewport size (we know the max
value for
that) corresponds to which widget size (which we can set a max value for).
It seems to work to just take the difference of the two at one point of time.
Additionally, add the two pixels used for the highlighting border.

CCBUG:  233094

 M  +16 -4     digikam/imagethumbnailbar.cpp  
 M  +1 -0      digikam/imagethumbnailbar.h  
 M  +2 -1      digikam/imagethumbnaildelegate.cpp  
 M  +8 -0      libs/threadimageio/thumbnailloadthread.cpp  
 M  +2 -0      libs/threadimageio/thumbnailloadthread.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1115266

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Vlado Plaga]

https://bugs.kde.org/show_bug.cgi?id=233094





--- Comment #26 from Vlado Plaga <rechner vlado-do de>  2010-04-18 14:58:56 ---
Created an attachment (id=42874)
 --> (http://bugs.kde.org/attachment.cgi?id=42874)
patch to digiKam 1.2.0's pgfutils.cpp to create debug files in /tmp

Raphael,
using your patched pgfutils.cpp from 2010-04-15 (comment 23) I also could not
reproduce the blurriness issue. The reason seems to be that you patched the
current SVN version of pgfutils.cpp, which already includes your patches from
2010-04-14 (comment 15)! Isolating the debug patch and merging the two relevant
sections into digiKam 1.2.0's original pgfutils.cpp led to PGF files in /tmp
that where buggy, showed in strange colours in showfoto, and even lead to a
program crash (although that crash could also have been caused by something
else). I'll send you the debug images (~ 500 KByte) in a private e-mail.

In case anyone is curious to (better) see the picture I mainly used for
comparison:
http://www.vlado-do.de/photos/image.php?src=australia_2008&img=2008-11-21__17-48-38

Gilles, judging from the tests I ran today with digiKam 1.2.0 source code it
seems not necessary to reduce the PGF thumbnails' compression level (in
thumbnailcreator.cpp), if the current pgfutils.cpp (from SVN) is used. So you
might want to undo that compression level change in SVN before the next digiKam
release.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Raphael Schweizer]

https://bugs.kde.org/show_bug.cgi?id=233094





--- Comment #27 from Raphael Schweizer <rschweizer schweizer-informatik ch>  2010-04-18 17:57:32 ---
Vlado,

thank you for creating those files. I'm glad to hear that the issues are
resolved in the newest version.
The strange colors are caused by the missing int[] map. PGF internally works
with YUV images and by default imports / exports BGRA bitmaps. If the caller
supplies / needs ARGB format, we have to supply the corresponding mapping (ARGB
-> BGRA: [3, 2, 1, 0]). As these are missing from 1.2.0 digiKam, libPGF does a
wrong YUV transformation and the images end up 'blueish'. However, I can't
explain how this is linked to the blurriness. The crash was most likely caused
by a 'short' map, which is also fixed in SVN.
Encoding the debig_svn/writeQImage.bmp with the windows version of libPGF now
gives the same result as on your PPC. Therefore, digiKam 1.3.0 should work as
expected.

Raphael

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=233094





--- Comment #28 from Gilles Caulier <caulier gilles gmail com>  2010-04-18 20:04:56 ---
>Gilles, judging from the tests I ran today with digiKam 1.2.0 source code it
>seems not necessary to reduce the PGF thumbnails' compression level (in
>thumbnailcreator.cpp), if the current pgfutils.cpp (from SVN) is used. So you
>might want to undo that compression level change in SVN before the next digiKam
>release.

Yes, i will take a look about. it's in my TODO list

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=233094





--- Comment #29 from Gilles Caulier <caulier gilles gmail com>  2010-04-19 08:39:06 ---
SVN commit 1116312 by cgilles:

restore PGF quality 4 for thumb compression.
Please check if thumbnails are not to blured there with this value, else, use
only 3 instead...
CCBUGS: 233094


 M  +4 -3      pgfutils.h  
 M  +3 -2      thumbnailcreator.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1116312

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=233094





--- Comment #30 from Gilles Caulier <caulier gilles gmail com>  2010-04-19 08:41:27 ---
To Vlado,

PGF compression quality is restored to 4. Please checkout svn trunk again, and
re-generate all tumbnails using "Tool/Rebuild Thnumbnails" option. Check if
blur effect is back or not.

Thanks in advance

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=233094





--- Comment #31 from Gilles Caulier <caulier gilles gmail com>  2010-04-19 08:46:31 ---
Marcel,

I'm not sure if i found a bug about color management and thumbs view.

There i generated all thumbs with CM enabled for thumbs, and disabling lead CM
option do not change something. i use a dumy ICC profile as wide-gamut to see
the difference, anyway sRGB do not give visible effect.

Do you store thumbs in DB with CM correction or as well, and you apply CM only
when thumbs are displayed ?

Vlado, Just to be sure, do you use Color Management on your system ?

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Raphael Schweizer]

https://bugs.kde.org/show_bug.cgi?id=233094





--- Comment #32 from Raphael Schweizer <rschweizer schweizer-informatik ch>  2010-04-19 12:42:29 ---
Marcel,

in revision 1116346 resizing the thumbnailbar to allow 256x256 images is not
possible for me. Tried using work machine (resolution 1600x1200) and VM (do. &
1400x1050).

Raphael

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=233094





--- Comment #33 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-04-19 21:59:38 ---
SVN commit 1116583 by mwiesweg:

For the preview thumbbar, also adjust the thumbnail size to reach 256

CCBUG: 233094

 M  +1 -1      digikam/imagethumbnaildelegate.cpp  
 M  +7 -0      libs/threadimageio/thumbnailloadthread.cpp  
 M  +1 -0      libs/threadimageio/thumbnailloadthread.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1116583

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Vlado Plaga]

https://bugs.kde.org/show_bug.cgi?id=233094





--- Comment #34 from Vlado Plaga <rechner vlado-do de>  2010-04-20 23:21:39 ---
Gilles, I currently can't compile SVN digiKam. Recently you answered someone's
question "But svn requires kde 4.5?" with "yes digiKam from trunk depand of
libkdcraw from trunk which is KDE 4.5" on digikam-users.

Anyway I now compiled digiKam 1.2 with pgfutils.cpp from SVN (and no other
modifications) and the thumbnail quality seems good again. I tried this in
Debian and Ubuntu. So I guess the big-endian problem is properly fixed now.

To answer you other question, Gilles: I don't use color management on my
system.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=233094





--- Comment #35 from Gilles Caulier <caulier gilles gmail com>  2010-04-21 09:23:55 ---
Thanks Vlado,

Yes, current code from svn need libkdcraw and libkexiv2 from trunk which will
be published with KDE 4.5.

But libkdcraw and libkexiv2 do not depand of KDE 4.5 and compile fine with
older KDE version. Just checkout code from kdegraphics/libs, compile and
install these libraries, and recompile digiKam /kipi-plugins from trunk as
well.

More details here :

http://www.digikam.org/drupal/sharedlibs

http://www.digikam.org/drupal/download?q=download/KDE4

Here i use Mandriva 2010.0 which use KDE 4.3.x. No problem.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Raphael Schweizer]

https://bugs.kde.org/show_bug.cgi?id=233094





--- Comment #36 from Raphael Schweizer <rschweizer schweizer-informatik ch>  2010-04-21 11:07:57 ---
Created an attachment (id=42934)
 --> (http://bugs.kde.org/attachment.cgi?id=42934)
Maximum thumbnail size on Ubuntu 1600x1200

Marcel,

as of rev. 1117090 I still can't resize the thumbnailbar to hold images of
256px (see attached, cropped screenshot). Do you need additional information?

Raphael

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Vlado Plaga]

https://bugs.kde.org/show_bug.cgi?id=233094





--- Comment #37 from Vlado Plaga <rechner vlado-do de>  2010-04-21 16:17:00 ---
Gilles,

after you gave these more detailed instructions I tried to compile libkdcraw
and libkexiv2 from trunk in my Debian unstable system. libkdcraw compiles all
right, but libkexiv2 does not. Something seems to go wrong with the
configuration, but there is only a warning "No cmake_minimum_required command
is present". Still the Makefile generated by cmake is just 3.7 KByte, whereas
the Makefile for libkdcraw is about 14 KByte. Calling "make" for libkexiv2 does
not seem to do anything.

I could give it another try, if you have any suggestions, but I'm confident it
is not necessary for the libpgf problem anymore.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=233094





--- Comment #38 from Johannes Wienke <languitar semipol de>  2010-04-21 17:28:12 ---
You have to checkout the whole kdegraphics tree from that svn that contains
libs/libkexiv2 as a subfolder, call cmake directly in kdegraphics, cd tp
libs/libkexiv2 and call make, make install there.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=233094





--- Comment #39 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-04-21 18:40:36 ---
Raphael: This affects only the thumbbar, in the main icon view you can reach
256?
Which widget style do you use, which KDE/Qt version?
There is no really clean solution, because I know the size the viewport shall
have, while I can only set the size of the whole widget, including border,
scrollbar etc. I tested here but maybe it doesn't work in other settings.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel