[Bug 232926] New: in painting causes digikam to lock up

https://bugs.kde.org/show_bug.cgi?id=232926

           Summary: in painting causes digikam to lock up
           Product: digikam
           Version: 1.3.0
          Platform: Debian stable
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: crash
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           1.3.0 (using KDE 4.4.1)
OS:                Linux
Installed from:    Debian stable Packages

To reproduce

1. Select Picture
2. Select edit
3. Select area to inpaint
4. Click on inpaint

Move mouse away from image and it will do the target to Original view.

It will say inpainting at the bottom of the screen 0% the app becomes no
responsive

The cimg filter will say none

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=232926


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|general                     |Inpainting
            Product|digikam                     |digikamimageplugins




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=232926





--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2010-04-01 09:04:50 ---
Note : new CImg version do not have greystoration code anymore. all code have
been move to GMic library :

http://gmic.sourceforge.net/

So digiKam greycstoration filter need to be ported to GMic

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=232926





--- Comment #2 from Gilles Caulier <caulier gilles gmail com>  2010-04-04 10:47:28 ---
digiKam and Kipi-plugins 1.2.0 are out. Please check if crash is still valid
there.

Thanks in advance

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=232926


[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #3 from  <rerxrerx gmail com>  2010-04-05 23:36:09 ---
Digikam 1.2.0 locks up on my system (KDE 4.4.2, Kubuntu 9.10) as well when I
try "in-painting".

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=232926





--- Comment #4 from Von Wallace <vonwallace yahoo com>  2010-04-06 14:42:04 ---
(In reply to comment #2)
> digiKam and Kipi-plugins 1.2.0 are out. Please check if crash is still valid
> there.
>
> Thanks in advance
>
> Gilles Caulier

I complied the latest from svn of kdegraphics

I complied the latest digikam from svn 1.3.0


And it still hangs

Everything works in Digikam, this is the only kink in its armor that I have
found.

When you first enter into inpainting mode it trys to render the target no
matter what even if no cmig filter is selected...

Sometimes you can cancel it and other times digikam just freezes when you try
to cancel it.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=232926





--- Comment #5 from Gilles Caulier <caulier gilles gmail com>  2010-04-06 14:44:41 ---
Inpainting use CImg and Greystoration interface/algorithm. It's the same for
Restauration tool.

Restauration tool loop up also on your computer ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=232926





--- Comment #6 from Gilles Caulier <caulier gilles gmail com>  2010-04-06 14:54:34 ---
loop-up is not reproducible here.

I suspect a wrong settings in your ~/.kde4/share/config/digikamrc file

close digiKam and edit this text file. Remove the following section :

[inpainting Tool]
Alpha=0.800000011920929
Amplitude=20
Anisotropy=1
BTile=4
Da=30
Dl=0.800000011920929
FastApprox=true
GaussPrec=2
Interpolation=0
Iteration=30
Preset=1
Sharpness=0.300000011920929
Sigma=2
Tile=256

Settings will be different on your computer of course. Start digiKam and try
again

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=232926





--- Comment #7 from Gilles Caulier <caulier gilles gmail com>  2010-04-06 14:55:38 ---
Look like computation work fine on my computer :

http://farm5.static.flickr.com/4045/4496323427_f48070d321_b.jpg

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=232926





--- Comment #8 from Von Wallace <vonwallace yahoo com>  2010-04-07 07:09:41 ---
Does not do it when doing restoration..

I sent you a video on face book of the problem.




________________________________
From: Gilles Caulier <[hidden email]>
To: [hidden email]
Sent: Tue, April 6, 2010 7:44:45 AM
Subject: [Bug 232926] in painting causes digikam to lock up

https://bugs.kde.org/show_bug.cgi?id=232926





--- Comment #5 from Gilles Caulier <caulier gilles gmail com>  2010-04-06
14:44:41 ---
Inpainting use CImg and Greystoration interface/algorithm. It's the same for
Restauration tool.

Restauration tool loop up also on your computer ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=232926





--- Comment #9 from Gilles Caulier <caulier gilles gmail com>  2010-04-07 08:30:06 ---
Do you have tried #6 ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=232926





--- Comment #10 from Von Wallace <vonwallace yahoo com>  2010-04-07 14:20:56 ---
Tried #6

1. The inpainting tool still tries to render when first launched even when cmig
is set to none... and and sits there on zero... (restoration tool does not do
this)

The good news is I can click the cancel icon button next to the progress bar
and it stops inpainting, and digikam gives me back control of the form / app.

So editing the file helped, but there is still some program logic that needs to
be looked at.. as (restoration does not try to automatically render when
launched)

Thank you.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=232926





--- Comment #11 from Gilles Caulier <caulier gilles gmail com>  2010-11-24 09:23:04 ---
digiKam 1.6.0 is out:

http://www.digikam.org/drupal/node/550

Please update and check if this entry still valid.

Thanks in advance

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=232926





--- Comment #12 from Andi Clemens <andi clemens gmx net>  2010-12-04 12:29:53 ---
For me Inpainting "hangs" when I set all sliders to the right in the "General"
tab. But I don't think it actually hangs, it might simply calculate a lot of
stuff.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=232926





--- Comment #13 from Gilles Caulier <caulier gilles gmail com>  2011-12-17 18:48:23 ---
Von,

It still valid using digiKam 2.4 ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=232926

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.3.0                       |2.6.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=232926

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #14 from Gilles Caulier <[hidden email]> ---
*** Bug 301528 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=232926

--- Comment #15 from Gilles Caulier <[hidden email]> ---
Problem with CImg is that library is not maintained anymore. Also, the only
part that digiKam use is GreyStoration algorithm which have been moved in
another lib named Gmic which is complety different.

http://gmic.sourceforge.net/

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=232926

--- Comment #16 from Gilles Caulier <[hidden email]> ---
Git commit cf96fce25a846afe8cae287f0a8a6757481be769 by Gilles Caulier.
Committed on 28/08/2012 at 14:19.
Pushed by cgilles into branch 'master'.

do not start Greystoration based tools imediatly because it take a while. User
must press Try button explicitly to show preview
Related: bug 304002

M  +0    -1    imageplugins/enhance/inpaintingtool.cpp
M  +0    -1    imageplugins/enhance/restorationtool.cpp

http://commits.kde.org/digikam/cf96fce25a846afe8cae287f0a8a6757481be769

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=232926

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #17 from Gilles Caulier <[hidden email]> ---
Marcel,

This one is fully reproducible with current implementation. filter cannot be
cancelled. It sound like it work in a loop for a while.

Can you reproduce ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel