[Bug 229574] New: Moving tags doesn't update the "tag counter" next to the tag name

https://bugs.kde.org/show_bug.cgi?id=229574

           Summary: Moving tags doesn't update the "tag counter" next to
                    the tag name
           Product: digikam
           Version: unspecified
          Platform: Archlinux Packages
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:            (using KDE 4.4.1)
OS:                Linux
Installed from:    Archlinux Packages

The tag counter next to the tag name in the tag folder view is not updated when
the tag is moved to another position / parent.

The counter reads "0" until digiKam is restarted.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=229574


Andi Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Tags
            Version|unspecified                 |1.3.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=229574


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #1 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-03-06 14:51:45 ---
Johannes, I remember you have done some changes to AlbumManager to cache the
result of the count maps. This should have fixed problems like this?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=229574





--- Comment #2 from Johannes Wienke <languitar semipol de>  2010-03-06 16:54:50 ---
I don't know what's going on here. Need to have a look at this but currently I
don't have that much time any more as I started working on my master thesis.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=229574


Johannes Wienke <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #3 from Johannes Wienke <languitar semipol de>  2010-03-06 18:15:05 ---
SVN commit 1100051 by jwienke:

Update tag count after moving.

Marcel, can this be a performance problem? For me this was nearly instant. The
thing is, normally we know the counts before moving, so we could manipulate the
count map directly, but this is the more safe way to my mind.

CCMAIL: [hidden email]
BUG: 229574

 M  +2 -4      NEWS  
 M  +3 -0      digikam/albummanager.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1100051

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=229574





--- Comment #4 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-03-07 13:22:52 ---
The tag map should not be changed at all when moving, shouldn't it? So there is
no need to update the map from AlbumManager, if I did not miss something.
But yes, the parents in the model need to re-count their children.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=229574





--- Comment #5 from Johannes Wienke <languitar semipol de>  2010-03-07 13:26:10 ---
I don't know. ;) I didn't really look into how this is computed. So you mean
this is more an issue of AbstractCountingAlbumModel?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=229574





--- Comment #6 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-03-07 14:25:20 ---
SVN commit 1100402 by mwiesweg:

No need to regenerate the map (which can be costly) but
just update the state with the stored map.

CCBUG: 229574

 M  +0 -3      digikam/albummanager.cpp  
 M  +15 -3     libs/models/abstractalbummodel.cpp  
 M  +4 -0      libs/models/abstractalbummodel.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1100402

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=229574

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |1.2.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel