[Bug 229340] New: Digikam Crashes When Saving PNG Files

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=229340





--- Comment #20 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-04-03 15:49:30 ---
Ok, this is the problem. I cannot test this case because I cannot easily
upgrade libpng.
One thing to try is replacing PNG_ITXT_COMPRESSION_zTXt with
PNG_ITXT_COMPRESSION_NONE
If this doesn't help I will comment out this section until someone finds the
problem.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=229340





--- Comment #21 from Gilles Caulier <caulier gilles gmail com>  2010-04-03 15:50:43 ---
Marcel,

Yes, i written this code embeded lead digiKam comments as UTF8 string png
chunk. Code have been written when libPNG 1.2.x been in production. In this
version libpng do not suport utf8 text chunk. Has now libPNG 1.4.x is out, this
code is used as well.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=229340





--- Comment #22 from François Rey <kde org francois rey name>  2010-04-03 17:36:07 ---
So would the solution be a compiler flag that controls such feature?
Then each distro would be able to compile against their version of libpng.
Arch is 1.4.1, Ubuntu 1.3, etc...

Also, why does the bug disappear when digikam is compiled with debugfull?
Are the resulting PNG safe to use?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=229340





--- Comment #23 from Scott <sajmmiller yahoo com>  2010-04-03 23:24:34 ---
(In reply to comment #20)
> Ok, this is the problem. I cannot test this case because I cannot easily
> upgrade libpng.

I'm also wondering why -DCMAKE_BUILD_TYPE=debugfull eliminates the bug. Does it
cause the problematic section of code to be skipped somehow?

> One thing to try is replacing PNG_ITXT_COMPRESSION_zTXt with
> PNG_ITXT_COMPRESSION_NONE
> If this doesn't help I will comment out this section until someone finds the
> problem.

I searched for the code string you referenced and found it in pngloader.cpp. I
guess I should have been able to figure that out from the trace...this is
learning experience for me. Anyway, I replaced PNG_ITXT_COMPRESSION_zTXt with
PNG_ITXT_COMPRESSION_NONE, recompiled, and the bug remains.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=229340





--- Comment #24 from Scott <sajmmiller yahoo com>  2010-04-04 01:43:53 ---
I commented out the problematic code in pngloader.cpp (listed in comment #17
above) and everything seems to work fine.

For future reference, I'd still be very interested to know why
-DCMAKE_BUILD_TYPE=debugfull bypassed the bug if anyone has the time to
explain.

Thanks everyone!

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=229340





--- Comment #25 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-04-04 15:50:21 ---
Gilles, is it ok to comment out this part? Or does any developer have libpng
1.4 for testing?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=229340





--- Comment #26 from Gilles Caulier <caulier gilles gmail com>  2010-04-04 16:17:12 ---
yes, it's ok.

In fact Exiv2 will write UTF8 comments to dedicated png text chunk.

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=229340





--- Comment #27 from Johannes Wienke <languitar semipol de>  2010-04-04 21:05:55 ---
I got 1.4 running but I didn't get a crash so far.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=229340


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|VERIFIED                    |RESOLVED
         Resolution|BACKTRACE                   |FIXED




--- Comment #28 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-04-04 23:34:49 ---
SVN commit 1111120 by mwiesweg:

Comment out section causing crash

BUG:  229340

 M  +3 -2      pngloader.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1111120

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=229340


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #29 from Gilles Caulier <caulier gilles gmail com>  2010-04-05 12:55:33 ---
Nicolas,

Another little patch which can be applied against digiKam 1.2.0 tarball

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=229340


Johannes Wienke <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #30 from Johannes Wienke <languitar semipol de>  2010-08-15 11:40:03 ---
*** Bug 247908 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=229340


Johannes Wienke <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #31 from Johannes Wienke <languitar semipol de>  2010-08-15 11:42:44 ---
*** Bug 231631 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=229340





--- Comment #32 from Giuseppe Vinci <giuseppe vinci gmx net>  2010-09-26 18:50:21 ---
Created an attachment (id=52006)
 --> (http://bugs.kde.org/attachment.cgi?id=52006)
New crash information added by DrKonqi

Crash happned as I tried to save resized part of picture

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=229340


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #33 from Gilles Caulier <caulier gilles gmail com>  2010-11-08 07:27:14 ---
*** Bug 256330 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=229340

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |1.3.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=229340

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|1.3.0                       |1.2.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=229340

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|ImageEditor                 |FilesIO-PNG

--
You are receiving this mail because:
You are the assignee for the bug.