[Bug 226504] New: when moving assigned tag in the keywords hierachy it becomes unassigned

https://bugs.kde.org/show_bug.cgi?id=226504

           Summary: when moving assigned tag in the keywords hierachy it
                    becomes unassigned
           Product: digikam
           Version: unspecified
          Platform: Ubuntu Packages
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           Version 1.2.0 (rev.: 1086154) (using KDE 4.3.2)
OS:                Linux
Installed from:    Ubuntu Packages

When moving a tag assigned to image in the right sidepanel Caption/Tags it
becomes unassigned.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=226504


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|general                     |Tags
            Version|unspecified                 |1.2.0




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2010-02-12 12:00:28 ---
Do you use drag & drop ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=226504





--- Comment #2 from Johannes Wienke <languitar semipol de>  2010-02-12 12:04:49 ---
Marcel, I think this is a bug in the tag model, or what do you think?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=226504





--- Comment #3 from  <terri bugs mymail fi>  2010-02-12 12:24:55 ---
Yes, I use drag & drop.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=226504





--- Comment #4 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-02-17 17:53:12 ---
The problem is that model/view has no real idea of "moving". Therefore, when
moving a tag, we first delete on the previous position and then add at the next
position.
Currently, the checkable model as well as the MetadataHub clear state in the
signalAlbumAboutToBeDeleted. They should not if this is part of a move
operation - in this case, the TAlbum* object and tag id is preserved.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=226504





--- Comment #5 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-02-17 17:59:57 ---
SVN commit 1091831 by mwiesweg:

Provide information if an album is being moved.
In this case, state can be preserved because the object will not be deleted.

CCBUG: 226504

 M  +12 -1     albummanager.cpp  
 M  +15 -1     albummanager.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1091831

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=226504





--- Comment #6 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-02-17 18:00:06 ---
SVN commit 1091832 by mwiesweg:

For the time being (until there is a thread-safe tag cache at a low level)
we must look after the MetadataHub and notify it when tags are removed.
This code was already added for 1.0, got lost during the model/view merge, but
we got crash reports for 1.0-beta5, 1.0.0, 1.1.0, and 1.2.0-svn.
So I cannot be sure that this fully fixes 214340.

CCBUG: 226504
CCBUG: 214340

 M  +17 -0     imagedescedittab.cpp  
 M  +2 -0      imagedescedittab.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1091832

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=226504





--- Comment #7 from  <terri bugs gmx com>  2010-02-18 13:32:12 ---
Should the above modifications have solved the problem of moving a tag in the
hierarchy? Because tags still become unassigned in svn 1092129 if they are
moved.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=226504


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #8 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-02-18 17:29:22 ---
Yes, they are supposed to fix this and they do it for me...
Am I testing a different case? I take a picture, the tree view in the
comments/tags tab on the right, and move assigned tags to a different parent.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=226504





--- Comment #9 from  <terri bugs gmx com>  2010-02-18 17:48:45 ---
Yes, you seem to be testing the same case. However, it still doesn't work for
me.

Example, I have tags test/test2 and test3. I apply the tag test/test2 to an
image and then move the tag test2 under test3. Result: test2 becomes
unassigned.
The hierarchy at the end is test, test3/test2.

Also digikam doesn't seem to acknowledge the moving of a tag as a change that
should be written to the file. If one moves a tag in the hierarchy the tick in
the Apply -button remains grey (it doesn't change color to green). At least
that happens with me.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=226504





--- Comment #10 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-02-20 15:35:01 ---
I confirm that moving a tag currently does not enable the "Apply" button.
But the rest works for me.

Perhaps, Johannes or Gilles, can you test this?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=226504





--- Comment #11 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-02-20 16:17:38 ---
uh-uh, sorry. I forgot to commit one important piece.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=226504





--- Comment #12 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-02-20 16:21:40 ---
SVN commit 1093300 by mwiesweg:

Preserve check state if album is moved

CCBUG: 226504

 M  +3 -1      abstractalbummodel.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1093300

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=226504


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #13 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-03-17 21:46:35 ---
Assuming it's fixed

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=226504

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |1.2.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel