[Bug 225723] New: simple sharpen is awfully slow

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=225723

           Summary: simple sharpen is awfully slow
           Product: digikam
           Version: unspecified
          Platform: Archlinux Packages
        OS/Version: unspecified
            Status: NEW
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           trunk (using KDE 4.3.4)
Installed from:    Archlinux Packages

The code for the simple sharpen tool is awfully slow and takes ages to compute
a single image or even a really small preview region.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=225723


Johannes Wienke <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Image Editor
            Version|unspecified                 |1.2.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=225723


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|Image Editor                |general
            Product|digikam                     |digikamimageplugins




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=225723


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Sharpen




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=225723





--- Comment #1 from Andi Clemens <andi clemens gmx net>  2011-03-09 11:24:27 ---
The same for the blur filter... it was faster before, but somehow we removed
the cimg functionality again. CImg was up to 10 times faster...

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=225723


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #2 from Gilles Caulier <caulier gilles gmail com>  2011-11-16 14:30:13 ---
*** Bug 278540 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=225723





--- Comment #3 from Gilles Caulier <caulier gilles gmail com>  2011-11-16 14:31:17 ---
Andi,

If you have an algorithm faster to include in source code, let's me hear.

The current one, if i remember, come from gimp...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andi Clemens]

https://bugs.kde.org/show_bug.cgi?id=225723





--- Comment #4 from Andi Clemens <andi clemens googlemail com>  2011-11-16 21:33:59 ---
I don't know any algorithm from scratch, but I changed blur and sharpen to the
CImg version back in 2009. We removed it again, but why...? I can not remember.

Andi

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=225723





--- Comment #5 from Gilles Caulier <caulier gilles gmail com>  2011-11-17 06:55:11 ---
For 2 reasons :

1/ CImg algorithm is not cancellable. It's mandatory in editor, especially if
large image are processed.
2/ CImg API is deprecated. CImg.h is old now in digiKam core. CImg have been
forked in GMic project which break whole API/ABI. For that, we have a problem
with all Greystoration tools in digiKam. We need to port all to GMic, and it's
not simple.

Some algorithm can be taken in ImageMagick for ex. This one support already 16
bits color depth. I already do that with unsharp-mask algorithm.

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=225723

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Version Fixed In|                            |4.3.0
             Status|CONFIRMED                   |RESOLVED

--- Comment #6 from Gilles Caulier <[hidden email]> ---
This entry is fixed since 4.2.0 release due to use Multicore support with Sharp
algorithm.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=225723

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|digikamimageplugins         |digikam
          Component|Sharpen                     |Tool-Sharpen

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel