[Bug 224052] New: Pressing Delete repeatedly is not cached

https://bugs.kde.org/show_bug.cgi?id=224052

           Summary: Pressing Delete repeatedly is not cached
           Product: digikam
           Version: unspecified
          Platform: Unlisted Binaries
        OS/Version: unspecified
            Status: NEW
          Severity: wishlist
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:            (using KDE 4.3.4)
Installed from:    Unspecified Linux

When the user presses Delete in the View mode N times, he expects N photos to
be deleted. He can make this decision because the filmstrip shows him the next
few photos. However, instead of caching the Delete function, Digikam tries to
delete the deleted photo, leading to an error "XYZ photo does not exist".

Steps to reproduce:
1) In View mode press Delete repeatedly

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=224052


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|general                     |Albums GUI
            Version|unspecified                 |1.1.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=224052


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #1 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-01-24 20:14:03 ---
You mean the mode where one image is large with a thumbnail bar at the bottom?
This does not apply when in the icon view mode, does it?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=224052





--- Comment #2 from Johannes Wienke <languitar semipol de>  2010-01-24 20:17:31 ---
I also noticed this in the icon view. Simply press delete two times with fast
speed there.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=224052





--- Comment #3 from Dotan Cohen <kde-51 dotancohen com>  2010-01-24 20:22:31 ---
> You mean the mode where one image is large
> with a thumbnail bar at the bottom?

Yes.


> This does not apply when in the icon view
> mode, does it?

I can reproduce there as well.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=224052





--- Comment #4 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-01-24 20:27:07 ---
Ok. I assume the problem is this:
- first delete
- KDE process started to delete file
- file is deleted
- **
- digikam is notified that something happened
- digikam triggers scanning
- scanning is done, database is updated
- view is notified about change
- album listing is started
- **
- album listing results are received in main thread, view is updated

When pressing delete in the time between the **, the described behavior will
occur.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=224052





--- Comment #5 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-01-24 20:27:47 ---
The easiest solution would be to move the focus on to the next item when
pressing delete?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=224052





--- Comment #6 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-01-26 22:56:35 ---
SVN commit 1080759 by mwiesweg:

When deleting images, move to the next index.

CCBUG: 224052

 M  +31 -1     digikamimageview.cpp  
 M  +5 -3      imageviewutilities.cpp  
 M  +1 -1      imageviewutilities.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1080759

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=224052





--- Comment #7 from Gilles Caulier <caulier gilles gmail com>  2010-01-28 09:15:33 ---
Dotan,

Please test and report using code from svn trunk. I would to close this file
for 1.1 release

Thanks in advance

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=224052





--- Comment #8 from Dotan Cohen <kde-51 dotancohen com>  2010-01-28 15:45:09 ---
I'm in dependency hell, Gilles, and I won't be testing this SVN, sorry. But
this issue should be easy to test: just click Delete three times quickly, and
check that three photos were deleted without an error being thrown.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=224052


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #9 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-03-22 21:44:21 ---
Suggested test successful (item do not disappear immediately, but cursor moves
to next entry, so three key pressed will delete three images)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=224052





--- Comment #10 from Johannes Wienke <languitar semipol de>  2010-03-22 21:52:40 ---
I'm still not convinced that this is a solution that fulfills the user's
expectations. If I'm pressing delete I expect an immediate response of the GUI
with removing the selected items. If this is not possible, a progress dialog
should appear.

Can't we hide the items immediately after pressing delete and unhide them in
case the kde deletion progress reports an error?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=224052





--- Comment #11 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-03-26 17:00:16 ---
On which level should we filter out the deleted images? Filter model? I agree
that the current behavior is not good, it's simply to long until the images are
removed.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=224052





--- Comment #12 from Johannes Wienke <languitar semipol de>  2010-03-26 21:43:59 ---
Would it be possible to put this in an extra filter model
(DeleteHidingFilterModel) that only does this one thing so it can be reused?
This filter model could simply "intercept" the delete action and hide all
selected items immediately until they disappear from the core model or
re-enable them on an error.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=224052





--- Comment #13 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-03-27 16:28:15 ---
This can be a lot of work because the view expects an ImageFilterModel which
expects and ImageModel. It may be easier to extend the ImageFilterModel.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=224052





--- Comment #14 from Johannes Wienke <languitar semipol de>  2010-03-27 16:31:09 ---
But then it cannot be reused for the eg. the tree views.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=224052

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |1.2.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel