[Bug 221918] New: Wrong thumbnails after save as

https://bugs.kde.org/show_bug.cgi?id=221918

           Summary: Wrong thumbnails after save as
           Product: digikam
           Version: unspecified
          Platform: Ubuntu Packages
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           1.1.0 rev 1055453 (using KDE 4.3.2)
OS:                Linux
Installed from:    Ubuntu Packages

Using 1.1.0 rev 1055453.

When using save as the thumbnail of the saved picture is the orginal thumbnail
instead of the edited version of the picture.

Step to reproduce:
- open a jpeg file "toto.jpg" in the editor
- convert it to black and white (it should behave the same way for other filter
I think but it is easier to see the bug with a modification which is obvious)
- save as a new file (png or jpeg) ("toto2.jpg")
- close the editor

-> The thumbnail of toto2 is the thumbnail of the original toto.jpg instead of
the black and white picture.

Julien

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=221918





--- Comment #1 from Julien Narboux <Julien narboux fr>  2010-01-09 14:53:55 ---
Created an attachment (id=39711)
 --> (http://bugs.kde.org/attachment.cgi?id=39711)
Snapshot which shows that the thumbnail is the wrong one

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=221918


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|general                     |Thumbnails
            Version|unspecified                 |1.1.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=221918


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #2 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-01-09 21:30:02 ---
I could indeed reproduce that in one out of four attempts.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=221918





--- Comment #3 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-01-09 22:07:52 ---
One important question: Is the thumbnail still wrong after a restart of
digikam?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=221918





--- Comment #4 from Julien Narboux <Julien narboux fr>  2010-01-09 22:36:23 ---
Marcel,

Good guess ! the thumbnail is the right one after a restart of Digikam.

I also noticed that I used save as png file and whereas I had enabled sort by
file type view, the new picture has been added in the JPG section instead of
png section of the thumbnail view. After a restart this was fixed as well.

Julien

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=221918





--- Comment #5 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-01-23 21:33:06 ---
No good idea currently.
I plan to rewrite the thumbbar with model/view for 1.2. I will revisit this bug
then.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=221918





--- Comment #6 from Julien Narboux <Julien narboux fr>  2010-01-25 08:52:39 ---
Marcel,

I do not think this is related to thumbar. The wrong thumbnails also appear in
the 'normal' view.

Julien

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=221918





--- Comment #7 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-02-22 22:03:49 ---
I have incidentally found the problem here: We use ImageInfo.copyItem, which is
meant for a simple copy. It also copies the unique hash, so the thumbnail for
the original image is used. After a collection scan (restart) this is
corrected.

I need to fix that by removing usage of copyItem and instead more selectively
copy the needed fields.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=221918





--- Comment #8 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-02-27 15:36:07 ---
SVN commit 1096751 by mwiesweg:

Add methods to copy all appropriate properties from source to derived image.
Every copied field is explicitly selected.
This differs from copyItem, which just copies everything and should not be
used.

CCBUG: 221918

 M  +25 -12    collectionscanner.cpp  
 M  +12 -4     collectionscanner.h  
 M  +34 -0     imagescanner.cpp  
 M  +10 -0     imagescanner.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1096751

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=221918


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #9 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-02-27 15:36:30 ---
SVN commit 1096752 by mwiesweg:

Add a method to ScanController that scans an image directly
and then copies the relevant attributes of another image to it.
When creating a new image in the image editor use this functionality.

BUG: 221918

 M  +2 -1      NEWS  
 M  +14 -0     digikam/scancontroller.cpp  
 M  +6 -0      digikam/scancontroller.h  
 M  +3 -1      utilities/imageeditor/editor/imagewindow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1096752

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=221918

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |1.2.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel