[Bug 221460] New: Xmp subject tags imported in wrong order

https://bugs.kde.org/show_bug.cgi?id=221460

           Summary: Xmp subject tags imported in wrong order
           Product: digikam
           Version: unspecified
          Platform: Ubuntu Packages
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           1.0.0 karmic-backports (using KDE 4.3.4)
OS:                Linux
Installed from:    Ubuntu Packages

I have a JPEG file with the following XMP tags, among others:

Xmp.lr.hierarchicalSubject                   XmpBag      1
Personer|Familj|Jonatan
Xmp.dc.subject                               XmpBag      3  Familj, Jonatan,
Personer

When digiKam imports this photo it does not appear to read
Xmp.lr.hierarchicalSubject, but instead Xmp.dc.subject. All tags (Familj,
Jonatan, Personer) are checked in the keywords panel.

In DMetadata::getImageTagsPath
(http://lxr.kde.org/source/extragear/graphics/digikam/libs/dmetadata/dmetadata.cpp#569),
it appears that the intention is to read ONE of the following, in this order:
- Xmp.digikam.TagsList (not found in my JPEG)
- Xmp.lr.hierarchicalSubject (in my JPEG)
- Xmp.dc.subject (in my JPEG)
- Iptc.Application2.Keywords (also in my JPEG)

Is the Xmp.dc.subject read at some other place than in this function?

If I delete the Xmp.dc.subject tag, my hierarchical keywords are read correctly
from Xmp.lr.hierarchicalSubject, and only Personer/Familj/Jonatan is checked in
the keywords panel.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=221460


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Metadata
            Version|unspecified                 |1.0.0




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2010-01-06 09:51:11 ---
No only this code is used to play with metadata. The proof : if you comment
right line, it's work.

I suspect a bug in this code. Simple...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=221460





--- Comment #2 from Gilles Caulier <caulier gilles gmail com>  2010-01-06 09:53:34 ---
Can you attach a JPEG file to test on my computer ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=221460





--- Comment #3 from Jakob Malm <jakob malm gmail com>  2010-01-06 10:30:11 ---
Created an attachment (id=39605)
 --> (http://bugs.kde.org/attachment.cgi?id=39605)
JPEG with both Xmp.lr.hierarchicalSubject and Xmp.dc.subject

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=221460





--- Comment #4 from Jakob Malm <jakob malm gmail com>  2010-01-06 10:31:14 ---
Created an attachment (id=39606)
 --> (http://bugs.kde.org/attachment.cgi?id=39606)
JPEG with only Xmp.dc.subject

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=221460





--- Comment #5 from Jakob Malm <jakob malm gmail com>  2010-01-06 10:32:44 ---
Created an attachment (id=39607)
 --> (http://bugs.kde.org/attachment.cgi?id=39607)
JPEG with only Xmp.lr.hierarchicalSubject

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=221460





--- Comment #6 from Jakob Malm <jakob malm gmail com>  2010-01-06 10:45:09 ---
I feel a bit embarrassed now... (blush) These photos actually imported
correctly. Could it be that I had not imported these photos before? With the
photos I previously tested I did a lot of importing/deleting... Sorry, it
doesn't quite make sense to me at the moment. I will see if I can make some
more sense and post back.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=221460





--- Comment #7 from Gilles Caulier <caulier gilles gmail com>  2010-01-06 11:18:31 ---
yes, perhaps, and it can be another problem.

To be sure, it's simple : create a new account in your computer and start
digiKam to create an empty database. Now import your pictures...

The database file is digikam4.db. To re-test later in the same condition with
this dummy user account, just remove this file and start again digiKam.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=221460


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #8 from Gilles Caulier <caulier gilles gmail com>  2010-01-06 14:21:00 ---
Sorry, i cannot reproduce the problem there with JPG image including
Xmp.lr.hierarchicalSubject and Xmp.dc.subject. Importing to a new folder and
LightRoom tag path is properly imported to digiKam database

Look my screenshots here :

http://farm3.static.flickr.com/2698/4250320461_e504a55063_o.png

http://farm5.static.flickr.com/4043/4250320541_5d7639d4d2_o.png

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=221460





--- Comment #9 from Sebastian Schubert <schubert seb gmail com>  2010-01-07 11:48:47 ---
Created an attachment (id=39646)
 --> (http://bugs.kde.org/attachment.cgi?id=39646)
jpg with HierarchicalSubject and "plain" subject

I have a similar problem. Tested with a clean (ie after removing digikamrc and
database) configuration with 1.0_beta6. Attached is the problem jpg.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=221460





--- Comment #10 from Sebastian Schubert <schubert seb gmail com>  2010-01-07 11:49:34 ---
Created an attachment (id=39647)
 --> (http://bugs.kde.org/attachment.cgi?id=39647)
Screenshot showing the problem

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=221460





--- Comment #11 from Gilles Caulier <caulier gilles gmail com>  2010-01-07 13:09:42 ---
Sebastian,

Please update :

digiKam to 1.0.0 final
Exiv2 to 0.18.2 or 0.19
libkexiv2 to 1.0.0 (KDE 4.4 beta or checkout code from trunk, recompile and
install)

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=221460





--- Comment #12 from Gilles Caulier <caulier gilles gmail com>  2010-01-07 13:25:03 ---
I _LOVE_ Adobe, or ... BibblePro.

Look difference of XMP LightRoom tags from attached images :

[gilles@localhost BKO221460]$ exiv2 -px *.jpg |grep ierarchicalSubject

20100101-001328-01.jpg  Xmp.lr.HierarchicalSubject                   XmpSeq    
 2  Silvester|Feuerwerk, Level1|Level2|Level3

both.jpg              Xmp.lr.hierarchicalSubject                   XmpBag    
1  Bottom|Middle|Top

First one is Sequence of string, tag name is HierarchicalSubject

Second one is a Bag of strings, tag name is hierarchicalSubject

Really a nice puzzle...

I love closed source software !

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=221460





--- Comment #13 from Gilles Caulier <caulier gilles gmail com>  2010-01-07 13:55:00 ---
Fixed in my computer now :

digikam(2813)/digikam (core) Digikam::DImg::load:
"/mnt/data/photo/test/BKO221460-1/20100101-001328-01.jpg"  : JPEG file
identified          
digikam(2813)/digikam (core) Digikam::ImageScanner::addImage: Adding new item
"/mnt/data/photo/test/BKO221460-1/20100101-001328-01.jpg"      
tagsPath:  ("Silvester|Feuerwerk", "Level1|Level2|Level3")                      
digikam(2813)/digikam (core) Digikam::DMetadata::getImageTagsPath: Tags Path
imported from LR:  ("Silvester/Feuerwerk", "Level1/Level2/Level3")              
digikam(2813)/digikam (core) Digikam::DImg::load:
"/mnt/data/photo/test/BKO221460-1/both.jpg"  : JPEG file identified            
digikam(2813)/digikam (core) Digikam::ImageScanner::addImage: Adding new item
"/mnt/data/photo/test/BKO221460-1/both.jpg"                    
tagsPath:  ("Bottom|Middle|Top")                                                
digikam(2813)/digikam (core) Digikam::DMetadata::getImageTagsPath: Tags Path
imported from LR:  ("Bottom/Middle/Top")

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=221460


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #14 from Gilles Caulier <caulier gilles gmail com>  2010-01-07 13:57:00 ---
SVN commit 1071060 by cgilles:

LR xmp tags list can be hosted to both different way : XMPBag or XMPSeq
BUGS: 221460


 M  +5 -0      dmetadata.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1071060

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=221460


Sebastian Schubert <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #15 from Sebastian Schubert <schubert seb gmail com>  2010-01-07 14:16:46 ---
Thanks for the very fast fix!

Just FYI, apparently bibble guys consider their behaviour a bug:
http://support.bibblelabs.com/forums/viewtopic.php?f=67&t=15530

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=221460





--- Comment #16 from Jakob Malm <jakob malm gmail com>  2010-01-07 14:26:48 ---
Just to clarify:

The JPEGs I attached were CHANGED by me, in order for digiKam to read the tag.
The output from Bibble 5 is (currently) to Xmp.lr.HierarchicalSubject XmpSeq.

Sebastian, I assume your JPEG was created by Bibble 5?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=221460





--- Comment #17 from Jakob Malm <jakob malm gmail com>  2010-01-07 14:32:19 ---
(In reply to comment #15)
> Thanks for the very fast fix!

From me too!

> Just FYI, apparently bibble guys consider their behaviour a bug:
> http://support.bibblelabs.com/forums/viewtopic.php?f=67&t=15530

That was me... ;-)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=221460





--- Comment #18 from Sebastian Schubert <schubert seb gmail com>  2010-01-07 15:28:21 ---
(In reply to comment #16)
> Sebastian, I assume your JPEG was created by Bibble 5?

Yup.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=221460





--- Comment #19 from Gilles Caulier <caulier gilles gmail com>  2010-01-07 15:51:04 ---
Sebastian,

If i understand Bibble report,  Xmp.lr.hierarchicalSubject as an XMP Bag is the
right way to use.

I ask this question because digiKam also export tags path in this tags for
interoperability, and of course as a bag, not a sequence.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel