[Bug 221113] New: RW2 images are not rotated anymore

[S. Burmeister]

https://bugs.kde.org/show_bug.cgi?id=221113

           Summary: RW2 images are not rotated anymore
           Product: digikam
           Version: unspecified
          Platform: openSUSE RPMs
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           svn Rev: 1069274 (using KDE 4.3.4)
OS:                Linux
Installed from:    openSUSE RPMs

After 1.0.0 the rotation of RW2 files broke, i.e. if I process them in the  BQM
with "convert to jpeg" they do not get rotated anymore although the RW2 files
(thumbnails) are shown rotated in digikam's album view.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=221113


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |RAW files management




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2010-01-03 15:25:52 ---
Raw thumbnails are generated using JPEG embeded in Raw container. there are not
relevant of Raw image data.

Rotation can be different for both. Yes, it's a shame, but there is not
rotation information for jpeg _and_ raw. It's the same flags for both.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=221113


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|RAW files management        |Thumbnails
            Version|unspecified                 |1.0.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=221113


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #2 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-01-03 16:33:22 ---
Can you provide a sample picture?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

["Jens Müller"]

https://bugs.kde.org/show_bug.cgi?id=221113


Jens Mueller <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #3 from Jens Mueller <tschenser gmx de>  2010-01-03 21:39:48 ---
I can confirm this also for my NEF's. The results from BQM are:
convert to jpeg: rotated, but exif is the same as original (wrong)
convert to png: rotated, but exif is the same as original (wrong)
convert to tiff: rotated, exif set to normal (right)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

["Jens Müller"]

https://bugs.kde.org/show_bug.cgi?id=221113





--- Comment #4 from Jens Mueller <tschenser gmx de>  2010-01-03 22:00:59 ---
I think this one is caused by https://bugs.kde.org/show_bug.cgi?id=202278. Do
convert tools need a setNeedResetExifOrientation(true) to?

Jens

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=221113





--- Comment #5 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-01-07 22:15:37 ---
RAW files are autorotated by dcraw already. Currently looking at
dimginterface.cpp:351, where only for JPEG, PNG and TIFF the Exif flag is used
at all. I'm not sure if that is correct, e.g. for JPEG2000 or PGF.

At least it seems that when having a fully loaded RAW (not a preview) and
saving that in a different format, for which the exif flag is honoured, the
metadata cannot just be copied, the flag must be reset.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=221113





--- Comment #6 from Gilles Caulier <caulier gilles gmail com>  2010-01-08 10:40:37 ---
>I'm not sure if that is correct, e.g. for JPEG2000 or PGF.

Yes, it is for JP2 and PGF

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=221113





--- Comment #7 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-01-08 16:37:55 ---
Sorry Gilles... ;-)
It is correct or it is not correct to ignore the Exif rotation flag for
JPEG2000 and PGF?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=221113


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #8 from Gilles Caulier <caulier gilles gmail com>  2010-01-09 14:02:02 ---
JPEG2000 support Exif and XMP offcially. You must check rotation flag here.

For PGF, Exif is supported through Exiv2 0.19 now, with my patch. Same way...

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=221113





--- Comment #9 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-01-09 16:10:55 ---
SVN commit 1072176 by mwiesweg:

Rotate by exif orientation for all images except RAWs.
Previously, this was restricted to JPG/PNG/TIFF.

CCBUG: 221113

 M  +4 -17     dimginterface.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1072176

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=221113





--- Comment #10 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-01-09 17:23:53 ---
SVN commit 1072206 by mwiesweg:

Reset exif orientation, regardless if the tools requested that, if
the DImg was loaded from RAW.
(it's done similarly in the image editor, where a flag is set that the image
was rotated if it is RAW, and subsequently the orientation is reset)

CCBUG: 221113

 M  +1 -1      imageeditor/canvas/dimginterface.cpp  
 M  +6 -5      queuemanager/batchtool.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1072206

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=221113





--- Comment #11 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-01-09 17:38:43 ---
Everyone here, can you test if this is fixed now for your usecase?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

["Jens Müller"]

https://bugs.kde.org/show_bug.cgi?id=221113





--- Comment #12 from Jens Mueller <tschenser gmx de>  2010-01-09 17:52:49 ---
- converting RAW is fine for me (tested jpg & tiff & png)
- converting a jpg with exif-rotation flag set, the rotation flag is not
preserved in tiff

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=221113


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #13 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-01-09 21:17:05 ---
TIFF is a different problem, metadata writing is disabled for now, bug 211758.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

["Jens Müller"]

https://bugs.kde.org/show_bug.cgi?id=221113





--- Comment #14 from Jens Mueller <tschenser gmx de>  2010-01-09 21:20:55 ---
ok, beside the tiff issue everthing is fine for me

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=221113

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |1.1.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=221113

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Thumbs-Image                |Thumbs-RAW

--
You are receiving this mail because:
You are the assignee for the bug.