[Bug 220739] New: Image Editor shows sidebar after applying effect in full screen mode

[Simon-2]

https://bugs.kde.org/show_bug.cgi?id=220739

           Summary: Image Editor shows sidebar after applying effect in
                    full screen mode
           Product: digikam
           Version: unspecified
          Platform: unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           1.1.0 (rev.: 1066990) (using 4.3.4 (KDE 4.3.4), Debian
packages)
Compiler:          cc
OS:                Linux (i686) release 2.6.32-2.slh.3-sidux-686

Reproduce:
* Open picture in Image Editor
* Hide sidebar, if visible
* Switch to full screen
* Apply any effect (like Curves Adjust), press Apply
Now the sidebar shows up, even though it has been hidden previously.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220739


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|general                     |Image Editor
            Version|unspecified                 |1.1.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=220739


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #1 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-01-21 19:44:20 ---
Currently in EditorToolIface::loadTool, we just call appendTab and
setActiveTab.
For the full screen case, we would have to store state, maybe add a relevant
method appendSideBarTab to EditorWindow? Not sure how to best do that without
causing side effects.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220739


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
                   |                            |t




--- Comment #2 from Gilles Caulier <caulier gilles gmail com>  2010-10-22 13:28:48 ---
*** Bug 207921 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=220739


Stuart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #3 from Stuart <stuart hodgson gmail com>  2011-01-10 11:49:10 ---
The fullscreen image editor feature would make Digikam my image editor of
choice however with this bug, if you make an edit or cancel one, you're really
out of fullscreen mode because you now have a sidebar. Please, please get this
sorted as the fullscreen mode allows quick editing through the customisable
toolbar, looks great and allows you to maximise your screen to look at the
photo. I love it apart from this bug!

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=220739





--- Comment #4 from Stuart <stuart hodgson gmail com>  2011-11-16 17:19:28 ---
Still getting exactly the same thing on windows xp v2.3 32bit installer...

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Pravesh Gupta]

https://bugs.kde.org/show_bug.cgi?id=220739

Pravesh Gupta <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
                   |                            |n

--- Comment #5 from Pravesh Gupta <[hidden email]> ---
Not able to view this bug, however encountered another bug of this type.

OS : Linux Mint KDE v14
digiKam Version : digiKam 3.2.0-beta2

Steps to Reproduce:-
1)Open ImageEditor.
2)Make Thumbbar visible by checking true to View->Show ThumbBar (CTRL+T).
3)Enter Full Screen Mode (CTRL+SHIFT+F)
4)Exit Full Screen Mode

Result : ThumbBar hides.

Expected Result : ThumbBar should not hide on exiting full screen mode as it
was checked to show previously when screen was not in full screen mode.

Pravesh

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Pravesh Gupta]

https://bugs.kde.org/show_bug.cgi?id=220739

--- Comment #6 from Pravesh Gupta <[hidden email]> ---
In Addition to my previous comment (comment #5) :-

Through the steps defined, the right sideBar(Properties etc.) also hides for
permanent for permanent in Normal Screen Mode.
However, it is shown in Full Screen Mode of Image Editor but never in Normal
Screen Mode. Even if we close the Image Editor and start Image Editor with the
other images from the parent digikam window, this happens.

The only way to show right side bar image Editor(in normal mode, not in Full
Screen Mode) is to restart digikam.

*This whole behaviour is also noticed in ShowFoto.

Pravesh

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220739

--- Comment #7 from Gilles Caulier <[hidden email]> ---
Pravesh,

I must admit that fullscreen mode is a little bit bugous. This is true in all
digiKam main windows (albumgui, LT, BQM, Import, etc...)

This must be review in-deep and code which manage full screen mode in all
KXmlGuiWindow classes based (listed below) must be factored in common wrapper
to reduce code duplication. This wrapper must take a care about full screen
mode settings from Setup dialog.

digikam/main/digikamapp.cpp:void DigikamApp::slotToggleFullScreen(bool b)
utilities/importui/main/importui.cpp:void ImportUI::slotToggleFullScreen(bool
b)
utilities/queuemanager/main/queuemgrwindow.cpp:void
QueueMgrWindow::slotToggleFullScreen(bool b)
utilities/lighttable/lighttablewindow.cpp:void
LightTableWindow::slotToggleFullScreen(bool b)
utilities/imageeditor/editor/editorwindow.cpp:void
EditorWindow::slotToggleFullScreen(bool b)

Also, in same way that fullscreen mode code must be factored, settings in Setup
GUI must be factored too. No need to duplicated configuration for each main
digiKam windows, when there exist (sometime there is no dedicated settings by
main windows in current implementation)

There are few others dysfunctions about full screen mode, similar to this one.
We must take a consideration off all in this project.

Taking all this constraint, we can build safe implementation to manage
fullscreen mode.

This can be a good exercise for student...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Pravesh Gupta]

https://bugs.kde.org/show_bug.cgi?id=220739

--- Comment #8 from Pravesh Gupta <[hidden email]> ---
Hi Gilles,

Should I include this in my project ?

Pravesh

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220739

--- Comment #9 from Gilles Caulier <[hidden email]> ---
In theory, no. This is not model/view port subject. It's improvements...

This can be a little project outside GoSC 2013, excepted if you think that you
will have time to do it... But i doubt...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Pravesh Gupta]

https://bugs.kde.org/show_bug.cgi?id=220739

--- Comment #10 from Pravesh Gupta <[hidden email]> ---
Hi Guilles,

K, I am not including this, nor factorizing the classes but I will look if I
can fix this bug in Image Editor Window alone.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220739

--- Comment #11 from Gilles Caulier <[hidden email]> ---
ok, this will be a first step

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220739

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Image Editor shows sidebar  |Image Editor shows sidebar
                   |after applying effect in    |after applying effect in
                   |full screen mode            |fullscreen mode

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220739

--- Comment #12 from Gilles Caulier <[hidden email]> ---
Pravesh,

I started to write the wrapper, and i patch Image Editor. This fix some
dysfunctions. but it's not yet completed.

I need to write GUI settings widget, and patch other KXMLGuiWindow classes...

i will commit the patch for Image Editor ASAP. In charge for you to test step
by step when implementation will progress...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220739

--- Comment #13 from Gilles Caulier <[hidden email]> ---
Git commit 73502cc716f1940375d7d805e299d8f93fa58adc by Gilles Caulier.
Committed on 30/04/2013 at 06:02.
Pushed by cgilles into branch 'master'.

Add new FullScreenMngr class dedicated manage full-screen action to digiKam
KXMLGuiWindow instances.
This class factorize a lots of code when window is turned on/off to full-screen
mode.
This fix problem about visibility restoring with status-bar, menu-bar, and
thumb-bar.
First managed digiKam main window is Image Editor.
TODO :
- manage full-screen mode of main windows AlbumGUI, BQM, ImportUI, and LT,
through FullScreenMngr.
- manage visibility of side-bars.
- provide a common settings widget to control visibility management in
Configuration dialog.
- patch Configuration dialog to provide a fine control of visibility management
in full-screen mode for each digiKam main window.
Related: bug 214107, bug 289262, bug 236234, bug 258180, bug 293676

M  +1    -0    CMakeLists.txt
A  +231  -0    libs/widgets/common/fullscreenmngr.cpp     [License: GPL (v2+)]
A  +89   -0    libs/widgets/common/fullscreenmngr.h     [License: GPL (v2+)]
M  +19   -109  utilities/imageeditor/editor/editorwindow.cpp
M  +0    -5    utilities/imageeditor/editor/editorwindow.h
M  +5    -13   utilities/imageeditor/editor/editorwindow_p.h
M  +12   -8    utilities/setup/setupeditor.cpp

http://commits.kde.org/digikam/73502cc716f1940375d7d805e299d8f93fa58adc

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Pravesh Gupta]

https://bugs.kde.org/show_bug.cgi?id=220739

--- Comment #14 from Pravesh Gupta <[hidden email]> ---
Hi Gilles,

Tested the patches.
Works Fine with ImageEditor, ShowFoto, and LightTable.

Something that I noticed is(although not a big problem or a bug), is that when
I switch to Full Screen Mode, show and hide the Left Image ThumbBar, there is
noticeable flickering effect of right Properties ThumbBar(for micro seconds).

Apart  from that all good.
I think this bug is fixed.

Pravesh

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220739

--- Comment #15 from Gilles Caulier <[hidden email]> ---
Only Image Editor and Showfoto are fixed. LT, BQM, AlbumGUI, ImportUI do not
use yet FullScreenMngr. I currently work on it.

Do you take a look on my implementation of this class ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Pravesh Gupta]

https://bugs.kde.org/show_bug.cgi?id=220739

--- Comment #16 from Pravesh Gupta <[hidden email]> ---
Not until now, I only tested it.

Pravesh

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220739

--- Comment #17 from Gilles Caulier <[hidden email]> ---
Git commit cde52bd90737bd8fe2b7dfdb94eba09578549239 by Gilles Caulier.
Committed on 01/05/2013 at 14:19.
Pushed by cgilles into branch 'master'.

Port fullscreen mode from Light Table to FullScreenMngr.
Related: bug 214107, bug 289262, bug 236234, bug 258180, bug 293676

M  +23   -87   utilities/lighttable/lighttablewindow.cpp
M  +1    -3    utilities/lighttable/lighttablewindow.h
M  +3    -8    utilities/lighttable/lighttablewindow_p.h
M  +13   -10   utilities/setup/setuplighttable.cpp
M  +1    -1    utilities/setup/setuplighttable.h

http://commits.kde.org/digikam/cde52bd90737bd8fe2b7dfdb94eba09578549239

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel