[Bug 218297] New: Database location under control panel doesn't match when using database-directory command line option

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=218297

Simon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #104572|0                           |1
        is obsolete|                            |
 Attachment #104573|0                           |1
        is obsolete|                            |

--- Comment #15 from Simon <[hidden email]> ---
Created attachment 104595
  --> https://bugs.kde.org/attachment.cgi?id=104595&action=edit
Add --config option and fix --database-directory

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=218297

Simon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #104595|0                           |1
        is obsolete|                            |

--- Comment #16 from Simon <[hidden email]> ---
Created attachment 104597
  --> https://bugs.kde.org/attachment.cgi?id=104597&action=edit
Add --config option and fix --database-directory

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=218297

--- Comment #17 from Glenn Washburn <[hidden email]> ---
Ok, I think I now understand you correctly and agree there is an issue with my
suggestion.  Cheers!

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=218297

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #18 from [hidden email] ---
*** Bug 267553 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=218297

--- Comment #19 from [hidden email] ---
Simon,

I'm not sure if you take a care about bug #377587 with your current patch.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=218297

--- Comment #20 from [hidden email] ---
Anyway, the patch sound like in the right way. Not yet tested.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=218297

--- Comment #21 from Simon <[hidden email]> ---
I kind of do, but not in the way that is requested. I think it should be
possible (and it is with my patch) to use a config location different than the
database location. So to achieve what 377587 wants you have to specify both
--config and --database-directory with the same path. It can definitely be
closed when this is merged.

This is the second time I get a "patch looks good, but not tested". Does that
mean I should commit if I have tested it (I did) or should I wait for your
final approval?

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=218297

--- Comment #22 from [hidden email] ---
If you have tested, it's fine for me...

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=218297

Simon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.6.0
      Latest Commit|                            |https://commits.kde.org/dig
                   |                            |ikam/e0f1d3dd4056deff260f67
                   |                            |3788af2cc6f9df1033
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #23 from Simon <[hidden email]> ---
Git commit e0f1d3dd4056deff260f673788af2cc6f9df1033 by Simon Frei.
Committed on 18/03/2017 at 15:00.
Pushed by sfrei into branch 'master'.

Add --config option and fix --database-directory option

When database dir is specified at command line, the correct path is displayed
in the configuration widget, but the input field is disabled.
Related: bug 377587
FIXED-IN: 5.6.0

M  +2    -1    NEWS
M  +39   -4    app/main/main.cpp
M  +2    -2    libs/database/utils/dbmigrationdlg.cpp
M  +10   -1    libs/database/utils/dbsettingswidget.cpp
M  +2    -1    libs/database/utils/dbsettingswidget.h
M  +3    -0    libs/settings/applicationsettings.h
M  +10   -0    libs/settings/applicationsettings_miscs.cpp
M  +2    -0    libs/settings/applicationsettings_p.cpp
M  +1    -0    libs/settings/applicationsettings_p.h

https://commits.kde.org/digikam/e0f1d3dd4056deff260f673788af2cc6f9df1033

--
You are receiving this mail because:
You are the assignee for the bug.