[Bug 217598] New: detect image type to save according to extension

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 217598] New: detect image type to save according to extension

Wolfram Quester-2
https://bugs.kde.org/show_bug.cgi?id=217598

           Summary: detect image type to save according to extension
           Product: digikam
           Version: unspecified
          Platform: Debian testing
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           1.0.0~rc-1 (using KDE 4.3.2)
Compiler:          gcc amd64
OS:                Linux
Installed from:    Debian testing/unstable Packages

If I want to "Save As" in the image editor, and the filter selects jpeg images,
I cannot type "bla.tiff" and the image is saved as tiff. It is still a jpeg
with an irritating name.
This is especially bad, when I edit a 16Bit image, which is then automativally
converted to 8 Bit without noticing.
In pre5, I could type whatever extension I wanted, and the file was saved
properly, at least when the "All images" filter (which no longer exists) was
selected.

For me, the proper behaviour would be to recognise the image type from the
filename extension entered by the user.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 217598] detect image type to save according to extension

Johannes Wienke-3
https://bugs.kde.org/show_bug.cgi?id=217598


Johannes Wienke <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #1 from Johannes Wienke <languitar semipol de>  2009-12-06 16:07:26 ---
There was a problem about the old behaviour: themoment the options that are
special to a selected file type (like jpeg compression) are displayed directly
inside the save dialog. If, eg. the dialog initially states tiff, you change
the extension to jpeg in the filename and save the file with automatic file
type detection based on the extension, you end up with unpredictable options
for the generated jpeg, because you never saw the options for jpeg in the
dialog.

I think there are two solutions to solve this problem if and automatic
detection based on the filename is needed:

1. doing the automatic detection while typing the filename and adjusting the
file type settings every time a new type is detected by the extension. But this
could result in strange flickering of the dialog while typing.
2. Use two step procedure: First type the file name and after confirming the
dialog show a separate window with file type specific options. This is the way
gimp does it. I don't like it too much, because you always have to confirm two
dialogs.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 217598] detect image type to save according to extension

Wolfram Quester-2
In reply to this post by Wolfram Quester-2
https://bugs.kde.org/show_bug.cgi?id=217598





--- Comment #2 from Wolfram Quester <wolfi sigxcpu org>  2009-12-06 16:50:25 ---
In the two-stage procedure you suggest, the second dialog is only necessary if
the filter and the name from the first dialog contradict each other.

We could also simply attach the correct extension, so if I selected jpeg, but
type bla.tiff, the file would be saved as bla.tiff.jpg. I aggree, this is ugly,
but that way digikam would at least be able to open the file again, which it is
not with the current behaviour.

At least I should be warned, if I try to save a 16Bit image in a 8Bit format.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 217598] detect image type to save according to extension

Marcel Wiesweg
In reply to this post by Wolfram Quester-2
https://bugs.kde.org/show_bug.cgi?id=217598


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #3 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-12-06 22:47:59 ---
I dont like the two-dialog approach.
The autodetection thing is how I would expect this to work; can the KDE file
dialog do this?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 217598] detect image type to save according to extension

Johannes Wienke-3
In reply to this post by Wolfram Quester-2
https://bugs.kde.org/show_bug.cgi?id=217598





--- Comment #4 from Johannes Wienke <languitar semipol de>  2009-12-06 22:49:40 ---
I just tried a bit with the "options-while-typing" solution. It works better
than I thought and we could use this one. The problem there is that this
solution would completely ignore the filter selected.

My proposal would be to use the filename extension if the filter "all images"
is selected and display the file format options immediately while typing after
it is detected.

If any other filter is selected, use that format.

What do you think about this?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 217598] detect image type to save according to extension

Johannes Wienke-3
In reply to this post by Wolfram Quester-2
https://bugs.kde.org/show_bug.cgi?id=217598





--- Comment #5 from Johannes Wienke <languitar semipol de>  2009-12-06 22:51:06 ---
(In reply to comment #3)
> The autodetection thing is how I would expect this to work; can the KDE file
> dialog do this?

It's not much work. Could be don in half an hour for me. ;)

The only thing I see with my proposal above is that the filter "all images"
should be changed to "all images (use extension for format)", but we're in the
string freeze now... Can we break for this or should we wait with the string
change after 1.0 release?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 217598] detect image type to save according to extension

Gilles Caulier-4
In reply to this post by Wolfram Quester-2
https://bugs.kde.org/show_bug.cgi?id=217598





--- Comment #6 from Gilles Caulier <caulier gilles gmail com>  2009-12-06 22:54:51 ---
I don't like twice dialog solution too..

You can break i18n if you please kde translators team sending a mail to the
mailing list. also, i18n changes must be small of course.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 217598] detect image type to save according to extension

Johannes Wienke-3
In reply to this post by Wolfram Quester-2
https://bugs.kde.org/show_bug.cgi?id=217598





--- Comment #7 from Johannes Wienke <languitar semipol de>  2009-12-06 22:56:07 ---
Ok, so do you think that solution I proposed is good?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 217598] detect image type to save according to extension

Gilles Caulier-4
In reply to this post by Wolfram Quester-2
https://bugs.kde.org/show_bug.cgi?id=217598


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #8 from Gilles Caulier <caulier gilles gmail com>  2009-12-06 22:58:55 ---
yes, it's fine for me...

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 217598] detect image type to save according to extension

Johannes Wienke-3
In reply to this post by Wolfram Quester-2
https://bugs.kde.org/show_bug.cgi?id=217598


Johannes Wienke <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #9 from Johannes Wienke <languitar semipol de>  2009-12-07 23:54:42 ---
SVN commit 1060041 by jwienke:

Detect save file type based on file name of "all images" filter is selected.
Otherwise use filter type.

BUG: 217598

 M  +129 -18   libs/widgets/common/filesaveoptionsbox.cpp  
 M  +47 -2     libs/widgets/common/filesaveoptionsbox.h  
 M  +13 -0     tests/CMakeLists.txt  
 AM            tests/filesaveoptionsboxtest.cpp   [License: GPL (v2+)]
 AM            tests/filesaveoptionsboxtest.h   [License: GPL (v2+)]
 M  +44 -51    utilities/imageeditor/editor/editorwindow.cpp  
 M  +5 -3      utilities/imageeditor/editor/editorwindow.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1060041

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 217598] detect image type to save according to extension

Bugzilla from meldavid@acc.umu.se
In reply to this post by Wolfram Quester-2
https://bugs.kde.org/show_bug.cgi?id=217598


David Eriksson <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #10 from David Eriksson <meldavid acc umu se>  2009-12-10 10:12:17 ---
Under Windows the two step solution is needed since the Save as dialog is the
native Windows dialog. Is it hard to do? I could try it myself if someone could
give me some hints on where to start.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 217598] detect image type to save according to extension

Johannes Wienke-3
In reply to this post by Wolfram Quester-2
https://bugs.kde.org/show_bug.cgi?id=217598





--- Comment #11 from Johannes Wienke <languitar semipol de>  2009-12-10 16:32:01 ---
Gilles, what do you think? I never tried digikam on windows?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 217598] detect image type to save according to extension

Gilles Caulier-4
In reply to this post by Wolfram Quester-2
https://bugs.kde.org/show_bug.cgi?id=217598


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #12 from Gilles Caulier <caulier gilles gmail com>  2009-12-10 16:35:36 ---
Yes, under windows, Qt file dialog is used instead KDE filesave dialog. But i
think it's a temporary solution...

Here Patrick can respond better than me about this situation...

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 217598] detect image type to save according to extension

bugzilla_noreply
In reply to this post by Wolfram Quester-2
https://bugs.kde.org/show_bug.cgi?id=217598

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Usability

--
You are receiving this mail because:
You are the assignee for the bug.
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 217598] detect image type to save according to extension

bugzilla_noreply
In reply to this post by Wolfram Quester-2
https://bugs.kde.org/show_bug.cgi?id=217598

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Usability                   |FilesIO-Engine

--
You are receiving this mail because:
You are the assignee for the bug.