[Bug 211643] New: exposure indicators not working while raw import

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=211643

           Summary: exposure indicators not working while raw import
           Product: digikam
           Version: unspecified
          Platform: Ubuntu Packages
        OS/Version: unspecified
            Status: NEW
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           trunk (using KDE 4.3.2)
Installed from:    Ubuntu Packages

The exposure indicators aren't working while importing a raw image. This is
something that should definitely work as it is very important for a good raw
import.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=211643


Johannes Wienke <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |RAW files management
            Version|unspecified                 |1.0.0-beta6




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211643


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.0.0-beta6                 |1.0.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

["Jens Müller"]

https://bugs.kde.org/show_bug.cgi?id=211643


Jens Mueller <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #1 from Jens Mueller <tschenser gmx de>  2009-12-30 22:09:28 ---
Johannes, I assume this one is fixed with
https://bugs.kde.org/show_bug.cgi?id=220454#c12, is it?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=211643





--- Comment #2 from Johannes Wienke <languitar semipol de>  2009-12-30 22:37:09 ---
For me it still doesn't show anything while being in raw conversion mode.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211643





--- Comment #3 from Gilles Caulier <caulier gilles gmail com>  2009-12-30 22:49:56 ---
I confirm. Changing contrast or brightness, which generate over and under
exposed pixels, do not show something in preview

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

["Jens Müller"]

https://bugs.kde.org/show_bug.cgi?id=211643





--- Comment #4 from Jens Mueller <tschenser gmx de>  2010-01-01 22:46:32 ---
You are right, over/under exposure indicators from menu bar are not working in
tool views like whitebalance. But over/under exposure indicator work from tool
buttons on top in whitebalace view for me. So it looks like the menu entries
are delegated to the edit view, but not to the tools view nor they connected to
the state of the tool buttons. Is this right?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211643





--- Comment #5 from Gilles Caulier <caulier gilles gmail com>  2010-01-01 22:58:13 ---
yes and a big patch is under construction on my computer. All is partially
fixed there

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211643





--- Comment #6 from Gilles Caulier <caulier gilles gmail com>  2010-01-03 23:20:20 ---
Created an attachment (id=39538)
 --> (http://bugs.kde.org/attachment.cgi?id=39538)
Use expo settings and CM settings in raw import preview

This patch fix more issues :

- in editor, i factorize all KActions to status bar indicator (CM, overexpo,
underexpo). This will limit signals/slots connections and redundant codes.
- in editortoolidface, i had new method to handle indicators status
- in RawImport tool, indicator status are dispatched to preview widget.
- RawImport preview use indicators status to draw image.

Pending problems :

- When you load editor with a RAW image, if indicator are already set on by a
previous session, there are not propagated to raw import preview. You need to
press F10 or F11 to take effect. But in code, read settings restore indicator
status fine. I don't yet found where is the problem.

- In RawImport, OverExposure indicator don't work. I suspsect that post
processing algorithm clamp to 65534, not 65535 (tested in 16 bits, not 8 bits)

Please review and test...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211643


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39538|0                           |1
        is obsolete|                            |




--- Comment #7 from Gilles Caulier <caulier gilles gmail com>  2010-01-04 09:45:40 ---
Created an attachment (id=39542)
 --> (http://bugs.kde.org/attachment.cgi?id=39542)
patch version2. compile with currrent svn

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211643





--- Comment #8 from Gilles Caulier <caulier gilles gmail com>  2010-01-04 09:46:52 ---
This part :

- in editor, i factorize all KActions to status bar indicator (CM, overexpo,
underexpo). This will limit signals/slots connections and redundant codes.

... is officially in trunk now. Patch only include rest of changes.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211643





--- Comment #9 from Gilles Caulier <caulier gilles gmail com>  2010-01-04 11:45:35 ---
SVN commit 1069871 by cgilles:

for obscurs reasons, DImgScale code clamp to 65534 or 254 instead 65535 or 255.
I don't know why exactly.
This can be seen with RawPreview code when pixamp is rendered.
So we adapt pureColor Mask code accordingly.
CCBUGS: 211643


 M  +6 -5      dimg.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1069871

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211643





--- Comment #10 from Gilles Caulier <caulier gilles gmail com>  2010-01-04 11:46:48 ---
SVN commit 1069872 by cgilles:

dispatch under/over/CM flags to editortool.
Use it as well to RAWImport
CCBUGS: 211643


 M  +6 -0      editor/editortool.h  
 M  +14 -0     editor/editortooliface.cpp  
 M  +5 -0      editor/editortooliface.h  
 M  +2 -2      editor/editorwindow.cpp  
 M  +11 -1     rawimport/rawimport.cpp  
 M  +2 -0      rawimport/rawimport.h  
 M  +6 -2      rawimport/rawpostprocessing.cpp  
 M  +66 -14    rawimport/rawpreview.cpp  
 M  +5 -1      rawimport/rawpreview.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1069872

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211643


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #11 from Gilles Caulier <caulier gilles gmail com>  2010-01-04 13:53:34 ---
SVN commit 1069924 by cgilles:

clear cache when indicator state change
BUGS: 211643


 M  +3 -3      rawpreview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1069924

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211643


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #12 from Gilles Caulier <caulier gilles gmail com>  2010-01-04 13:59:45 ---
Marcel,

i has a question for you there : In canvas/dimginterface, we have a method to
switch on/off CM soft proof (setSoftProofingEnabled() method)

Do you think that we must implement the same things in rawpreview ?

Currenty, rawpreview support over/under exposure indicator, and color
management view.

Important : With image editor tool preview factorization, i plan to use
rawpreview code later as reference implementation.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=211643





--- Comment #13 from Johannes Wienke <languitar semipol de>  2010-01-04 20:57:43 ---
For me this works good now.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

["Jens Müller"]

https://bugs.kde.org/show_bug.cgi?id=211643





--- Comment #14 from Jens Mueller <tschenser gmx de>  2010-01-04 22:36:28 ---
Gilles, because you made some commits since your last patch attachment I'm not
shure if you commit all or I still have to patch.

When I open a image in editor, menubar actions of exposure indicators match
exposure indicator in statusbar. Indicators are shown on the image accordingly.

When open a tool, for example white balance, the statusbar symbols of
indicators match and change with menu actions. But indicators are not shown on
the image, nor is there a matching between indicator menu actions and indicator
toolbar actions.

Jens

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211643





--- Comment #15 from Gilles Caulier <caulier gilles gmail com>  2010-01-05 07:29:13 ---
>Gilles, because you made some commits since your last patch attachment I'm not
>shure if you commit all or I still have to patch.

All is commited now.

For the rest i will take a look if a side effect exist...

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

["Jens Müller"]

https://bugs.kde.org/show_bug.cgi?id=211643





--- Comment #16 from Jens Mueller <tschenser gmx de>  2010-01-08 18:23:39 ---
Yeah, with your commit from today everything looks fine now, Gilles. All
statusbar entries, menue entries and indicators behave like I expected. :o)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211643

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |1.1.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel