[Bug 211535] New: Revert and undo in image editor does not work

https://bugs.kde.org/show_bug.cgi?id=211535

           Summary: Revert and undo in image editor does not work
           Product: digikam
           Version: unspecified
          Platform: SuSE RPMs
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           Version 1.0.0-beta6 (rev.: 1038724) (using KDE 4.2.4)
OS:                Linux
Installed from:    SuSE RPMs

Hi,

During editing pictures I discovered following two (probably related) problems:

1) Revert function
When I want to go back to the beginning of the editing because I'm not
satisfied with the result I use the button revert (or use the menu entry). But
calling that function shows an odd behaviour. After I selected "discard" in the
dialog the image disappears and the editor canvas remains black. I have to load
the file again from digikam or with the file-open dialog. In earlier versions
the editor loaded the file again by itself and the image appeared in its
unmodified state on the canvas. Here is what I got on the console after
pressing the discard button:
digikam(5081)/digikam (core) Digikam::DImg::load: ""  : Unknown image format
!!!
digikam(5081)/digikam (core) Digikam::DImgInterface::getImg: d->image is NULL
digikam(5081)/digikam (core) Digikam::DImg::load:
"/home/ablage/Grafiken/Originale/()
E_Barcelona_2006/Originalscans/Bild_M2c_063.tif"  : TIFF file identified

2) Undo function
During editing I want to undo a step (e.g. rotation or curves). In earlier
versions I used the function undo to do this. But now pressing the button (or
using the menu entry) has effect. The image stays as it is and also on the
console there are no messages. It seems like the function behind the toolbar
button is commented out.

TIA
Guenther

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211535


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Image Editor
            Version|unspecified                 |1.0.0-beta6




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2009-10-23 14:10:43 ---
Not reproducible here....

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211535





--- Comment #2 from Andi Clemens <andi clemens gmx net>  2009-10-23 14:20:45 ---
Works fine here, too...

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211535





--- Comment #3 from Guenther M. Erhard <guenther erhard gmx de>  2009-10-23 18:09:26 ---
(In reply to comment #2)
> Works fine here, too...

During my attempts to get assigning color profiles working again I upgraded now
kde to 4.3.2 and qt to 4.5.2. On top of that I de-installed everything
(hopefully) from svn, checked out and compiled again.

Color profile is working now, but revert and undo still show this odd
behaviour. :-(. I've tested it under kde3.5, kde4.3.2 and Gnome2.28: no
difference.

Guenther

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211535





--- Comment #4 from Andi Clemens <andi clemens gmx net>  2009-10-24 12:57:52 ---
I can confirm a dysfunction in UNDO now, and it is very weird.
I just discovered it for the first time, but my issue seems to be different.

I opened a single file (an single image in a folder) and edited it. Then I
pressed "undo", and a totally different file from a different folder (which is
not loaded into IE at all) is displayed!
I'll do a small video to proof it.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211535





--- Comment #5 from Andi Clemens <andi clemens gmx net>  2009-10-24 13:07:03 ---
Here: http://digikam3rdparty.free.fr/misc.tarballs/temp/undo_broken.mov

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211535





--- Comment #6 from Guenther M. Erhard <guenther erhard gmx de>  2009-10-25 12:07:02 ---
(In reply to comment #5)
> Here: http://digikam3rdparty.free.fr/misc.tarballs/temp/undo_broken.mov

Very odd. That is different to my bug.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211535





--- Comment #7 from Guenther M. Erhard <guenther erhard gmx de>  2009-10-25 12:10:53 ---
I have gone now back from kde4.3.2 to kde4.2.4, because the crash at the
program exit was distracting. Afterwards I have compiled a new version
1.0.0-beta6 (rev.: 1039950). At least for the moment undo is working now. It
seems that it is somehow dependend on kde libraries  and versions.

Revert still does not show the original image after discard.

Guenther

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211535





--- Comment #8 from Gilles Caulier <caulier gilles gmail com>  2009-10-25 12:59:31 ---
What's the size of your image.

What do you see on the console when you run digiKam (run kdebugdialog and turn
on digikam debug space before)

What the space on you /var. Usually, it's the place where temp files are
written by editor (under Mandriva for me)

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211535





--- Comment #9 from Andi Clemens <andi clemens gmx net>  2009-10-26 00:28:10 ---
According to "git bisect",
commit #1014134 (http://websvn.kde.org/?revision=1014134&view=revision)
is responsible for the "revert" issue.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211535


Andi Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211535





--- Comment #10 from Andi Clemens <andi clemens gmx net>  2009-10-26 10:54:34 ---
I guess my weird "undo" issue from the video link above (I can not reproduce it
right now) might be introduced by this commit as well, since something about
image loading changed?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=211535





--- Comment #11 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-10-26 18:44:30 ---
SVN commit 1040697 by mwiesweg:

Fix "Revert" button in editor (calling resetValues() will clear the
currentDescription)

CCBUG: 211535

 M  +2 -2      dimginterface.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1040697

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=211535





--- Comment #12 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-10-26 19:25:11 ---
The "revert" problem is fixed, but I can't reproduce any undo/redo problem
here.
I think these problems are unrelated, because revert() works by full reloading
while undo/redo replaces the image data of the current image, not using the
loading framework.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211535





--- Comment #13 from Guenther M. Erhard <guenther erhard gmx de>  2009-10-26 19:28:13 ---
(In reply to comment #8)
> What's the size of your image.
>
This independent of the size. I have images with a few 100k up to 120MB.

> What do you see on the console when you run digiKam (run kdebugdialog and turn
> on digikam debug space before)
>
There is no entry of digikam in kdebugdialog. On the console I see only this:
digikam(11315)/digikam (core) Digikam::DImg::load: ""  : Unknown image format
!!!
digikam(11315)/digikam (core) Digikam::DImgInterface::getImg: d->image is NULL

> What the space on you /var. Usually, it's the place where temp files are
> written by editor (under Mandriva for me)
>
18GB left - should be enough.

Guenther

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211535





--- Comment #14 from Guenther M. Erhard <guenther erhard gmx de>  2009-10-26 20:58:10 ---
(In reply to comment #12)
> The "revert" problem is fixed, but I can't reproduce any undo/redo problem
> here.
> I think these problems are unrelated, because revert() works by full reloading
> while undo/redo replaces the image data of the current image, not using the
> loading framework.
>
I can confirm that with version 1.0.0-beta6 (rev.: 1040748) revert as well as
undo is now working without problems. Thanks for the quick fix.

Guenther

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211535





--- Comment #15 from Gilles Caulier <caulier gilles gmail com>  2009-10-26 21:15:13 ---
So, we can close this file now ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211535


Guenther M. Erhard <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #16 from Guenther M. Erhard <guenther erhard gmx de>  2009-10-26 21:25:56 ---
(In reply to comment #15)
> So, we can close this file now ?
>
From my point of view: yes.

Guenther

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211535


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.0.0-beta6                 |1.0.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel