[Bug 211237] New: Advanced rename: only one shot

[Bartek Pietrasiak]

https://bugs.kde.org/show_bug.cgi?id=211237

           Summary: Advanced rename: only one shot
           Product: digikam
           Version: unspecified
          Platform: Fedora RPMs
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           rev.: 1037924 (using KDE 4.3.2)
OS:                Linux
Installed from:    Fedora RPMs

I can only do one reanema. After that, digikam still complains that he cannot
change e.g. test2.jpg with test2.jpg even I change the pattern and even I
change the collections. I have to restart it to make another rename.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211237


Andi Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Advanced Rename
            Version|unspecified                 |1.0.0-beta6




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Bartek Pietrasiak]

https://bugs.kde.org/show_bug.cgi?id=211237





--- Comment #1 from Bartek Pietrasiak <pietras sp gmail com>  2009-10-22 17:58:43 ---
It seems not to occur until you try to use the same pattern again, so that the
error is displayed for the first time. After that, you always get the error.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211237





--- Comment #2 from Andi Clemens <andi clemens gmx net>  2009-10-22 18:11:06 ---
It only occurs when you use file names that are already assigned.
The KDE popup will come to tell you to chose another name and you seem to press
cancel then.
I'm already aware of this problem and work on it.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211237





--- Comment #3 from Andi Clemens <andi clemens gmx net>  2009-10-22 18:55:49 ---
SVN commit 1039077 by aclemens:

Fix error handling in AdvancedRename.
Since we use KIO for this, real error handling is not necessary. Just make sure
that we cleanup the list on failed renaming, too (wakeAll())
CCBUG:211237

 M  +7 -4      digikam/digikamimageview.cpp  
 M  +14 -25    digikam/imageviewutilities.cpp  
 M  +4 -3      digikam/imageviewutilities.h  
 M  +16 -16    utilities/advancedrename/advancedrenamedialog.cpp  
 M  +4 -4      utilities/advancedrename/advancedrenamedialog.h  
 M  +19 -2     utilities/advancedrename/common/renamethread.cpp  
 M  +3 -2      utilities/advancedrename/common/renamethread.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1039077

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211237





--- Comment #4 from Andi Clemens <andi clemens gmx net>  2009-10-22 18:56:39 ---
Bartek,

can you check with latest SVN code?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211237





--- Comment #5 from Andi Clemens <andi clemens gmx net>  2009-10-22 19:31:12 ---
I just renamed 50.000 images, I have not seen any issue...

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Bartek Pietrasiak]

https://bugs.kde.org/show_bug.cgi?id=211237





--- Comment #6 from Bartek Pietrasiak <pietras sp gmail com>  2009-10-22 23:22:53 ---
Fortunately, I didn't have 50.000 images during test therefore I had to click
the cancel button only 125 times :] Seems to be ok now. But can you add some
cancel button which will break the whole renaming process?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211237





--- Comment #7 from Andi Clemens <andi clemens gmx net>  2009-10-23 00:19:39 ---
SVN commit 1039187 by aclemens:

Abort renaming when canceling a nameconflict or overwrite dialog.
CCBUG:211237

 M  +3 -0      digikam/digikamimageview.cpp  
 M  +10 -2     digikam/imageviewutilities.cpp  
 M  +1 -0      digikam/imageviewutilities.h  
 M  +1 -1      utilities/advancedrename/common/renamethread.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1039187

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211237


Andi Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #8 from Andi Clemens <andi clemens gmx net>  2009-10-23 00:37:22 ---
I guess this report can be closed, feel free to add comments if still something
is wrong.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211237


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.0.0-beta6                 |1.0.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211237

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |1.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel