[Bug 211060] New: Advanced rename: keep the pattern

[Bartek Pietrasiak]

https://bugs.kde.org/show_bug.cgi?id=211060

           Summary: Advanced rename: keep the pattern
           Product: digikam
           Version: unspecified
          Platform: Fedora RPMs
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           revision 1034752 (using KDE 4.3.2)
OS:                Linux
Installed from:    Fedora RPMs

It would be nice if the advanced rename dialog didn't remove the pattern but
keep it in the input box (as the kipi rename plugin does), so that I wouldn't
have to create it every time (and it always the same).

Perhaps a drop down list with a few recently used would be useful for people,
who use more than one pattern.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=211060


Johannes Wienke <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|general                     |Advanced Rename
            Version|unspecified                 |1.0.0-beta6




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211060


Andi Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1




--- Comment #1 from Andi Clemens <andi clemens gmx net>  2009-10-19 12:36:38 ---
Yes, I was thinking about a combobox with at least 5 last used patterns.
About keeping the pattern: I guess most users don't like it, but we will see.
But a history combobox should definitely help you out here.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211060





--- Comment #2 from Andi Clemens <andi clemens gmx net>  2009-10-19 13:04:53 ---
Ok right now I have a huge problem :)
I use a modified KLineEdit here to insert tokens, highlight them etc. This can
not be done with an editable KComboBox widget, so right now I have no clue how
to add a dropdown menu with history items. The only solution I see so far is
copying the kcombobox class from KDE and modify it.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211060





--- Comment #3 from Gilles Caulier <caulier gilles gmail com>  2009-10-19 13:07:12 ---
Why, you don't use auto-completion ? It work very well... It's not enough ?

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211060





--- Comment #4 from Gilles Caulier <caulier gilles gmail com>  2009-10-19 13:09:37 ---
Like this :
http://lxr.kde.org/source/extragear/graphics/digikam/libs/widgets/common/searchtextbar.cpp#68

KLineEdit will provide combobox menu if necessary...

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211060





--- Comment #5 from Andi Clemens <andi clemens gmx net>  2009-10-19 13:14:25 ---
You mean for history? Hmm I can try it... otherwise I will reimplement
KComboBox. The API is weird there, we have a KComboBox::cursorPosition()
method, but no KComboBox::setCursorPosition(). This would have solved my
problem I guess.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211060





--- Comment #6 from Gilles Caulier <caulier gilles gmail com>  2009-10-19 13:16:11 ---
yes, for history...

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Bartek Pietrasiak]

https://bugs.kde.org/show_bug.cgi?id=211060





--- Comment #7 from Bartek Pietrasiak <pietras sp gmail com>  2009-10-19 14:57:42 ---
"I guess most users don't like it"
I think that most people like this digikam feature and miss it in e.g. gimp. It
is quite useful when you edit more than one file. I don't have to change the
input data while resizing, sharpening and saving to jpg.

In this case it might not be so important, since I don't rename as often as
resize ;)

Btw, if you wanted to make both of the groups happy, you can put a checkbox in
the options ;)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211060





--- Comment #8 from Andi Clemens <andi clemens gmx net>  2009-10-19 15:05:37 ---
The "problem" is that I just added another request about using the filename as
a pattern when only a single image is going to be renamed.
It would be very inconsistent if many files will restore the last pattern, but
a single file will use the filename as the pattern.

So I guess a history function is much more practical, since we can set the
filename as a pattern for single rename, but you are still able to restore your
last patterns by a dropdown menu.

Both sides should be happy then... at least I guess so :D

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211060





--- Comment #9 from Andi Clemens <andi clemens gmx net>  2009-10-19 17:49:12 ---
SVN commit 1037602 by aclemens:

Add history to the AdvancedRenameWidget.
Some issues:
- Highlighting is not working correctly anymore, somehow the CSS
style is ignored (if you move the mouse very quickly, a token sometimes is
colored red, but only for some milliseconds).

- The lineedit widget seems to be overlaying the ComboBox, I have not found yet
  a way to make it fit

Bartek,
can you test this and tell me if it is enough for you?

CCBUG:211060

 M  +91 -33    advancedrenameinput.cpp  
 M  +38 -4     advancedrenameinput.h  
 M  +21 -4     advancedrenamewidget.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1037602

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211060





--- Comment #10 from Andi Clemens <andi clemens gmx net>  2009-10-19 20:39:13 ---
History is implemented now and should work fine.
A maximum of 10 patterns will be remembered.

Gilles,
somehow the history / combobox is broken in BQM?
I don't understand why.

Any idea?

Andi

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211060





--- Comment #11 from Andi Clemens <andi clemens gmx net>  2009-10-19 21:59:16 ---
Right now the history is saved in AdvancedRenameWidget (which made sense to
me), but I'm thinking about moving it out into the places where the widget is
used, e.g. CameraUI, AlbumUIDialog and BQM.
Every one of these instances will then have it's own history.
What do you think?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211060


Andi Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED




--- Comment #12 from Andi Clemens <andi clemens gmx net>  2009-10-19 22:21:26 ---
Hmm I will go with this setup now:
Every instance (CameraUI, AlbumUI and BQM) remembers the their last renaming
string and inserts it as the active pattern.

The history will be shared though.
This should satisfy the original poster as well.

I'll close this wish now, feel free to add more comments if necessary.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Bartek Pietrasiak]

https://bugs.kde.org/show_bug.cgi?id=211060





--- Comment #13 from Bartek Pietrasiak <pietras sp gmail com>  2009-10-20 19:20:13 ---
It is fine for me. Thx.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211060


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.0.0-beta6                 |1.0.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel