[Bug 210576] New: Move tag filter to the bottom
Locked
[Bug 210576] New: Move tag filter to the bottom
 
|
https://bugs.kde.org/show_bug.cgi?id=210576
Summary: Move tag filter to the bottom Product: digikam Version: unspecified Platform: Mandriva RPMs OS/Version: unspecified Status: UNCONFIRMED Severity: wishlist Priority: NOR Component: general AssignedTo: [hidden email] ReportedBy: [hidden email] Version: 1.0.0beta6 (using KDE 4.2.4) Installed from: Mandriva RPMs This is a small wish. Currently digiKam main window is well organized : - pictures lie in the center - browse by albums, tags, location, fuzzy search... on the left - information current picture on the right - filter by name, number of stars, file type at the bottom But there is one exception : filter by tags is in the right sidebar, I think it should in the bar at the bottom with all other filters. My 2 cents, Julien -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
[Bug 210576] Move tag filter to the bottom
|
|
https://bugs.kde.org/show_bug.cgi?id=210576
Johannes Wienke <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[hidden email] --- Comment #1 from Johannes Wienke <languitar semipol de> 2009-10-14 19:04:27 --- Sounds like a god idea to me. Could also resolve the space problems discussed at 210358 if some kind of popup menu is used to configure the filters. -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
[Bug 210576] Move tag filter to the bottom
|
|
In reply to this post by Bugzilla from Julien@narboux.fr
https://bugs.kde.org/show_bug.cgi?id=210576
Gilles Caulier <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[hidden email] Component|general |Filter Version|unspecified |1.0.0 -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
[Bug 210576] Move tag filter to the bottom
|
|
In reply to this post by Bugzilla from Julien@narboux.fr
https://bugs.kde.org/show_bug.cgi?id=210576
--- Comment #2 from Gilles Caulier <caulier gilles gmail com> 2009-10-15 13:20:38 --- Created an attachment (id=37592) --> (http://bugs.kde.org/attachment.cgi?id=37592) Mockup : tags filters on status bar This Mockup is done to take tags selector combo box from Advanced Search dialog. http://lxr.kde.org/source/extragear/graphics/digikam/utilities/searchwindow/searchfields.h#301 Of course a lots of code from current tags filter tree view must be backported. We must take a care to port to pure Qt4 here. Current Tags Filters still to use Q3ListView. Code from Marcel is already pure http://lxr.kde.org/source/extragear/graphics/digikam/digikam/tagfilterview.h#51 . For options from Filter view pop-up menu, i recommend to use it as well and to change behavior later, because it require a lots of test to re-validate. Gilles Caulier -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
[Bug 210576] Move tag filter to the bottom
|
|
In reply to this post by Bugzilla from Julien@narboux.fr
https://bugs.kde.org/show_bug.cgi?id=210576
--- Comment #3 from Gilles Caulier <caulier gilles gmail com> 2011-02-16 13:23:57 --- Git commit 91a71c0e48780b572ea0c8320c96af6d1a9e8f90 by Gilles Caulier. Committed on 16/02/2011 at 12:49. Pushed by cgilles into branch 'development/2.0'. Move Rating filter from statusbar to Tags Filter view from right sidebar. As Rating is considerated as a Labels (like Pick or Color), it need to be moved near Pick/Color Label filters. Note that i plan to move all filters from status bar to right Sidebar and rename "Tag Filters" as "Filters", and to add 2 buttons on status bar : "Reset" to clean all active filters "Settings" (or something like that) to switch on "Filters" panel from right sidebar. The advantage to use "Filters" panel from right side bar is to be able to host more filters in the future. Status bar is limited in space to host more settings. There are a lots of whishes about this subject in bugzilla. CCBUGS: 241847 M +6 -32 digikam/albumiconviewfilter.cpp M +2 -5 digikam/albumiconviewfilter.h M +0 -6 digikam/digikamapp.cpp M +5 -5 digikam/digikamview.cpp M +18 -2 digikam/tagfiltersidebarwidget.cpp M +5 -2 digikam/tagfiltersidebarwidget.h M +1 -0 digikam/tags/colorlabelfilter.cpp M +1 -0 digikam/tags/picklabelfilter.cpp M +7 -7 libs/imageproperties/imagedescedittab.cpp M +12 -2 libs/models/imagefiltersettings.cpp M +3 -1 libs/models/imagefiltersettings.h http://commits.kde.org/digikam/91a71c0e48780b572ea0c8320c96af6d1a9e8f90 -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
[Bug 210576] Move tag filter to the bottom
|
|
In reply to this post by Bugzilla from Julien@narboux.fr
https://bugs.kde.org/show_bug.cgi?id=210576
--- Comment #4 from Gilles Caulier <caulier gilles gmail com> 2011-02-16 16:35:42 --- Git commit 01ac5693959fba9a28f6be320572e66822db2e12 by Gilles Caulier. Committed on 16/02/2011 at 16:34. Pushed by cgilles into branch 'development/2.0'. move search text filter to Tags Filter sidebar CCBUGS: 201282 CCBUGS: 210576 M +5 -19 digikam/albumiconviewfilter.cpp M +1 -4 digikam/albumiconviewfilter.h M +9 -7 digikam/digikamview.cpp M +30 -6 digikam/tagfiltersidebarwidget.cpp M +4 -0 digikam/tagfiltersidebarwidget.h http://commits.kde.org/digikam/01ac5693959fba9a28f6be320572e66822db2e12 -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
[Bug 210576] Move tag filter to the bottom
|
|
In reply to this post by Bugzilla from Julien@narboux.fr
https://bugs.kde.org/show_bug.cgi?id=210576
--- Comment #5 from Gilles Caulier <caulier gilles gmail com> 2011-02-16 16:51:30 --- Git commit 7302d22296928e69278da056b17afb37c9172269 by Gilles Caulier. Committed on 16/02/2011 at 16:50. Pushed by cgilles into branch 'development/2.0'. move type mime filter to Tags Filter sidebar CCBUGS: 201282 CCBUGS: 210576 M +3 -1 NEWS M +3 -11 digikam/albumiconviewfilter.cpp M +0 -1 digikam/albumiconviewfilter.h M +3 -3 digikam/digikamview.cpp M +17 -0 digikam/tagfiltersidebarwidget.cpp M +1 -1 digikam/tagfiltersidebarwidget.h M +10 -0 libs/models/imagefiltersettings.cpp M +2 -0 libs/models/imagefiltersettings.h http://commits.kde.org/digikam/7302d22296928e69278da056b17afb37c9172269 -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
[Bug 210576] Move tag filter to the bottom
|
|
In reply to this post by Bugzilla from Julien@narboux.fr
https://bugs.kde.org/show_bug.cgi?id=210576
Gilles Caulier <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #6 from Gilles Caulier <caulier gilles gmail com> 2011-02-16 17:26:55 --- Git commit 75761c8459b880f23111e8bfc6061e2441e2d37a by Gilles Caulier. Committed on 16/02/2011 at 17:24. Pushed by cgilles into branch 'development/2.0'. rename TagsFilter to Filters Add 2 buttons on status bar to reset all filters and to pop-up filters view from right sidebar. BUGS: 201282 BUGS: 210576 M +28 -2 digikam/albumiconviewfilter.cpp M +1 -0 digikam/albumiconviewfilter.h M +11 -1 digikam/digikamview.cpp M +2 -0 digikam/digikamview.h M +5 -0 digikam/tagfiltersidebarwidget.cpp M +2 -0 digikam/tagfiltersidebarwidget.h http://commits.kde.org/digikam/75761c8459b880f23111e8bfc6061e2441e2d37a -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
[Bug 210576] Move tag filter to the bottom
|
|
In reply to this post by Bugzilla from Julien@narboux.fr
https://bugs.kde.org/show_bug.cgi?id=210576
--- Comment #7 from Julien Narboux <Julien narboux fr> 2011-02-18 13:22:44 --- Gilles, I like the fact that all filters are in the same tab now. But what about putting this at the bottom of the main windows not on the right ?On the right we are information about the current selected picture. On the left we have browsing. On the bottom we would have the filters. It does not to be in the status bar, but as an horizontal pane like the sidebars. Concerning the green/red/grey icon for filters, thunderbird has a nice feature: when there is no solution for the current filter the whole area is framed in red. I think this would be better than the red icon in the status bar, because one does not necessarily notices this small red icon. I can add a screenshot if you don't see what I mean. Julien -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
[Bug 210576] Move tag filter to the bottom
|
|
In reply to this post by Bugzilla from Julien@narboux.fr
https://bugs.kde.org/show_bug.cgi?id=210576
--- Comment #8 from Gilles Caulier <caulier gilles gmail com> 2011-02-18 13:46:37 --- Julien, Thanks to review again my code. The way to put all filter in sidebar is to be able to include new one without to be limited by view size. In statusbar, i cannot see how we can add new filters without to bloat gui. Also, how do you want to have a suitable view of tag filters from status bar. including it in a combobox as in Advanced search tool will be very limited solution, especially if tag view is huge. i tried this and forget this way. The way to use an horizontal view to host filter will provide a large area (not only a simple status bar). Using sidebar instead, i can use a vertical scroll view which is more natural. I see Aperture using a similar way... About status bar indicator, i agree that LED is too small. I like the thunderbird solution. It's very easy to implement. I will take a look Gilles Caulier -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
[Bug 210576] Move tag filter to the bottom
|
|
In reply to this post by Bugzilla from Julien@narboux.fr
https://bugs.kde.org/show_bug.cgi?id=210576
--- Comment #9 from Julien Narboux <Julien narboux fr> 2011-02-18 14:23:06 --- Ok Gilles a vertical area is maybe more natural. Maybe to clarify the difference between the filter tab and the other tabs, you could add a small space before the icon for the filter tab. Julien -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
[Bug 210576] Move tag filter to the bottom
|
|
In reply to this post by Bugzilla from Julien@narboux.fr
https://bugs.kde.org/show_bug.cgi?id=210576
--- Comment #10 from Gilles Caulier <caulier gilles gmail com> 2011-02-18 14:28:18 --- ... or moving to the bottom of sidbar button list. i remember to see this somewhere. I need to search... Gilles -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
[Bug 210576] Move tag filter to the bottom
|
|
In reply to this post by Bugzilla from Julien@narboux.fr
https://bugs.kde.org/show_bug.cgi?id=210576
--- Comment #11 from Gilles Caulier <caulier gilles gmail com> 2011-02-19 22:23:15 --- Git commit 5192c6532c0d5be320ced32f9629de3e3d76a99e by Gilles Caulier. Committed on 19/02/2011 at 22:19. Pushed by cgilles into branch 'development/2.0'. paint filter status from status with an hightlighted background color, as dolphin, kmail, or thunderbird CCBUGS: 210576 M +61 -8 digikam/albumiconviewfilter.cpp M +3 -5 digikam/albumiconviewfilter.h http://commits.kde.org/digikam/5192c6532c0d5be320ced32f9629de3e3d76a99e -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
[Bug 210576] Move tag filter to the bottom
|
|
In reply to this post by Bugzilla from Julien@narboux.fr
https://bugs.kde.org/show_bug.cgi?id=210576
Gilles Caulier <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Version Fixed In| |2.0.0 -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
«
Return to digikam-devel
|
1 view|%1 views
| Free forum by Nabble | Edit this page |