[Bug 208504] New: Add type icon to images under the thumbnail

[Leonardo Giordani-2]

https://bugs.kde.org/show_bug.cgi?id=208504

           Summary: Add type icon to images under the thumbnail
           Product: digikam
           Version: 1.0.0-beta5
          Platform: Ubuntu Packages
        OS/Version: unspecified
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           1.0.0-beta5 (using KDE 4.3.1)
Installed from:    Ubuntu Packages

In Configure->Album View->Icon-View Options there is no option to show the type
of the image. Since many different version of the same image can be present it
could comfortable to allow the user to visually select the right one without
being forced to click on it and to look at the image name.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=208504


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|general                     |Albums GUI




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2009-09-25 15:52:28 ---
I'm totally agre with this. Other application use a small icon set on a corner
of thumbnail, with mime type ("raw", "jpg", "tif", "png", etc...)

As icon-view Qt4 model view port is done, this can be studied as well now...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=208504


Pieter Edelman <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Leonardo Giordani-2]

https://bugs.kde.org/show_bug.cgi?id=208504





--- Comment #2 from Leonardo Giordani <giordani leonardo gmail com>  2009-09-25 17:49:32 ---
See also https://bugs.kde.org/show_bug.cgi?id=148223

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=208504


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.0.0-beta5                 |1.0.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=208504


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Albums GUI                  |Thumbnails
            Version|1.0.0                       |2.0.0




--- Comment #3 from Gilles Caulier <caulier gilles gmail com>  2011-03-11 11:26:16 ---
Implemented in 2.0.0 :

http://www.flickr.com/photos/digikam/5516625907/sizes/o/in/photostream/

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=208504


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #4 from Gilles Caulier <caulier gilles gmail com>  2011-03-11 12:37:45 ---
Git commit 6173a3635952f343474898eb3706dbce63dc7fd7 by Gilles Caulier.
Committed on 11/03/2011 at 12:31.
Pushed by cgilles into branch 'master'.

new feature : print item file format over icon view item as Lightroom and
Aperture
See this screenshot for details :
http://www.flickr.com/photos/digikam/5516625907/sizes/o/in/photostream/
BUGS: 268098
BUGS: 148223
BUGS: 208504

M  +17   -14   digikam/items/digikamimagedelegate.cpp    
M  +1    -1    digikam/items/digikamimagedelegate.h    
M  +3    -4    digikam/items/digikamimagedelegatepriv.h    
M  +9    -2    digikam/items/imagedelegate.cpp    
M  +5    -3    digikam/items/imagedelegatepriv.h    
M  +16   -27   digikam/items/imagethumbnaildelegate.cpp    
M  +3    -2    digikam/items/imagethumbnaildelegate.h    
A  +66   -0    digikam/items/imagethumbnaildelegatepriv.h         [License: GPL
(v2+)]
M  +72   -51   digikam/utils/albumsettings.cpp    
M  +3    -0    digikam/utils/albumsettings.h    
M  +28   -0    libs/widgets/common/itemviewimagedelegate.cpp    
M  +1    -0    libs/widgets/common/itemviewimagedelegate.h    
M  +20   -12   utilities/setup/setupalbumview.cpp    
M  +2    -3    utilities/setup/setupalbumview.h    

http://commits.kde.org/digikam/6173a3635952f343474898eb3706dbce63dc7fd7

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=208504





--- Comment #5 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-03-11 20:54:54 ---
Do we really need to default to "Yes" for this option? That would mean that the
majority of users will want this switched on.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=208504





--- Comment #6 from Andi Clemens <andi clemens gmx net>  2011-03-11 20:59:45 ---
I would also prefer a default set to "off".
And, to have a consistent look, I would propose to align this icon with the
icon item border, not the thumbnail border.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=208504





--- Comment #7 from Gilles Caulier <caulier gilles gmail com>  2011-03-11 23:04:39 ---
Marcel, Andi,

I turned on by default to test it and give users feedback. If you find this
option too intrusive, i can turn off by default...

Andi, where do you want to place this mark exactly. There is no free place to
host this mark without to be over thumb. Try vertical thumbs, and different
size.
Mockup suggestions are welcome.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=208504





--- Comment #8 from Andi Clemens <andi clemens gmx net>  2011-03-12 00:16:38 ---
I thought of something like this:
http://www.flickr.com/photos/26732399@N05/sets/72157626121077651/

But right now I'm not sure if it doesn't look even worse :-)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=208504





--- Comment #9 from Gilles Caulier <caulier gilles gmail com>  2011-03-12 09:53:53 ---
Andi,

I already tried your proposal, and i haven't be convinced by this way.
Graphically, it's not perfect, not homogeneous.

On this entry :

https://bugs.kde.org/show_bug.cgi?id=268098#c18

...an user post a proposal. I'm not convinced too. It's not elegant.

Also, we have a problem with thumbbar (preview mode, editor, and later LT),
where no information is displayed under thumb, excepted rating.

How i can add file format info without to add a new line in thumbbar, which
will increase space consuming.

I studied a way to use filename line under thumb, to display both info :

- filename (without extension)
- file format (highlighted using same graphic way than currently under thumb)

In setup, both can be enable separately, as now. The line under thumb can be
show these information :

Only filename :            dsc123456
Filename + format:      dsc123456   JPG
Format only :                 JPG

There is no problem with icon view using this solution, but with thumbbar, the
new line must be displayed under thumb.

This solution has the advantage to not show format information under thumb of
course.

Your viewpoint please...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=208504


[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |finstrodelapradera-foros@ya
                   |                            |hoo.es




--- Comment #10 from  <finstrodelapradera-foros yahoo es>  2011-03-12 14:58:34 ---
Hi Gilles

You have reason, my last proposal was not elegant and even more complex to
code. I'm not a photography professinal, just average, but works in raw as
them. We liked too much DarkTable solution, but DigiKam has much more options
and flexibility to show info, so I like your proposal. In fact, this time I
send (will try, always make mistake on attaching files :(  )  a capture of my
own config and tried to not use not used space to show file format.
In file "Tag 1" is similar to your proposal, but in "Tag 2" we have a lot of
wasted space that will show format more clear, I think.

What do you think.

THANK YOU GILLES

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=208504





--- Comment #11 from  <finstrodelapradera-foros yahoo es>  2011-03-12 14:59:51 ---
Created an attachment (id=57901)
 --> (http://bugs.kde.org/attachment.cgi?id=57901)
Example 1 - Format tag next to file name

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=208504





--- Comment #12 from  <finstrodelapradera-foros yahoo es>  2011-03-12 15:01:57 ---
Created an attachment (id=57902)
 --> (http://bugs.kde.org/attachment.cgi?id=57902)
Example 2 - Format tag next to file size (more clear, I think)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=208504





--- Comment #13 from Andi Clemens <andi clemens gmx net>  2011-03-12 15:51:39 ---
I like the second version...

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=208504





--- Comment #14 from Gilles Caulier <caulier gilles gmail com>  2011-03-15 13:47:25 ---
Created an attachment (id=58031)
 --> (http://bugs.kde.org/attachment.cgi?id=58031)
patch to print item format outside thumb area

I think that none of both can be fine as well for the future. The reason is
about this entry :

https://bugs.kde.org/show_bug.cgi?id=148572

... and especially the way to print image file name behind thumbbar item, as
with icon view.

In Thumbbar, use currently icon-view model-view implementation (not yet in LT,
but it just a question of time)

The goal is to be able to print information under thummbar : Rating, filename,
and format.

The patch attached implement format printing outside thumb area :

1/ In icon-view, print format on the right side of image file name if both are
displayed (in this case, file name is without extension).

2/ If file name is not display, only format is displayed instead file name.

3/ In thumbbar (preview mode), this patch try to display file name and/or
format behind thumb. This point do not work yet. Please take a look...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=208504





--- Comment #15 from Gilles Caulier <caulier gilles gmail com>  2011-03-15 13:59:16 ---
Created an attachment (id=58033)
 --> (http://bugs.kde.org/attachment.cgi?id=58033)
icon view screenshot with patch #58031 applied. Case 1

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=208504





--- Comment #16 from Gilles Caulier <caulier gilles gmail com>  2011-03-15 14:00:15 ---
Created an attachment (id=58035)
 --> (http://bugs.kde.org/attachment.cgi?id=58035)
icon view screenshot with patch #58031 applied. Case 2

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=208504





--- Comment #17 from Gilles Caulier <caulier gilles gmail com>  2011-03-15 14:01:43 ---
Created an attachment (id=58037)
 --> (http://bugs.kde.org/attachment.cgi?id=58037)
icon view screenshot with patch #58031 applied. Case 3

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel